Re: `scroll-all-mode' hard to customize

Re: `scroll-all-mode' hard to customize

[Richard Stallman]

This patch looks correct.  Can you install it or do you
need someone else to do so?

To get it into 21.3, please install it in the RC branch
as well as the trunk.

From: John Paul Wallington <jpw@shootybangbang.com>
To: emacs-pretest-bug@gnu.org
Subject: `scroll-all-mode' hard to customize
Date: Sat, 27 Jul 2002 10:56:25 +0100

Symptoms:

M-x customize-variable scroll-all-mode

save its value to "Off"

restart Emacs - hey! it's on!

Here is a patch:

2002-07-27  John Paul Wallington  <jpw@shootybangbang.com>

	* scroll-all.el (scroll-all-mode): Handle numeric arg.  Use `if'
	instead of `cond'.

Index: scroll-all.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/scroll-all.el,v
retrieving revision 1.10
diff -u -r1.10 scroll-all.el
*** scroll-all.el	24 Apr 2002 20:37:04 -0000	1.10
--- scroll-all.el	27 Jul 2002 09:46:13 -0000
***************
*** 125,136 ****
  (defun scroll-all-mode (arg)
    "Toggle Scroll-All minor mode."
    (interactive "P")
!   (setq scroll-all-mode (not scroll-all-mode))
!   (cond
!    ((eq scroll-all-mode 't)
!     (add-hook 'post-command-hook 'scroll-all-check-to-scroll))
!    ((eq scroll-all-mode 'nil)
!     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll))))
  
  (provide 'scroll-all)
  
--- 125,136 ----
  (defun scroll-all-mode (arg)
    "Toggle Scroll-All minor mode."
    (interactive "P")
!   (setq scroll-all-mode
! 	(if (null arg) (not scroll-all-mode)
! 	  (> (prefix-numeric-value arg) 0)))
!   (if scroll-all-mode
!       (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
!     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
  
  (provide 'scroll-all)
  

In GNU Emacs 21.3.50.5 (i686-pc-linux-gnu, X toolkit)
 of 2002-07-25 on bundalo

-- 
John Paul Wallington

Re: `scroll-all-mode' hard to customize

[John Paul Wallington]

> This patch looks correct.  Can you install it or do you
> need someone else to do so?

I need someone else to do so.

> To get it into 21.3, please install it in the RC branch
> as well as the trunk.

-- 
John Paul Wallington

Re: `scroll-all-mode' hard to customize

[Glenn Morris]

John Paul Wallington wrote (on Mon, 29 Jul 2002 at 04:11 +0100):

> > This patch looks correct. Can you install it or do you need someone
> > else to do so?
> 
> I need someone else to do so.
> 
> > To get it into 21.3, please install it in the RC branch as well as the
> > trunk.

Since I was the last person to make any changes to scroll-all.el, I
installed your patch, in both the trunk and RC branch.

Re: `scroll-all-mode' hard to customize

[Richard Stallman]

    Since I was the last person to make any changes to scroll-all.el, I
    installed your patch, in both the trunk and RC branch.

Thanks for handling it.

Re: `scroll-all-mode' hard to customize

[Stefan Monnier]

> --- 125,136 ----
>   (defun scroll-all-mode (arg)
>     "Toggle Scroll-All minor mode."
>     (interactive "P")
> !   (setq scroll-all-mode
> ! 	(if (null arg) (not scroll-all-mode)
> ! 	  (> (prefix-numeric-value arg) 0)))
> !   (if scroll-all-mode
> !       (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
> !     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
>   
>   (provide 'scroll-all)

Better yet, use define-minor-mode.


	Stefan

--- scroll-all.el.~1.10.~	Fri Apr 26 14:03:51 2002
+++ scroll-all.el	Fri Aug  9 00:03:15 2002
@@ -39,26 +39,6 @@
 
 ;;; Code:
 
-(defvar running-xemacs (string-match "XEmacs\\|Lucid" emacs-version))
-
-;;;###autoload
-(defcustom scroll-all-mode nil
-  "Control/track scroll locking.
-
-Setting this variable directly does not take effect;
-use either \\[customize] or the function `scroll-all-mode'."
-  :set (lambda (symbol value) (scroll-all-mode (if value 1 0)))
-  :initialize 'custom-initialize-default
-  :require 'scroll-all
-  :type 'boolean
-  :group 'windows)
-
-(if running-xemacs
-    (add-minor-mode 'scroll-all-mode " *SL*")
-  (or (assq 'scroll-all-mode minor-mode-alist)
-      (setq minor-mode-alist
-	    (cons '(scroll-all-mode " *SL*") minor-mode-alist))))
-
 (defun scroll-all-function-all (func arg)
   "Apply function FUNC with argument ARG to all visible windows."
   (let ((num-windows (count-windows))
@@ -122,15 +102,12 @@
  
 
 ;;;###autoload
-(defun scroll-all-mode (arg)
+(define-minor-mode scroll-all-mode " *SL*"
   "Toggle Scroll-All minor mode."
-  (interactive "P")
-  (setq scroll-all-mode (not scroll-all-mode))
-  (cond
-   ((eq scroll-all-mode 't)
-    (add-hook 'post-command-hook 'scroll-all-check-to-scroll))
-   ((eq scroll-all-mode 'nil)
-    (remove-hook 'post-command-hook 'scroll-all-check-to-scroll))))
+  :global t
+  (if scroll-all-mode
+      (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
+    (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
 
 (provide 'scroll-all)