From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: `scroll-all-mode' hard to customize Date: Sun, 28 Jul 2002 19:12:53 -0600 (MDT) Sender: emacs-devel-admin@gnu.org Message-ID: <200207290112.g6T1Crp12929@aztec.santafe.edu> References: Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1027905257 745 127.0.0.1 (29 Jul 2002 01:14:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 29 Jul 2002 01:14:17 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17Yz71-0000Bt-00 for ; Mon, 29 Jul 2002 03:14:16 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17YzO0-0007iR-00 for ; Mon, 29 Jul 2002 03:31:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17Yz7N-0001Ba-00; Sun, 28 Jul 2002 21:14:37 -0400 Original-Received: from pele.santafe.edu ([192.12.12.119]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17Yz5i-0000y0-00; Sun, 28 Jul 2002 21:12:55 -0400 Original-Received: from aztec.santafe.edu (aztec [192.12.12.49]) by pele.santafe.edu (8.11.6+Sun/8.11.6) with ESMTP id g6T1D2B03024; Sun, 28 Jul 2002 19:13:02 -0600 (MDT) Original-Received: (from rms@localhost) by aztec.santafe.edu (8.10.2+Sun/8.9.3) id g6T1Crp12929; Sun, 28 Jul 2002 19:12:53 -0600 (MDT) X-Authentication-Warning: aztec.santafe.edu: rms set sender to rms@aztec using -f Original-To: jpw@shootybangbang.com In-Reply-To: (message from John Paul Wallington on Sat, 27 Jul 2002 10:56:25 +0100) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6119 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6119 This patch looks correct. Can you install it or do you need someone else to do so? To get it into 21.3, please install it in the RC branch as well as the trunk. From: John Paul Wallington To: emacs-pretest-bug@gnu.org Subject: `scroll-all-mode' hard to customize Date: Sat, 27 Jul 2002 10:56:25 +0100 Symptoms: M-x customize-variable scroll-all-mode save its value to "Off" restart Emacs - hey! it's on! Here is a patch: 2002-07-27 John Paul Wallington * scroll-all.el (scroll-all-mode): Handle numeric arg. Use `if' instead of `cond'. Index: scroll-all.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/scroll-all.el,v retrieving revision 1.10 diff -u -r1.10 scroll-all.el *** scroll-all.el 24 Apr 2002 20:37:04 -0000 1.10 --- scroll-all.el 27 Jul 2002 09:46:13 -0000 *************** *** 125,136 **** (defun scroll-all-mode (arg) "Toggle Scroll-All minor mode." (interactive "P") ! (setq scroll-all-mode (not scroll-all-mode)) ! (cond ! ((eq scroll-all-mode 't) ! (add-hook 'post-command-hook 'scroll-all-check-to-scroll)) ! ((eq scroll-all-mode 'nil) ! (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))) (provide 'scroll-all) --- 125,136 ---- (defun scroll-all-mode (arg) "Toggle Scroll-All minor mode." (interactive "P") ! (setq scroll-all-mode ! (if (null arg) (not scroll-all-mode) ! (> (prefix-numeric-value arg) 0))) ! (if scroll-all-mode ! (add-hook 'post-command-hook 'scroll-all-check-to-scroll) ! (remove-hook 'post-command-hook 'scroll-all-check-to-scroll))) (provide 'scroll-all) In GNU Emacs 21.3.50.5 (i686-pc-linux-gnu, X toolkit) of 2002-07-25 on bundalo -- John Paul Wallington