Re: `scroll-all-mode' hard to customize

[Richard Stallman <rms@gnu.org>]

This patch looks correct.  Can you install it or do you
need someone else to do so?

To get it into 21.3, please install it in the RC branch
as well as the trunk.

From: John Paul Wallington <jpw@shootybangbang.com>
To: emacs-pretest-bug@gnu.org
Subject: `scroll-all-mode' hard to customize
Date: Sat, 27 Jul 2002 10:56:25 +0100

Symptoms:

M-x customize-variable scroll-all-mode

save its value to "Off"

restart Emacs - hey! it's on!

Here is a patch:

2002-07-27  John Paul Wallington  <jpw@shootybangbang.com>

	* scroll-all.el (scroll-all-mode): Handle numeric arg.  Use `if'
	instead of `cond'.

Index: scroll-all.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/scroll-all.el,v
retrieving revision 1.10
diff -u -r1.10 scroll-all.el
*** scroll-all.el	24 Apr 2002 20:37:04 -0000	1.10
--- scroll-all.el	27 Jul 2002 09:46:13 -0000
***************
*** 125,136 ****
  (defun scroll-all-mode (arg)
    "Toggle Scroll-All minor mode."
    (interactive "P")
!   (setq scroll-all-mode (not scroll-all-mode))
!   (cond
!    ((eq scroll-all-mode 't)
!     (add-hook 'post-command-hook 'scroll-all-check-to-scroll))
!    ((eq scroll-all-mode 'nil)
!     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll))))
  
  (provide 'scroll-all)
  
--- 125,136 ----
  (defun scroll-all-mode (arg)
    "Toggle Scroll-All minor mode."
    (interactive "P")
!   (setq scroll-all-mode
! 	(if (null arg) (not scroll-all-mode)
! 	  (> (prefix-numeric-value arg) 0)))
!   (if scroll-all-mode
!       (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
!     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
  
  (provide 'scroll-all)
  

In GNU Emacs 21.3.50.5 (i686-pc-linux-gnu, X toolkit)
 of 2002-07-25 on bundalo

-- 
John Paul Wallington