From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, emacs-devel@gnu.org
Subject: Re: Lift {global,local}-key-binding to Lisp
Date: Fri, 15 Jan 2021 15:24:09 +0200 [thread overview]
Message-ID: <11389fbf-d937-e081-0a4a-bcb149defdf5@yandex.ru> (raw)
In-Reply-To: <83turi9ywk.fsf@gnu.org>
On 15.01.2021 14:18, Eli Zaretskii wrote:
>> Consider that, when a piece of code is implemented in Lisp, it's easier
>> for us "mere mortals" to find it, read, understand and debug it. Even
>> more so when it comes to people outside of emacs-devel.
>>
>> So as a result you should end up answering fewer questions about it.
>
> I invite you to have a look at the C implementation of these two
> functions, and then explain to me how the original code was any harder
> for "mere mortals" to understand, let alone trigger some questions.
It is, though of course the function is short.
As such, the arguments both for and against this change are relatively
weak. Surely you won't have many troubles because of this move either.
So both you and others in this thread are really arguing on principle.
Except for Stefan, who already did the work and wrote a couple of tests
(which, in the unlikely chance of failing, would be easier to debug in
Lisp), and tested the change manually, I'm sure.
I dig the argument about a certain loss of organization (keymap.c =>
simple.el), but that can be fixed in Lisp too, when/if we get more such
functions.
Oscars's argument about these two functions having already been written
in "would-rather-be-doing-this-on-Lisp" mindset is sensible too.
> Once again, we need to address this on a case by case basis; an
> abstract principle will fail to lead to wise, balanced decisions.
We need to have some guidelines, though, in order to avoid arguing about
every such commit.
Until now, the common thinking has been "we want to have more code in
Lisp, for its readability, discoverability and debuggability advantages
except for cases where it would make Emacs slower/less stable/etc".
Also consider that Debian with its packaging makes reading the Lisp
sources considerably easier than C sources. Same goes for builds on
other platforms, I imagine, probably to an even larger extent (Debian
does separate the Lisp sources to a package you have to install
additionally).
next prev parent reply other threads:[~2021-01-15 13:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 19:26 Lift {global,local}-key-binding to Lisp Eli Zaretskii
2021-01-14 19:24 ` Stefan Kangas
2021-01-14 20:10 ` Eli Zaretskii
2021-01-14 20:24 ` Eli Zaretskii
2021-01-15 1:58 ` Leo Liu
2021-01-15 4:16 ` Óscar Fuentes
2021-01-15 7:42 ` Eli Zaretskii
2021-01-21 16:03 ` Stefan Kangas
2021-01-21 16:59 ` [External] : " Drew Adams
2021-01-21 17:50 ` Dmitry Gutov
2021-01-21 18:16 ` Drew Adams
2021-01-21 18:58 ` Dmitry Gutov
2021-01-21 19:59 ` Eli Zaretskii
2021-01-14 21:03 ` Andrea Corallo via Emacs development discussions.
2021-01-15 7:45 ` Eli Zaretskii
2021-01-15 12:09 ` Dmitry Gutov
2021-01-15 12:18 ` Eli Zaretskii
2021-01-15 13:24 ` Dmitry Gutov [this message]
2021-01-15 13:45 ` Eli Zaretskii
2021-01-15 18:09 ` Dmitry Gutov
2021-01-17 14:27 ` Christopher Miles
2021-01-15 18:03 ` Drew Adams
2021-01-16 0:51 ` Leo Liu
2021-01-17 14:33 ` Christopher Miles
2021-01-17 15:08 ` Eli Zaretskii
2021-01-18 3:29 ` Christopher Miles
2021-01-18 16:43 ` Eli Zaretskii
2021-01-17 16:10 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11389fbf-d937-e081-0a4a-bcb149defdf5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).