unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Lift {global,local}-key-binding to Lisp
Date: Wed, 13 Jan 2021 21:26:37 +0200	[thread overview]
Message-ID: <83zh1cbpua.fsf@gnu.org> (raw)

  commit a9658cd5b07e88a5d413cbb4dfd8f9d9d0c8bbf5
  Author:     Stefan Kangas <stefan@marxist.se>
  AuthorDate: Wed Jan 13 18:54:09 2021 +0100
  Commit:     Stefan Kangas <stefan@marxist.se>
  CommitDate: Wed Jan 13 18:54:09 2021 +0100

      Lift {global,local}-key-binding to Lisp

      * lisp/subr.el (local-key-binding, global-key-binding): New defuns.
      * src/keymap.c (Flocal_key_binding, Fglobal_key_binding): Remove DEFUNs.
      (syms_of_keymap): Remove defsubrs for above DEFUNs.
      * test/lisp/subr-tests.el (subr-test-local-key-binding)
      (subr-test-global-key-binding): New tests.

Stefan, why are we moving these and other functions to Lisp?  Are
there any advantages to moving them?  Is there any plan behind this
and other similar changes?

And why don't we discuss such changes before making them?

In general, unless we get some significant gains, I'd prefer not to
move around code just to move it.  If nothing else, it makes it harder
for people who, like me, are familiar with the original code, to find
stuff, because suddenly it isn't where it used to be.  The result is
that I cannot use my memory anymore, I need to consult the code each
time I need to answer some question or consider something related to
this code.  It's a needless churn, and I ask myself what do we gain in
return?



             reply	other threads:[~2021-01-13 19:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 19:26 Eli Zaretskii [this message]
2021-01-14 19:24 ` Lift {global,local}-key-binding to Lisp Stefan Kangas
2021-01-14 20:10   ` Eli Zaretskii
2021-01-14 20:24     ` Eli Zaretskii
2021-01-15  1:58     ` Leo Liu
2021-01-15  4:16     ` Óscar Fuentes
2021-01-15  7:42       ` Eli Zaretskii
2021-01-21 16:03     ` Stefan Kangas
2021-01-21 16:59       ` [External] : " Drew Adams
2021-01-21 17:50         ` Dmitry Gutov
2021-01-21 18:16           ` Drew Adams
2021-01-21 18:58             ` Dmitry Gutov
2021-01-21 19:59       ` Eli Zaretskii
2021-01-14 21:03   ` Andrea Corallo via Emacs development discussions.
2021-01-15  7:45     ` Eli Zaretskii
2021-01-15 12:09 ` Dmitry Gutov
2021-01-15 12:18   ` Eli Zaretskii
2021-01-15 13:24     ` Dmitry Gutov
2021-01-15 13:45       ` Eli Zaretskii
2021-01-15 18:09         ` Dmitry Gutov
2021-01-17 14:27           ` Christopher Miles
2021-01-15 18:03       ` Drew Adams
2021-01-16  0:51   ` Leo Liu
2021-01-17 14:33     ` Christopher Miles
2021-01-17 15:08       ` Eli Zaretskii
2021-01-18  3:29         ` Christopher Miles
2021-01-18 16:43           ` Eli Zaretskii
2021-01-17 16:10       ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zh1cbpua.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).