unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Dimech <dimech@gmx.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contovob@tcd.ie, Protesilaos Stavrou <info@protesilaos.com>,
	stefankangas@gmail.com, 45068@debbugs.gnu.org, juri@linkov.net
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Fri, 11 Dec 2020 19:56:43 +0100	[thread overview]
Message-ID: <trinity-cab70f2c-7118-4b7e-a794-4a2fe1e4b785-1607713003563@3c-app-mailcom-bs06> (raw)
In-Reply-To: <83lfe4192f.fsf@gnu.org>

> Sent: Friday, December 11, 2020 at 7:39 PM
> From: "Eli Zaretskii" <eliz@gnu.org>
> To: "Protesilaos Stavrou" <info@protesilaos.com>
> Cc: contovob@tcd.ie, 45068@debbugs.gnu.org, stefankangas@gmail.com, juri@linkov.net
> Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
>
> > From: Protesilaos Stavrou <info@protesilaos.com>
> > Cc: Stefan Kangas <stefankangas@gmail.com>,  juri@linkov.net,
> >   contovob@tcd.ie,  45068@debbugs.gnu.org
> > Date: Fri, 11 Dec 2020 17:53:34 +0200
> >
> > >> > What theme-related files need to be byte-compiled, and why?
> > >>
> > >> I believe the issues involved are explained in some detail in the first
> > >> message in this bug report.
> > >
> > > If they are, I'm missing that.  All I see is an assertion that the
> > > files must be byte-compiled:
> > >
> > >> The problem with contributing this new code to Emacs is that it cannot
> > >> work if it is placed in ../etc/themes/.  Instead, the files need to be
> > >> in a path that handles byte-compilation, like ../lisp/modus-themes/.
> > >
> > > I'm probably missing something, and that is what I'm asking to
> > > elaborate on.
> >
> > There now are four *.el files that make up the project:
> >
> > + modus-themes.el contains all defcustom, color palettes as alists,
> >   helper functions, and the face specs.
> >
> > + modus-themes-core.el contains a macro that 'let' binds the
> >   aforementioned alists around 'custom-theme-set-faces' and
> >   'custom-theme-set-variables'.
> >
> > + modus-{operandi-vivendi}-theme.el contain a 'deftheme' and concomitant
> >   'provide-theme' referencing each of them and just expand the macro.
> >
> >   - Each of those files has (require 'modus-themes) and
> >     (eval-when-compile (require 'modus-themes-core)).  Though I also
> >     tried without the eval-when-compile part.
> >
> > When I attempted to place all four files in etc/themes/ and then start a
> > new 'emacs -Q' session, M-x load-theme RET modus-{operandi,vivendi}
> > would throw an error:
> >
> >     Cannot open load file: No such file or directory, modus-themes
>
> So this is not about byte-compiling, it's about being able to load
> some of the files that constitute this group of themes?
>
> If so, I see several possibilities:
>
>   . make a single file with all the functionalities
>   . invent a new function custom-require that would search the custom
>     load-path, and use that instead of 'require'
>   . don't consider this a "theme", but a normal Lisp package (since it
>     basically violates the conventions for writing a theme)

It is still a theme though.  What conventions does it violate, briefly?
Not being a single file?






  reply	other threads:[~2020-12-11 18:56 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 12:23 bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Protesilaos Stavrou
2020-12-08 12:03 ` Basil L. Contovounesios
2020-12-09 21:58   ` Stefan Kangas
2020-12-10  7:57     ` Protesilaos Stavrou
2020-12-10  8:25       ` Stefan Kangas
2020-12-10 11:46         ` Protesilaos Stavrou
2020-12-11  9:37           ` Juri Linkov
2020-12-11 13:21             ` Stefan Kangas
2020-12-11 13:52               ` Eli Zaretskii
2020-12-11 14:16                 ` Stefan Kangas
2020-12-11 14:32                   ` Eli Zaretskii
2020-12-11 15:15                     ` Stefan Kangas
2020-12-11 15:32                       ` Eli Zaretskii
2020-12-11 15:42                         ` Christopher Dimech
2020-12-11 15:53                         ` Protesilaos Stavrou
2020-12-11 18:39                           ` Eli Zaretskii
2020-12-11 18:56                             ` Christopher Dimech [this message]
2020-12-11 20:16                               ` Eli Zaretskii
2020-12-11 20:29                                 ` Christopher Dimech
2020-12-11 19:08                             ` Stefan Kangas
2020-12-11 20:05                               ` Christopher Dimech
2020-12-11 20:14                               ` Eli Zaretskii
2020-12-11 20:21                                 ` Christopher Dimech
2021-01-25  8:49                                 ` bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-01-25 12:51                                   ` Christopher Dimech
2021-01-25 15:34                                   ` Eli Zaretskii
2021-02-25  6:09                                     ` bug#45068: Patch for Modus themes 1.1.1? Protesilaos Stavrou
2021-02-25 14:44                                       ` Eli Zaretskii
2021-02-27  2:35                                         ` Protesilaos Stavrou
2021-02-27  8:15                                           ` Eli Zaretskii
2021-02-27  8:53                                             ` Protesilaos Stavrou
2021-02-28  6:30                                             ` Protesilaos Stavrou
2021-02-28 11:41                                               ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-02-28 12:45                                                 ` Protesilaos Stavrou
     [not found]                                                   ` <87lfb8l2wr.fsf@tcd.ie>
2021-02-28 14:13                                                     ` Protesilaos Stavrou
     [not found]                                                     ` <87a6roxou1.fsf@protesilaos.com>
     [not found]                                                       ` <87im6cfcex.fsf@tcd.ie>
2021-02-28 15:57                                                         ` Protesilaos Stavrou
     [not found]                                                   ` <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com>
2021-02-28 13:56                                                     ` Protesilaos Stavrou
2021-03-01 14:38                                                     ` Eli Zaretskii
2021-03-01 14:52                                                       ` Protesilaos Stavrou
2021-03-01 15:16                                                         ` Mauro Aranda
2021-03-01 15:35                                                           ` Protesilaos Stavrou
2021-03-01 19:58                                                             ` Basil L. Contovounesios
2021-03-01 20:06                                                               ` Mauro Aranda
2021-03-01 20:03                                                             ` Mauro Aranda
2021-03-01 23:34                                                             ` Basil L. Contovounesios
2021-03-02  5:47                                                               ` Protesilaos Stavrou
2021-03-02  5:51                                                                 ` Eli Zaretskii
2021-03-02 10:35                                                                   ` Basil L. Contovounesios
2021-03-02 10:32                                                                 ` Basil L. Contovounesios
2021-03-02 10:59                                                                   ` Protesilaos Stavrou
2021-03-02 11:03                                                                   ` Mauro Aranda
2021-03-02 11:38                                                                     ` Basil L. Contovounesios
2021-03-02 11:56                                                                       ` Mauro Aranda
2021-03-03 16:31                                                                   ` Basil L. Contovounesios
2021-03-03 18:06                                                                     ` Protesilaos Stavrou
2021-03-04  2:04                                                                       ` Basil L. Contovounesios
2021-03-04  4:53                                                                         ` Protesilaos Stavrou
2021-03-04 12:32                                                                     ` Mauro Aranda
2021-03-04 14:54                                                                       ` bug#45068: [PATCH] Modus themes 1.2.0 (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-03-04 16:53                                                                         ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-04 18:41                                                                         ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-04 20:57                                                                           ` Protesilaos Stavrou
2021-03-04 22:06                                                                             ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-05  6:34                                                                               ` Protesilaos Stavrou
2021-03-05 17:11                                                                                 ` Basil L. Contovounesios
2021-03-05 17:34                                                                                   ` Protesilaos Stavrou
2021-03-04 22:40                                                                             ` Mauro Aranda
2021-03-05  6:07                                                                               ` Protesilaos Stavrou
2021-03-05 17:11                                                                             ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-05 17:50                                                                               ` Protesilaos Stavrou
2021-03-05 22:00                                                                                 ` Basil L. Contovounesios
2021-03-06  5:13                                                                                   ` Protesilaos Stavrou
2021-03-06  9:29                                                                                     ` Basil L. Contovounesios
2021-03-05 21:11                                                                             ` Gregory Heytings
2021-03-06 13:24                                                                               ` Gregory Heytings
2021-03-06 15:22                                                                                 ` Protesilaos Stavrou
2021-03-06 18:25                                                                                   ` Gregory Heytings
2021-03-06 18:43                                                                                     ` Protesilaos Stavrou
2021-03-04 15:47                                                                       ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Basil L. Contovounesios
2020-12-11 14:32                   ` Christopher Dimech
2020-12-11 16:05                   ` Protesilaos Stavrou
2020-12-11 16:31                     ` Christopher Dimech
2020-12-11 14:25                 ` Christopher Dimech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=trinity-cab70f2c-7118-4b7e-a794-4a2fe1e4b785-1607713003563@3c-app-mailcom-bs06 \
    --to=dimech@gmx.com \
    --cc=45068@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=info@protesilaos.com \
    --cc=juri@linkov.net \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).