unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Gregory Heytings <gregory@heytings.org>
Cc: 45068@debbugs.gnu.org
Subject: bug#45068: [PATCH] Modus themes 1.2.0
Date: Sat, 06 Mar 2021 20:43:48 +0200	[thread overview]
Message-ID: <878s70f7h7.fsf@protesilaos.com> (raw)
In-Reply-To: <7de1aeec5249455d448b@heytings.org> (Gregory Heytings's message of "Sat, 06 Mar 2021 18:25:22 +0000")

On 2021-03-06, 18:25 +0000, Gregory Heytings <gregory@heytings.org> wrote:

>>
>> It works.  Thank you!
>>
>
> You are welcome :-)  Actually the previous version had a bug with
> tab-indented lines.  It is fixed now:
>
> (defun undercaret (&optional arg)
>   (interactive "p")
>   (let* ((begin (if (region-active-p) (region-beginning) (line-beginning-position)))
>          (end (if (region-active-p) (region-end) (line-end-position)))
>          (lines (- (line-number-at-pos end) (line-number-at-pos begin) -1))
>          (comment (and (/= arg 1) (= lines 1)))
>          (final-forward-line -1))
>     (goto-char begin)
>     (dotimes (i lines)
>       (let* ((line-begin (if (zerop i) begin (line-beginning-position)))
>              (line-end (if (= (1+ i) lines) end (line-end-position)))
>              (begin-column (progn (goto-char line-begin) (current-column)))
>              (end-column (progn (goto-char line-end) (current-column)))
>              (prefix-begin (line-beginning-position))
>              (prefix-end (progn (beginning-of-line-text) (point)))
>              (prefix-end-column (progn (goto-char prefix-end) (current-column)))
>              (delta (if (< begin-column prefix-end-column) (- prefix-end-column begin-column) 0))
>              (prefix-string (buffer-substring-no-properties prefix-begin prefix-end))
>              (prefix (if (string-match-p "\\` *\\'" prefix-string) "" prefix-string))
>              (whitespace (make-string (- (+ begin-column delta) (string-width prefix)) ?\ ))
>              (do-under (< delta (- line-end line-begin)))
>              (under (if do-under (make-string (- end-column begin-column delta) ?^) ""))
>              (under-string (concat prefix whitespace under "\n")))
>         (forward-line 1)
>         (if do-under (insert under-string) (setq final-forward-line -2))
>         (setq end (+ end (length under-string)))
>         (when comment (insert prefix whitespace "\n"))))
>     (forward-line final-forward-line)
>     (goto-char (line-end-position))))

I admit not to have tested it thoroughly (not yet, anyway).  Though I do
plan to use your function.  Thanks!

I will eventually include it in my public dotfiles' repo.  Is there a
link I could provide as a reference to your contribution?  Or just cite
the message in this thread?[1]

[1]: <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45068#250>.

> (BTW, sorry for the off-topic noise on your thread on modus-themes, but
> it was you who asked for a solution ;-))

Yes, I guess this is not the right place to discuss this feature...
Though the bug has been closed successfully.

I had asked because I was under the impression that Gnus or some other
library was implementing it.

-- 
Protesilaos Stavrou
protesilaos.com





  reply	other threads:[~2021-03-06 18:43 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 12:23 bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Protesilaos Stavrou
2020-12-08 12:03 ` Basil L. Contovounesios
2020-12-09 21:58   ` Stefan Kangas
2020-12-10  7:57     ` Protesilaos Stavrou
2020-12-10  8:25       ` Stefan Kangas
2020-12-10 11:46         ` Protesilaos Stavrou
2020-12-11  9:37           ` Juri Linkov
2020-12-11 13:21             ` Stefan Kangas
2020-12-11 13:52               ` Eli Zaretskii
2020-12-11 14:16                 ` Stefan Kangas
2020-12-11 14:32                   ` Eli Zaretskii
2020-12-11 15:15                     ` Stefan Kangas
2020-12-11 15:32                       ` Eli Zaretskii
2020-12-11 15:42                         ` Christopher Dimech
2020-12-11 15:53                         ` Protesilaos Stavrou
2020-12-11 18:39                           ` Eli Zaretskii
2020-12-11 18:56                             ` Christopher Dimech
2020-12-11 20:16                               ` Eli Zaretskii
2020-12-11 20:29                                 ` Christopher Dimech
2020-12-11 19:08                             ` Stefan Kangas
2020-12-11 20:05                               ` Christopher Dimech
2020-12-11 20:14                               ` Eli Zaretskii
2020-12-11 20:21                                 ` Christopher Dimech
2021-01-25  8:49                                 ` bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-01-25 12:51                                   ` Christopher Dimech
2021-01-25 15:34                                   ` Eli Zaretskii
2021-02-25  6:09                                     ` bug#45068: Patch for Modus themes 1.1.1? Protesilaos Stavrou
2021-02-25 14:44                                       ` Eli Zaretskii
2021-02-27  2:35                                         ` Protesilaos Stavrou
2021-02-27  8:15                                           ` Eli Zaretskii
2021-02-27  8:53                                             ` Protesilaos Stavrou
2021-02-28  6:30                                             ` Protesilaos Stavrou
2021-02-28 11:41                                               ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-02-28 12:45                                                 ` Protesilaos Stavrou
     [not found]                                                   ` <87lfb8l2wr.fsf@tcd.ie>
2021-02-28 14:13                                                     ` Protesilaos Stavrou
     [not found]                                                     ` <87a6roxou1.fsf@protesilaos.com>
     [not found]                                                       ` <87im6cfcex.fsf@tcd.ie>
2021-02-28 15:57                                                         ` Protesilaos Stavrou
     [not found]                                                   ` <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com>
2021-02-28 13:56                                                     ` Protesilaos Stavrou
2021-03-01 14:38                                                     ` Eli Zaretskii
2021-03-01 14:52                                                       ` Protesilaos Stavrou
2021-03-01 15:16                                                         ` Mauro Aranda
2021-03-01 15:35                                                           ` Protesilaos Stavrou
2021-03-01 19:58                                                             ` Basil L. Contovounesios
2021-03-01 20:06                                                               ` Mauro Aranda
2021-03-01 20:03                                                             ` Mauro Aranda
2021-03-01 23:34                                                             ` Basil L. Contovounesios
2021-03-02  5:47                                                               ` Protesilaos Stavrou
2021-03-02  5:51                                                                 ` Eli Zaretskii
2021-03-02 10:35                                                                   ` Basil L. Contovounesios
2021-03-02 10:32                                                                 ` Basil L. Contovounesios
2021-03-02 10:59                                                                   ` Protesilaos Stavrou
2021-03-02 11:03                                                                   ` Mauro Aranda
2021-03-02 11:38                                                                     ` Basil L. Contovounesios
2021-03-02 11:56                                                                       ` Mauro Aranda
2021-03-03 16:31                                                                   ` Basil L. Contovounesios
2021-03-03 18:06                                                                     ` Protesilaos Stavrou
2021-03-04  2:04                                                                       ` Basil L. Contovounesios
2021-03-04  4:53                                                                         ` Protesilaos Stavrou
2021-03-04 12:32                                                                     ` Mauro Aranda
2021-03-04 14:54                                                                       ` bug#45068: [PATCH] Modus themes 1.2.0 (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-03-04 16:53                                                                         ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-04 18:41                                                                         ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-04 20:57                                                                           ` Protesilaos Stavrou
2021-03-04 22:06                                                                             ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-05  6:34                                                                               ` Protesilaos Stavrou
2021-03-05 17:11                                                                                 ` Basil L. Contovounesios
2021-03-05 17:34                                                                                   ` Protesilaos Stavrou
2021-03-04 22:40                                                                             ` Mauro Aranda
2021-03-05  6:07                                                                               ` Protesilaos Stavrou
2021-03-05 17:11                                                                             ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-05 17:50                                                                               ` Protesilaos Stavrou
2021-03-05 22:00                                                                                 ` Basil L. Contovounesios
2021-03-06  5:13                                                                                   ` Protesilaos Stavrou
2021-03-06  9:29                                                                                     ` Basil L. Contovounesios
2021-03-05 21:11                                                                             ` Gregory Heytings
2021-03-06 13:24                                                                               ` Gregory Heytings
2021-03-06 15:22                                                                                 ` Protesilaos Stavrou
2021-03-06 18:25                                                                                   ` Gregory Heytings
2021-03-06 18:43                                                                                     ` Protesilaos Stavrou [this message]
2021-03-04 15:47                                                                       ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Basil L. Contovounesios
2020-12-11 14:32                   ` Christopher Dimech
2020-12-11 16:05                   ` Protesilaos Stavrou
2020-12-11 16:31                     ` Christopher Dimech
2020-12-11 14:25                 ` Christopher Dimech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s70f7h7.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=45068@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).