From: Mauro Aranda <maurooaranda@gmail.com>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 45068@debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Sun, 28 Feb 2021 08:41:34 -0300 [thread overview]
Message-ID: <603b8171.1c69fb81.aa664.7f40@mx.google.com> (raw)
In-Reply-To: <874khwn1qf.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 28 Feb 2021 08:30:16 +0200")
Hi Protesilaos,
Protesilaos Stavrou <info@protesilaos.com> writes:
> (defun require-theme (theme &optional directories)
> "Load THEME stored in `custom-theme-load-path'.
>
> THEME is a symbol or string that corresponds to the file name without
> its file type extension. That is assumed to be either '.el' or '.elc'.
>
> If THEME names a valid theme, load and enable it. Otherwise load the
> file, if present. In the latter case, the file is intended to work as
> the basis of a theme declared with `deftheme'.
>
> With optional DIRECTORIES as a list of filesystem paths, search
> for THEME file in those locations instead and load it, if present."
> (let* ((theme-dirs (custom-theme--load-path))
> (custom-dirs (when (and directories (listp directories))
> directories))
> (theme-name (cond
> ((stringp theme)
> theme)
> ((symbolp theme)
> (format "%s" theme))
I think it's better to use `symbol-name' when you're sure it's a symbol.
> (cond
> ((custom-theme-p theme)
> (load-theme theme t))
Some comments about this clause:
The docstring says a valid theme, but this checks for a "known" theme.
I think the docstring should clarify that.
Also, in this clause you don't need all the early work for locating the
file.
More important: doesn't this make it possible to load a non-safe theme
(as controlled by `custom-safe-themes') behind the user's back?
> This works in two ways:
>
> 1. To load a theme's dependency:
>
> (require-theme 'modus-themes)
>
> 2. To load and enable a theme:
>
> (require-theme 'modus-operandi)
IIUC, (2) works only after the theme is "known".
next prev parent reply other threads:[~2021-02-28 11:41 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 12:23 bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Protesilaos Stavrou
2020-12-08 12:03 ` Basil L. Contovounesios
2020-12-09 21:58 ` Stefan Kangas
2020-12-10 7:57 ` Protesilaos Stavrou
2020-12-10 8:25 ` Stefan Kangas
2020-12-10 11:46 ` Protesilaos Stavrou
2020-12-11 9:37 ` Juri Linkov
2020-12-11 13:21 ` Stefan Kangas
2020-12-11 13:52 ` Eli Zaretskii
2020-12-11 14:16 ` Stefan Kangas
2020-12-11 14:32 ` Eli Zaretskii
2020-12-11 15:15 ` Stefan Kangas
2020-12-11 15:32 ` Eli Zaretskii
2020-12-11 15:42 ` Christopher Dimech
2020-12-11 15:53 ` Protesilaos Stavrou
2020-12-11 18:39 ` Eli Zaretskii
2020-12-11 18:56 ` Christopher Dimech
2020-12-11 20:16 ` Eli Zaretskii
2020-12-11 20:29 ` Christopher Dimech
2020-12-11 19:08 ` Stefan Kangas
2020-12-11 20:05 ` Christopher Dimech
2020-12-11 20:14 ` Eli Zaretskii
2020-12-11 20:21 ` Christopher Dimech
2021-01-25 8:49 ` bug#45068: Patch for Modus themes 1.1.1? (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-01-25 12:51 ` Christopher Dimech
2021-01-25 15:34 ` Eli Zaretskii
2021-02-25 6:09 ` bug#45068: Patch for Modus themes 1.1.1? Protesilaos Stavrou
2021-02-25 14:44 ` Eli Zaretskii
2021-02-27 2:35 ` Protesilaos Stavrou
2021-02-27 8:15 ` Eli Zaretskii
2021-02-27 8:53 ` Protesilaos Stavrou
2021-02-28 6:30 ` Protesilaos Stavrou
2021-02-28 11:41 ` Mauro Aranda [this message]
2021-02-28 12:45 ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Protesilaos Stavrou
[not found] ` <87lfb8l2wr.fsf@tcd.ie>
2021-02-28 14:13 ` Protesilaos Stavrou
[not found] ` <87a6roxou1.fsf@protesilaos.com>
[not found] ` <87im6cfcex.fsf@tcd.ie>
2021-02-28 15:57 ` Protesilaos Stavrou
[not found] ` <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com>
2021-02-28 13:56 ` Protesilaos Stavrou
2021-03-01 14:38 ` Eli Zaretskii
2021-03-01 14:52 ` Protesilaos Stavrou
2021-03-01 15:16 ` Mauro Aranda
2021-03-01 15:35 ` Protesilaos Stavrou
2021-03-01 19:58 ` Basil L. Contovounesios
2021-03-01 20:06 ` Mauro Aranda
2021-03-01 20:03 ` Mauro Aranda
2021-03-01 23:34 ` Basil L. Contovounesios
2021-03-02 5:47 ` Protesilaos Stavrou
2021-03-02 5:51 ` Eli Zaretskii
2021-03-02 10:35 ` Basil L. Contovounesios
2021-03-02 10:32 ` Basil L. Contovounesios
2021-03-02 10:59 ` Protesilaos Stavrou
2021-03-02 11:03 ` Mauro Aranda
2021-03-02 11:38 ` Basil L. Contovounesios
2021-03-02 11:56 ` Mauro Aranda
2021-03-03 16:31 ` Basil L. Contovounesios
2021-03-03 18:06 ` Protesilaos Stavrou
2021-03-04 2:04 ` Basil L. Contovounesios
2021-03-04 4:53 ` Protesilaos Stavrou
2021-03-04 12:32 ` Mauro Aranda
2021-03-04 14:54 ` bug#45068: [PATCH] Modus themes 1.2.0 (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)) Protesilaos Stavrou
2021-03-04 16:53 ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-04 18:41 ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-04 20:57 ` Protesilaos Stavrou
2021-03-04 22:06 ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Mauro Aranda
2021-03-05 6:34 ` Protesilaos Stavrou
2021-03-05 17:11 ` Basil L. Contovounesios
2021-03-05 17:34 ` Protesilaos Stavrou
2021-03-04 22:40 ` Mauro Aranda
2021-03-05 6:07 ` Protesilaos Stavrou
2021-03-05 17:11 ` bug#45068: [PATCH] Modus themes 1.2.0 Basil L. Contovounesios
2021-03-05 17:50 ` Protesilaos Stavrou
2021-03-05 22:00 ` Basil L. Contovounesios
2021-03-06 5:13 ` Protesilaos Stavrou
2021-03-06 9:29 ` Basil L. Contovounesios
2021-03-05 21:11 ` Gregory Heytings
2021-03-06 13:24 ` Gregory Heytings
2021-03-06 15:22 ` Protesilaos Stavrou
2021-03-06 18:25 ` Gregory Heytings
2021-03-06 18:43 ` Protesilaos Stavrou
2021-03-04 15:47 ` bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Basil L. Contovounesios
2020-12-11 14:32 ` Christopher Dimech
2020-12-11 16:05 ` Protesilaos Stavrou
2020-12-11 16:31 ` Christopher Dimech
2020-12-11 14:25 ` Christopher Dimech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603b8171.1c69fb81.aa664.7f40@mx.google.com \
--to=maurooaranda@gmail.com \
--cc=45068@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).