bug#1858: cleanup: POLL_FOR_INPUT

bug#1858: cleanup: POLL_FOR_INPUT

[Dan Nicolaescu]

POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
exactly the same way:


keyboard.c:
/* If we support a window system, turn on the code to poll periodically
   to detect C-g.  It isn't actually used when doing interrupt input.
   */
#ifdef HAVE_WINDOW_SYSTEM
#define POLL_FOR_INPUT
#endif


process.c:
/* If we support a window system, turn on the code to poll periodically
   to detect C-g.  It isn't actually used when doing interrupt input.
   */
#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
#define POLL_FOR_INPUT
#endif

keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
before POLL_FOR_INPUT is defined...

The above is messy...

bug#1858: cleanup: POLL_FOR_INPUT

[Lars Magne Ingebrigtsen]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...

keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:

> #ifdef HAVE_WINDOW_SYSTEM

> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#1858: cleanup: POLL_FOR_INPUT

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> #ifdef HAVE_WINDOW_SYSTEM
>
>> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
>
> Is this a bug, or are the two .c files supposed to have different
> conditions for when to switch POLL_FOR_INPUT on?

Looking at the changelogs, the version in keyboard.c was newer, so I
used the 

#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

in process.h, too.  I 

Somebody can probably correct this if this is wrong.  :-)

However, I have no idea what USE_ASYNC_EVENTS refer to, since it isn't
mention anywhere else in any of the files.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/