unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 1858@debbugs.gnu.org
Subject: bug#1858: cleanup: POLL_FOR_INPUT
Date: Sun, 10 Jul 2011 16:52:14 +0200	[thread overview]
Message-ID: <m3pqlichnl.fsf@quimbies.gnus.org> (raw)
In-Reply-To: <200901111730.n0BHURDq001423@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 11 Jan 2009 09:30:27 -0800 (PST)")

Dan Nicolaescu <dann@ics.uci.edu> writes:

> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...

keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:

> #ifdef HAVE_WINDOW_SYSTEM

> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





  reply	other threads:[~2011-07-10 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 17:30 bug#1858: cleanup: POLL_FOR_INPUT Dan Nicolaescu
2011-07-10 14:52 ` Lars Magne Ingebrigtsen [this message]
2011-07-16 18:31   ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqlichnl.fsf@quimbies.gnus.org \
    --to=larsi@gnus.org \
    --cc=1858@debbugs.gnu.org \
    --cc=dann@ics.uci.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).