* bug#1858: cleanup: POLL_FOR_INPUT
@ 2009-01-11 17:30 Dan Nicolaescu
2011-07-10 14:52 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2009-01-11 17:30 UTC (permalink / raw)
To: bug-gnu-emacs
POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
exactly the same way:
keyboard.c:
/* If we support a window system, turn on the code to poll periodically
to detect C-g. It isn't actually used when doing interrupt input.
*/
#ifdef HAVE_WINDOW_SYSTEM
#define POLL_FOR_INPUT
#endif
process.c:
/* If we support a window system, turn on the code to poll periodically
to detect C-g. It isn't actually used when doing interrupt input.
*/
#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
#define POLL_FOR_INPUT
#endif
keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
before POLL_FOR_INPUT is defined...
The above is messy...
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#1858: cleanup: POLL_FOR_INPUT
2009-01-11 17:30 bug#1858: cleanup: POLL_FOR_INPUT Dan Nicolaescu
@ 2011-07-10 14:52 ` Lars Magne Ingebrigtsen
2011-07-16 18:31 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-10 14:52 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 1858
Dan Nicolaescu <dann@ics.uci.edu> writes:
> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
> to detect C-g. It isn't actually used when doing interrupt input.
> */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
> to detect C-g. It isn't actually used when doing interrupt input.
> */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...
keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:
> #ifdef HAVE_WINDOW_SYSTEM
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#1858: cleanup: POLL_FOR_INPUT
2011-07-10 14:52 ` Lars Magne Ingebrigtsen
@ 2011-07-16 18:31 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-16 18:31 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 1858
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> #ifdef HAVE_WINDOW_SYSTEM
>
>> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
>
> Is this a bug, or are the two .c files supposed to have different
> conditions for when to switch POLL_FOR_INPUT on?
Looking at the changelogs, the version in keyboard.c was newer, so I
used the
#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
in process.h, too. I
Somebody can probably correct this if this is wrong. :-)
However, I have no idea what USE_ASYNC_EVENTS refer to, since it isn't
mention anywhere else in any of the files.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-16 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-11 17:30 bug#1858: cleanup: POLL_FOR_INPUT Dan Nicolaescu
2011-07-10 14:52 ` Lars Magne Ingebrigtsen
2011-07-16 18:31 ` Lars Magne Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).