bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable

bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable

[Thomas Fitzsimmons]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi,

I updated to the emacs-28 branch recently.  When I first tried to
complete an e-mail address using eudc-expand-inline I saw this error:

    Symbol's value as variable is void: records

It turned out to be a quoting issue in eudc-bbdb-query-internal in the
EUDC BBDB backend.  It looks like this was introduced by the change to
lexical-binding.  The attached patch fixes the issue (though, the
quoting that works now is different from what was there before the
lexical-binding change).

Does it look OK to push to emacs-28?

Thanks,
Thomas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-EUDC-Fix-a-quoting-bug-in-the-BBDB-backend.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]

From e58ecd01d51471e7e63d20ee059a5c26251220b7 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Fri, 21 Jan 2022 17:40:57 -0500
Subject: [PATCH] EUDC: Fix a quoting bug in the BBDB backend

* lisp/net/eudcb-bbdb.el (eudc-bbdb-query-internal): Fix a quoting
bug introduced during lexical-binding conversion.
---
 lisp/net/eudcb-bbdb.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eudcb-bbdb.el b/lisp/net/eudcb-bbdb.el
index 60a3adbc34..e71dc238d0 100644
--- a/lisp/net/eudcb-bbdb.el
+++ b/lisp/net/eudcb-bbdb.el
@@ -233,7 +233,7 @@ eudc-bbdb-query-internal
       (setq bbdb-attrs (append bbdb-attrs (list (car query-attrs))))
       (if (car query-attrs)
 	  ;; BEWARE: `bbdb-search' is a macro!
-	  (setq records (eval `(bbdb-search records ,@bbdb-attrs) t)))
+	  (setq records (eval `(bbdb-search (quote ,records) ,@bbdb-attrs) t)))
       (setq query-attrs (cdr query-attrs)))
     (mapc (lambda (record)
             (setq filtered (eudc-filter-duplicate-attributes record))
-- 
2.33.1

bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable

[Eli Zaretskii]

> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> Date: Fri, 21 Jan 2022 18:08:13 -0500
> 
> I updated to the emacs-28 branch recently.  When I first tried to
> complete an e-mail address using eudc-expand-inline I saw this error:
> 
>     Symbol's value as variable is void: records
> 
> It turned out to be a quoting issue in eudc-bbdb-query-internal in the
> EUDC BBDB backend.  It looks like this was introduced by the change to
> lexical-binding.  The attached patch fixes the issue (though, the
> quoting that works now is different from what was there before the
> lexical-binding change).
> 
> Does it look OK to push to emacs-28?

Yes, thanks.

bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable

[Thomas Fitzsimmons]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
>> Date: Fri, 21 Jan 2022 18:08:13 -0500
>> 
>> I updated to the emacs-28 branch recently.  When I first tried to
>> complete an e-mail address using eudc-expand-inline I saw this error:
>> 
>>     Symbol's value as variable is void: records
>> 
>> It turned out to be a quoting issue in eudc-bbdb-query-internal in the
>> EUDC BBDB backend.  It looks like this was introduced by the change to
>> lexical-binding.  The attached patch fixes the issue (though, the
>> quoting that works now is different from what was there before the
>> lexical-binding change).
>> 
>> Does it look OK to push to emacs-28?
>
> Yes, thanks.

Done, thanks.

Thomas