From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable Date: Fri, 21 Jan 2022 18:08:13 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26510"; mail-complaints-to="usenet@ciao.gmane.io" To: 53430@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 22 00:09:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nB32M-0006dC-UC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jan 2022 00:09:43 +0100 Original-Received: from localhost ([::1]:39790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nB32L-0004AU-2Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 18:09:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nB31s-00049q-Ok for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 18:09:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nB31i-0003ZZ-Cn for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 18:09:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nB31i-0001aY-7L for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 18:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 23:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53430 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16428065136062 (code B ref -1); Fri, 21 Jan 2022 23:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jan 2022 23:08:33 +0000 Original-Received: from localhost ([127.0.0.1]:35306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB31F-0001Zh-E4 for submit@debbugs.gnu.org; Fri, 21 Jan 2022 18:08:33 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB31B-0001ZV-1m for submit@debbugs.gnu.org; Fri, 21 Jan 2022 18:08:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nB31A-00047G-T1 for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 18:08:28 -0500 Original-Received: from [2607:f8b0:4864:20::831] (port=43651 helo=mail-qt1-x831.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nB30z-0003Wa-Tp for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 18:08:20 -0500 Original-Received: by mail-qt1-x831.google.com with SMTP id m9so7939995qtq.10 for ; Fri, 21 Jan 2022 15:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=6f8jSiLUsgB6qNSoB70ud/2ZUiTBzZ2kb4Of2kHGPW0=; b=WHdCwxFjr3vJpGgYZzDts5h3c+0ktMjWMMsvFLoKM7cD7Xxr6EadZAxb5TLQEkFEZD z8X2kc6VECMiftuP2et+8XsP67NY2LFzdFV86PD13tfdSFUfdoER9slH53lohD/uVz8t RgVlx+UZ9NmZ1M0URke2zNpKxpeARGWajfSjWIoRgFOWxnLzwbe9WrTiWp7RVM9MfH7E RGB5SkXur09121ItaVJ3wvSMzLBFluc7t2bj25IDqtrLaCcv9bA26rj9GY/B4aK3JqQ8 XcsDohFhDKwROl9Ei85WQr8xqcy45D9fJ+aNpDr2IBGBR87xb5oULyZ5xXI0M3noR6ZO RTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=6f8jSiLUsgB6qNSoB70ud/2ZUiTBzZ2kb4Of2kHGPW0=; b=yUhJSPE4MnY6FgMizDtC5h407qfnyIshfjNyoJ/e/rQGCF32FS+obyewl40528vKgV ERhpc4c44QnsrE5y0xNENkh4JCKsbJefPySB/8G2Kn/rGwzulP717vZNLDXibouycd+K CgcwORJ1iDrvltEEO9k1ba7vbgv303wGtMqO7PGVzZz30H61/lx+x3n6/vJTK1V5mbDv sVP116/IkGsLR+aLm+2beE72C5HhkWZG2nstYWAjVg2j6ikG7JW78RHzkrSmYI37rCGO vFUluxbHpynNE+rWjCnFsG+zs4yxpO1t90XHrcc2goqbX/O+WQMoYQoO8j/yuY4M+/CR 4T7Q== X-Gm-Message-State: AOAM533pZrAd4Gyxbq5nMMVhZmuFIjeZNc50jQ0Fep5WXA/LK+WQOsIf PKQFTGFzifO+ANrSYJ/8mm9uhWb6d8iF4w== X-Google-Smtp-Source: ABdhPJz/NrjqFx5/MGVFMPpP4CxSBPMZJeq3edr0qxsnJVJN9hiSzAUa+42HQSjp4iPVisEuMHgIaA== X-Received: by 2002:ac8:5b96:: with SMTP id a22mr5202812qta.38.1642806495346; Fri, 21 Jan 2022 15:08:15 -0800 (PST) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id l1sm3769002qkp.100.2022.01.21.15.08.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jan 2022 15:08:14 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::831 (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::831; envelope-from=fitzsim@fitzsim.org; helo=mail-qt1-x831.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224795 Archived-At: --=-=-= Content-Type: text/plain Hi, I updated to the emacs-28 branch recently. When I first tried to complete an e-mail address using eudc-expand-inline I saw this error: Symbol's value as variable is void: records It turned out to be a quoting issue in eudc-bbdb-query-internal in the EUDC BBDB backend. It looks like this was introduced by the change to lexical-binding. The attached patch fixes the issue (though, the quoting that works now is different from what was there before the lexical-binding change). Does it look OK to push to emacs-28? Thanks, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-EUDC-Fix-a-quoting-bug-in-the-BBDB-backend.patch >From e58ecd01d51471e7e63d20ee059a5c26251220b7 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 21 Jan 2022 17:40:57 -0500 Subject: [PATCH] EUDC: Fix a quoting bug in the BBDB backend * lisp/net/eudcb-bbdb.el (eudc-bbdb-query-internal): Fix a quoting bug introduced during lexical-binding conversion. --- lisp/net/eudcb-bbdb.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eudcb-bbdb.el b/lisp/net/eudcb-bbdb.el index 60a3adbc34..e71dc238d0 100644 --- a/lisp/net/eudcb-bbdb.el +++ b/lisp/net/eudcb-bbdb.el @@ -233,7 +233,7 @@ eudc-bbdb-query-internal (setq bbdb-attrs (append bbdb-attrs (list (car query-attrs)))) (if (car query-attrs) ;; BEWARE: `bbdb-search' is a macro! - (setq records (eval `(bbdb-search records ,@bbdb-attrs) t))) + (setq records (eval `(bbdb-search (quote ,records) ,@bbdb-attrs) t))) (setq query-attrs (cdr query-attrs))) (mapc (lambda (record) (setq filtered (eudc-filter-duplicate-attributes record)) -- 2.33.1 --=-=-=--