From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: 53430@debbugs.gnu.org
Subject: bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable
Date: Fri, 21 Jan 2022 18:08:13 -0500 [thread overview]
Message-ID: <m3sftghele.fsf@fitzsim.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi,
I updated to the emacs-28 branch recently. When I first tried to
complete an e-mail address using eudc-expand-inline I saw this error:
Symbol's value as variable is void: records
It turned out to be a quoting issue in eudc-bbdb-query-internal in the
EUDC BBDB backend. It looks like this was introduced by the change to
lexical-binding. The attached patch fixes the issue (though, the
quoting that works now is different from what was there before the
lexical-binding change).
Does it look OK to push to emacs-28?
Thanks,
Thomas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-EUDC-Fix-a-quoting-bug-in-the-BBDB-backend.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]
From e58ecd01d51471e7e63d20ee059a5c26251220b7 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Fri, 21 Jan 2022 17:40:57 -0500
Subject: [PATCH] EUDC: Fix a quoting bug in the BBDB backend
* lisp/net/eudcb-bbdb.el (eudc-bbdb-query-internal): Fix a quoting
bug introduced during lexical-binding conversion.
---
lisp/net/eudcb-bbdb.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/eudcb-bbdb.el b/lisp/net/eudcb-bbdb.el
index 60a3adbc34..e71dc238d0 100644
--- a/lisp/net/eudcb-bbdb.el
+++ b/lisp/net/eudcb-bbdb.el
@@ -233,7 +233,7 @@ eudc-bbdb-query-internal
(setq bbdb-attrs (append bbdb-attrs (list (car query-attrs))))
(if (car query-attrs)
;; BEWARE: `bbdb-search' is a macro!
- (setq records (eval `(bbdb-search records ,@bbdb-attrs) t)))
+ (setq records (eval `(bbdb-search (quote ,records) ,@bbdb-attrs) t)))
(setq query-attrs (cdr query-attrs)))
(mapc (lambda (record)
(setq filtered (eudc-filter-duplicate-attributes record))
--
2.33.1
next reply other threads:[~2022-01-21 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 23:08 Thomas Fitzsimmons [this message]
2022-01-22 6:35 ` bug#53430: 28.0.91; eudc-expand-inline fails in BBDB backend with void records variable Eli Zaretskii
2022-01-22 15:04 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sftghele.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=53430@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).