bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Jambunathan K]

Debugger entered--Lisp error: (void-function make-local-hook)
  make-local-hook(kill-buffer-hook)
  dictionary-mode()
  dictionary()
  dictionary-ensure-buffer()
  dictionary-new-search((nil . "!"))
  dictionary-lookup-definition()
  call-interactively(dictionary-lookup-definition t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

Library is file ~/elisp/dictionary-1.8.7/dictionary.elc

I understand that this is a third party library and possibly no longer
maintained. (See http://me.in-berlin.de/~myrkr/dictionary/download.html)

I see the following reference to `make-local-hook' in NEWS but it
doesn't help much.  

,---- C-h n
| * Incompatible Lisp Changes in Emacs 24.
| make-local-hook (not needed),
`----

Any workaround I can put locally in dictionary?



In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Glenn Morris]

Jambunathan K wrote:

> Any workaround I can put locally in dictionary?

Delete any calls to make-local-hook. They are... not needed.
They do nothing (since Emacs 21.1).

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Hi Jambunathan,

Jambunathan K <kjambunathan@gmail.com> writes:

> Debugger entered--Lisp error: (void-function make-local-hook)
>   make-local-hook(kill-buffer-hook)
>   dictionary-mode()
>   dictionary()
>   dictionary-ensure-buffer()
>   dictionary-new-search((nil . "!"))
>   dictionary-lookup-definition()
>   call-interactively(dictionary-lookup-definition t nil)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command nil nil)
>
> Library is file ~/elisp/dictionary-1.8.7/dictionary.elc
>
> I understand that this is a third party library and possibly no longer
> maintained. (See http://me.in-berlin.de/~myrkr/dictionary/download.html)
>
> I see the following reference to `make-local-hook' in NEWS but it
> doesn't help much.  
>
> ,---- C-h n
> | * Incompatible Lisp Changes in Emacs 24.
> | make-local-hook (not needed),
> `----
>
> Any workaround I can put locally in dictionary?

You can use this:

(defalias 'make-local-hook
  (if (featurep 'xemacs)
      'make-local-hook
    'ignore))

Perhaps this should be added to Emacs, I've seen another
packages that break only because of this.

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Glenn Morris <rgm@gnu.org> writes:

> Jambunathan K wrote:
>
>> Any workaround I can put locally in dictionary?
>
> Delete any calls to make-local-hook. They are... not needed.
> They do nothing (since Emacs 21.1).

Comment to my previous message in this thread:

(defalias 'make-local-hook
  (if (featurep 'xemacs)
      'make-local-hook
    'ignore))

is actually the same function that `gnus-make-local-hook'. 

Adding the defalias above is a more generalized backward-compatibility
fix that other packages than Gnus would be aware of.  Should we add it
to Emacs?

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Jambunathan K]

Glenn Morris <rgm@gnu.org> writes:

> Jambunathan K wrote:
>
>> Any workaround I can put locally in dictionary?
>
> Delete any calls to make-local-hook. They are... not needed.
> They do nothing (since Emacs 21.1).

Ahhh, the comment is too succinct and I got confused.

For the sake of record, I have done this.

  (defalias 'make-local-hook 'ignore)

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Leo]

On 2012-03-28 04:02 +0800, Bastien wrote:
> Adding the defalias above is a more generalized backward-compatibility
> fix that other packages than Gnus would be aware of.  Should we add it
> to Emacs?

Why add it back? I think we should let those packages do it in their own
name space.

Leo

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Leo <sdl.web@gmail.com> writes:

> On 2012-03-28 04:02 +0800, Bastien wrote:
>> Adding the defalias above is a more generalized backward-compatibility
>> fix that other packages than Gnus would be aware of.  Should we add it
>> to Emacs?
>
> Why add it back? I think we should let those packages do it in their own
> name space.

When it's for XEmacs compatibility I agree.

But this single line

  (defalias 'make-local-hook 'ignore)

if added to Emacs, would be of great help for users who don't 
know what's wrong.

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Andreas Schwab]

Bastien <bzg@altern.org> writes:

> But this single line
>
>   (defalias 'make-local-hook 'ignore)

This is wrong.  It should be identity instead.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Bastien <bzg@altern.org> writes:
>
>> But this single line
>>
>>   (defalias 'make-local-hook 'ignore)
>
> This is wrong.  It should be identity instead.

Why?

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Leo]

On 2012-03-28 18:29 +0800, Bastien wrote:
> When it's for XEmacs compatibility I agree.
> 
> But this single line
>
>   (defalias 'make-local-hook 'ignore)
>
> if added to Emacs, would be of great help for users who don't 
> know what's wrong.

,----
| This function is obsolete since 21.1; not necessary any more.
`----

It was removed for some time now and some code might be dependent on its
removal already. So add it back is not an option.

(unless (fboundp 'make-local-hook)
   .....)

Leo

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Leo]

On 2012-03-28 19:30 +0800, Bastien wrote:
> Why?

Check the documentation on the return value.

Leo

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Drew Adams]

> Why add it back? I think we should let those packages do it 
> in their own name space.

It seems to be part of GNU Emacs already, albeit in Gnusland.
And maybe soon in Orgland as well?

Or are you suggesting that Gnus (& Org...) be removed
from Emacs?  Relegated to Elpagatory perhaps?  ;-)
(Sure, why not?)

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

"Drew Adams" <drew.adams@oracle.com> writes:

>> Why add it back? I think we should let those packages do it 
>> in their own name space.
>
> It seems to be part of GNU Emacs already, albeit in Gnusland.
> And maybe soon in Orgland as well?

And Gnus defines it using 'ignore.  

I've check the docstrings of 'ignore and 'identity and I still
don't understand why 'identity should be used instead of 'ignore
(as Gnus does).

Any useful hint?

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Leo]

......
This function is obsolete since 21.1;
not necessary any more.

Make the hook HOOK local to the current buffer.
The return value is HOOK.
                    ^
                    +----- see?

Leo

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Leo <sdl.web@gmail.com> writes:

> ......
> This function is obsolete since 21.1;
> not necessary any more.
>
> Make the hook HOOK local to the current buffer.
> The return value is HOOK.
>                     ^
>                     +----- see?

No, I don't see.  Can you be more explicit?

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Andreas Schwab]

Bastien <bzg@altern.org> writes:

> And Gnus defines it using 'ignore.  

It doesn't.  It defines gnus-make-local-hook.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Bastien <bzg@altern.org> writes:
>
>> And Gnus defines it using 'ignore.  
>
> It doesn't.  It defines gnus-make-local-hook.

This is in gnus-utils.el:

;; The LOCAL arg to `add-hook' is interpreted differently in Emacs and
;; XEmacs.  In Emacs we don't need to call `make-local-hook' first.
;; It's harmless, though, so the main purpose of this alias is to shut
;; up the byte compiler.
(defalias 'gnus-make-local-hook (if (featurep 'xemacs)
                                    'make-local-hook
                                  'ignore))

IIUC, you think it should be

(defalias 'gnus-make-local-hook (if (featurep 'xemacs)
                                    'make-local-hook
                                  'identity))

right?

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Andreas Schwab]

Bastien <bzg@altern.org> writes:

> IIUC, you think it should be
>
> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>                                     'make-local-hook
>                                   'identity))
>
> right?

No.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Bastien <bzg@altern.org> writes:
>
>> IIUC, you think it should be
>>
>> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>>                                     'make-local-hook
>>                                   'identity))
>>
>> right?
>
> No.

You said:

>>   (defalias 'make-local-hook 'ignore)
>
>This is wrong.  It should be identity instead.

So you are suggesting 

(defalias 'make-local-hook 'ignore)

should be

(defalias 'make-local-hook 'identity)

instead.

Am I right?

-- 
 Bastien, trying to communicate with a sphinx

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Lennart Borgman]

On Wed, Mar 28, 2012 at 17:24, Bastien <bzg@altern.org> wrote:
> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> Bastien <bzg@altern.org> writes:
>>
>>> IIUC, you think it should be
>>>
>>> (defalias 'gnus-make-local-hook (if (featurep 'xemacs)
>>>                                     'make-local-hook
>>>                                   'identity))
>>>
>>> right?
>>
>> No.

:-)  -- This kind of humourness is hard on the internet. I am glad
when it is seen as humour.

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Lennart Borgman <lennart.borgman@gmail.com> writes:

> :-)  -- This kind of humourness is hard on the internet. I am glad
> when it is seen as humour.

I see it as such.  But I still don't understand why we should use 

(defalias 'make-local-hook 'identity)

instead of 

(defalias 'make-local-hook 'ignore)

Life is full of mysteries, that's alright.

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Lennart Borgman]

On Wed, Mar 28, 2012 at 23:59, Bastien <bzg@altern.org> wrote:
> Lennart Borgman <lennart.borgman@gmail.com> writes:
>
>> :-)  -- This kind of humourness is hard on the internet. I am glad
>> when it is seen as humour.
>
> I see it as such.  But I still don't understand why we should use
>
> (defalias 'make-local-hook 'identity)
>
> instead of
>
> (defalias 'make-local-hook 'ignore)
>
> Life is full of mysteries, that's alright.

Just to be backward compatible, or?

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Lennart Borgman <lennart.borgman@gmail.com> writes:

> On Wed, Mar 28, 2012 at 23:59, Bastien <bzg@altern.org> wrote:
>> Lennart Borgman <lennart.borgman@gmail.com> writes:
>>
>>> :-)  -- This kind of humourness is hard on the internet. I am glad
>>> when it is seen as humour.
>>
>> I see it as such.  But I still don't understand why we should use
>>
>> (defalias 'make-local-hook 'identity)
>>
>> instead of
>>
>> (defalias 'make-local-hook 'ignore)
>>
>> Life is full of mysteries, that's alright.
>
> Just to be backward compatible, or?

Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
backward-compatibility function.  The Sphinx said we should use
'identity for the defalias.  So I'm a bit loss.  But that's okay,
I can live with it.

-- 
 Bastien

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Stefan Monnier]

> Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
> backward-compatibility function.  The Sphinx said we should use
> 'identity for the defalias.  So I'm a bit loss.  But that's okay,
> I can live with it.

To be backward compatible, a redefinition of make-local-hook should use
`identity' so as to return the same value as the old definition did.
For gnus-make-local-hook that's not necessary because Gnus's code
doesn't use the return value of make-local-hook.


        Stefan

bug#11104: 24.0.94; (void-function make-local-hook): Update NEWS maybe?

[Bastien]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Yes.  The `gnus-make-local-hook' uses the 'ignore function for its
>> backward-compatibility function.  The Sphinx said we should use
>> 'identity for the defalias.  So I'm a bit loss.  But that's okay,
>> I can live with it.
>
> To be backward compatible, a redefinition of make-local-hook should use
> `identity' so as to return the same value as the old definition did.
> For gnus-make-local-hook that's not necessary because Gnus's code
> doesn't use the return value of make-local-hook.

Got it, thanks.

-- 
 Bastien