From: Lennart Borgman <lennart.borgman@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 5863@debbugs.gnu.org
Subject: bug#5863: defadvice in byte compiled file does not work
Date: Fri, 9 Apr 2010 02:19:27 +0200 [thread overview]
Message-ID: <l2xe01d8a51004081719k76a157e8s4b941227adf56c0e@mail.gmail.com> (raw)
In-Reply-To: <x2je01d8a51004081613t45a74308y9eb3fb94ca1746b4@mail.gmail.com>
On Fri, Apr 9, 2010 at 1:13 AM, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> On Thu, Apr 8, 2010 at 11:52 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Lennart Borgman <lennart.borgman@gmail.com> writes:
>>
>>> On Thu, Apr 8, 2010 at 7:04 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>> Lennart Borgman <lennart.borgman@gmail.com> writes:
>>>>
>>>>> The info page I pointed to says that defadvice should work for
>>>>> primitives called from lisp code.
>>>>
>>>> The primitive is no longer called from lisp code when byte compiled.
>>>
>>>
>>> I think that is wrong. Can you point me to something that support your
>>> statement?
>>
>> See Fbyte_code.
>
>
> Hm, thanks, yes I can see how it is implemented now and I can see good
> reasons for optimizing it this way. However the manual does not say
> that byte compilation removes the check during execution if primitives
> are adviced or not.
>
> And I am a bit irritated that it doesn't since I trusted the manual.... ;-)
>
> Could we please correct the manual?
>
> And could we as soon as possible please remove the possibility to
> defadvice primitives at all? The kind of bugs produced by different
> execution paths for evaled and byte compiled code is rather difficult
> to nail down.
>
>
> (I have to do a totally different workaround instead of defadvice
> widen. But that is another problem.)
I have done a new workaround. This depends on the bug that primitives
can be defadviced in evaled code. So please do not correct the bug
without giving any possibility to avoid (widen).... ;-)
next prev parent reply other threads:[~2010-04-09 0:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 15:26 bug#5863: defadvice in byte compiled file does not work Lennart Borgman
2010-04-08 15:50 ` Andreas Schwab
2010-04-08 15:57 ` Lennart Borgman
2010-04-08 16:06 ` Andreas Schwab
2010-04-08 16:22 ` Lennart Borgman
2010-04-08 16:55 ` Andreas Schwab
2010-04-08 16:56 ` Lennart Borgman
2010-04-08 17:04 ` Andreas Schwab
2010-04-08 17:06 ` Lennart Borgman
2010-04-08 18:22 ` Lennart Borgman
2010-04-08 21:52 ` Andreas Schwab
2010-04-08 23:13 ` Lennart Borgman
2010-04-09 0:19 ` Lennart Borgman [this message]
2010-04-09 2:06 ` Stefan Monnier
2010-04-09 3:37 ` Drew Adams
2020-11-19 3:23 ` Stefan Kangas
2020-11-19 5:20 ` Stefan Monnier
2020-11-19 8:14 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-20 5:07 ` Stefan Kangas
2020-11-27 11:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2xe01d8a51004081719k76a157e8s4b941227adf56c0e@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=5863@debbugs.gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).