From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#5863: defadvice in byte compiled file does not work Date: Fri, 9 Apr 2010 02:19:27 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1270773127 26006 80.91.229.12 (9 Apr 2010 00:32:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 9 Apr 2010 00:32:07 +0000 (UTC) Cc: 5863@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 09 02:31:55 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O028Z-0002FL-7R for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Apr 2010 02:31:55 +0200 Original-Received: from localhost ([127.0.0.1]:54826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O028Y-0001qz-OG for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Apr 2010 20:31:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O028T-0001qR-44 for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:31:49 -0400 Original-Received: from [140.186.70.92] (port=39678 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O028R-0001q6-HR for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:31:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O028P-0007GB-VL for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:31:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33921) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O028P-0007G4-Su for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2010 20:31:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O01x5-0000lM-1y; Thu, 08 Apr 2010 20:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Apr 2010 00:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5863-submit@debbugs.gnu.org id=B5863.12707723942923 (code B ref 5863); Fri, 09 Apr 2010 00:20:03 +0000 Original-Received: (at 5863) by debbugs.gnu.org; 9 Apr 2010 00:19:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O01wv-0000l6-Rz for submit@debbugs.gnu.org; Thu, 08 Apr 2010 20:19:54 -0400 Original-Received: from mail-fx0-f219.google.com ([209.85.220.219]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O01wt-0000l1-Mk for 5863@debbugs.gnu.org; Thu, 08 Apr 2010 20:19:52 -0400 Original-Received: by fxm19 with SMTP id 19so24175fxm.39 for <5863@debbugs.gnu.org>; Thu, 08 Apr 2010 17:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:received:message-id:subject:to:cc:content-type; bh=7FvaQA4ZX09+I8v1LcDnPfYuUBSJzmC6EHNDPYOJCP8=; b=sCYWs4zTpF9aIs5UZozPmcdFfWS/CeZa9PlQMkkl57LS/Vs59Mp+V3TlrUCO3YRSHy 69V9M4PESlgqL28j2oly0rvcoRjUV+QhPoZIwNUK7e75Dyx2EM8aHzIGB3fLfTHa2U7d FuBLOnIPsNuvnIF1q5P1RsaX4MlIlD+0KEApk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=fwA1hQfh01m5rSySl1AFUgLqdTCG6afiyzWYhKNjf34GtTUR39H1nGABIuWUOZOA3h dHcR9OUBaigEVWFYXT1oouCHr1mLHIgIvNzEs00l9PnUDylV86SpHS57lkpPyi2SxYQp HAImR5ramcP819eCVcy2gHQq7RKYtwO3UV5cw= Original-Received: by 10.239.169.18 with HTTP; Thu, 8 Apr 2010 17:19:27 -0700 (PDT) In-Reply-To: Original-Received: by 10.239.166.10 with SMTP id z10mr89499hbd.80.1270772387116; Thu, 08 Apr 2010 17:19:47 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 08 Apr 2010 20:20:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36106 Archived-At: On Fri, Apr 9, 2010 at 1:13 AM, Lennart Borgman wrote: > On Thu, Apr 8, 2010 at 11:52 PM, Andreas Schwab wrote: >> Lennart Borgman writes: >> >>> On Thu, Apr 8, 2010 at 7:04 PM, Andreas Schwab wrote: >>>> Lennart Borgman writes: >>>> >>>>> The info page I pointed to says that defadvice should work for >>>>> primitives called from lisp code. >>>> >>>> The primitive is no longer called from lisp code when byte compiled. >>> >>> >>> I think that is wrong. Can you point me to something that support your >>> statement? >> >> See Fbyte_code. > > > Hm, thanks, yes I can see how it is implemented now and I can see good > reasons for optimizing it this way. However the manual does not say > that byte compilation removes the check during execution if primitives > are adviced or not. > > And I am a bit irritated that it doesn't since I trusted the manual.... ;-) > > Could we please correct the manual? > > And could we as soon as possible please remove the possibility to > defadvice primitives at all? The kind of bugs produced by different > execution paths for evaled and byte compiled code is rather difficult > to nail down. > > > (I have to do a totally different workaround instead of defadvice > widen. But that is another problem.) I have done a new workaround. This depends on the bug that primitives can be defadviced in evaled code. So please do not correct the bug without giving any possibility to avoid (widen).... ;-)