unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: 5863@debbugs.gnu.org
Subject: bug#5863: defadvice in byte compiled file does not work
Date: Thu, 8 Apr 2010 17:26:26 +0200	[thread overview]
Message-ID: <t2pe01d8a51004080826qf3074b32y563c201cb4b627c2@mail.gmail.com> (raw)

I have this in mumamo.el:

  (defvar mumamo-stop-widen nil)
  (defadvice widen (around
                    mumamo-ad-widen
                    activate
                    compile)
    (unless (and mumamo-multi-major-mode
                 mumamo-stop-widen)
      ad-do-it))

I let bind mumamo-stop-widen to avoid widening for certain situations.
This works sometimes and not other times. It looks like the defadvice
is simply skipped the other times (but I am not sure).

It looks like it depends on byte compilation in some way. Or actually
several ways. I have seen instances where it helps to eval the
defadvice and other cases where it does not. If the function calling
(widen) is byte compiled it does not work, but it works if the
function is evaled. However it looks like both these conditions must
be meat.

Beeing able to do something like this is very essential to get multi
major modes working reliably. Is there any remedy for this problem?

If not, could we please add a way to control if (widen) widens the
buffer (or how it does it, but that seems to complicated to me)?







             reply	other threads:[~2010-04-08 15:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 15:26 Lennart Borgman [this message]
2010-04-08 15:50 ` bug#5863: defadvice in byte compiled file does not work Andreas Schwab
2010-04-08 15:57   ` Lennart Borgman
2010-04-08 16:06     ` Andreas Schwab
2010-04-08 16:22       ` Lennart Borgman
2010-04-08 16:55         ` Andreas Schwab
2010-04-08 16:56           ` Lennart Borgman
2010-04-08 17:04             ` Andreas Schwab
2010-04-08 17:06               ` Lennart Borgman
2010-04-08 18:22                 ` Lennart Borgman
2010-04-08 21:52                 ` Andreas Schwab
2010-04-08 23:13                   ` Lennart Borgman
2010-04-09  0:19                     ` Lennart Borgman
2010-04-09  2:06             ` Stefan Monnier
2010-04-09  3:37               ` Drew Adams
2020-11-19  3:23               ` Stefan Kangas
2020-11-19  5:20                 ` Stefan Monnier
2020-11-19  8:14                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-20  5:07                     ` Stefan Kangas
2020-11-27 11:45                       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=t2pe01d8a51004080826qf3074b32y563c201cb4b627c2@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=5863@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).