unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 5863@debbugs.gnu.org
Subject: bug#5863: defadvice in byte compiled file does not work
Date: Thu, 8 Apr 2010 17:57:17 +0200	[thread overview]
Message-ID: <m2ie01d8a51004080857wbcf322f7h2dab7811eff01997@mail.gmail.com> (raw)
In-Reply-To: <m3pr2alz9p.fsf@hase.home>

On Thu, Apr 8, 2010 at 5:50 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Lennart Borgman <lennart.borgman@gmail.com> writes:
>
>> It looks like the defadvice is simply skipped the other times (but I
>> am not sure).
>
> widen has its own byte code.  Advices also never work on direct calls to
> builtin functions.


Thanks Andreas, but what does it mean that it has its own byte code?
Why is it important here?

Reading (info "(elisp) Advising Primitives") it looks to me that it
should work in those cases I want it to work since the calls to
"(widen)" I want to intercept are in elisp code. That info page says

  "Calls to the primitive from Lisp code
    will take note of the advice."

It looks to me like a regression, but I am not quite sure. I am just
trying to find out but it takes me some minutes.






  reply	other threads:[~2010-04-08 15:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 15:26 bug#5863: defadvice in byte compiled file does not work Lennart Borgman
2010-04-08 15:50 ` Andreas Schwab
2010-04-08 15:57   ` Lennart Borgman [this message]
2010-04-08 16:06     ` Andreas Schwab
2010-04-08 16:22       ` Lennart Borgman
2010-04-08 16:55         ` Andreas Schwab
2010-04-08 16:56           ` Lennart Borgman
2010-04-08 17:04             ` Andreas Schwab
2010-04-08 17:06               ` Lennart Borgman
2010-04-08 18:22                 ` Lennart Borgman
2010-04-08 21:52                 ` Andreas Schwab
2010-04-08 23:13                   ` Lennart Borgman
2010-04-09  0:19                     ` Lennart Borgman
2010-04-09  2:06             ` Stefan Monnier
2010-04-09  3:37               ` Drew Adams
2020-11-19  3:23               ` Stefan Kangas
2020-11-19  5:20                 ` Stefan Monnier
2020-11-19  8:14                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-20  5:07                     ` Stefan Kangas
2020-11-27 11:45                       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ie01d8a51004080857wbcf322f7h2dab7811eff01997@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=5863@debbugs.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).