bug#4740: 23.1; two error re-signals

bug#4740: 23.1; two error re-signals

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Below is untested.  Of course never-executed code isn't worth the bits
its written in, but I've got no idea how to reach either spot.  I see
other similar things doing signal instead of apply -- is that right?

2009-10-16  Kevin Ryde  <user42@zip.com.au>

	* ibuffer.el (ibuffer-confirm-operation-on),
	cedet/semantic/wisent.el (wisent-parse-stream):
	Fix error re-signal, err is a pair not a list so can't use `apply'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ibuffer.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 422 bytes --]

--- ibuffer.el.~1.117.~	2009-10-02 10:23:54.000000000 +1000
+++ ibuffer.el	2009-10-17 10:10:46.000000000 +1100
@@ -1191,7 +1191,7 @@
 				  ;; This definitely falls in the
 				  ;; ghetto hack category...
 				  (not (string-match "too small" (cadr err)))))
-			 (apply #'signal err)
+			 (signal (car err) (cdr err))
 		       (enlarge-window 3))))))
 	      (select-window (next-window))
 	      (switch-to-buffer buf)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: wisent.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 561 bytes --]

--- wisent.el.~1.5.~	2009-10-08 11:00:26.000000000 +1100
+++ wisent.el	2009-10-16 11:27:58.000000000 +1100
@@ -232,7 +232,7 @@
                                     (error-message-string error-to-filter))
                            (message "wisent-parse-max-stack-size \
 might need to be increased"))
-                       (apply 'signal error-to-filter))))))
+                       (signal (car error-to-filter) (cdr error-to-filter)))))))
     ;; Manage returned lookahead token
     (if wisent-lookahead
         (if (eq (caar la-elt) wisent-lookahead)

[-- Attachment #4: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

bug#4740: 23.1; two error re-signals

[Stefan Monnier]

> Below is untested.  Of course never-executed code isn't worth the bits
> its written in, but I've got no idea how to reach either spot.  I see
> other similar things doing signal instead of apply -- is that right?

That looks right, yes, thanks,


        Stefan

bug#4740: marked as done (23.1; two error re-signals)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Your message dated Mon, 19 Oct 2009 10:14:30 +1100
with message-id <878wf8mh0p.fsf@blah.blah>
and subject line Re: bug#4740: 23.1; two error re-signals
has caused the Emacs bug report #4740,
regarding 23.1; two error re-signals
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4740: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4740
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4721 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 421 bytes --]

Below is untested.  Of course never-executed code isn't worth the bits
its written in, but I've got no idea how to reach either spot.  I see
other similar things doing signal instead of apply -- is that right?

2009-10-16  Kevin Ryde  <user42@zip.com.au>

	* ibuffer.el (ibuffer-confirm-operation-on),
	cedet/semantic/wisent.el (wisent-parse-stream):
	Fix error re-signal, err is a pair not a list so can't use `apply'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: ibuffer.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 422 bytes --]

--- ibuffer.el.~1.117.~	2009-10-02 10:23:54.000000000 +1000
+++ ibuffer.el	2009-10-17 10:10:46.000000000 +1100
@@ -1191,7 +1191,7 @@
 				  ;; This definitely falls in the
 				  ;; ghetto hack category...
 				  (not (string-match "too small" (cadr err)))))
-			 (apply #'signal err)
+			 (signal (car err) (cdr err))
 		       (enlarge-window 3))))))
 	      (select-window (next-window))
 	      (switch-to-buffer buf)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.3: wisent.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 561 bytes --]

--- wisent.el.~1.5.~	2009-10-08 11:00:26.000000000 +1100
+++ wisent.el	2009-10-16 11:27:58.000000000 +1100
@@ -232,7 +232,7 @@
                                     (error-message-string error-to-filter))
                            (message "wisent-parse-max-stack-size \
 might need to be increased"))
-                       (apply 'signal error-to-filter))))))
+                       (signal (car error-to-filter) (cdr error-to-filter)))))))
     ;; Manage returned lookahead token
     (if wisent-lookahead
         (if (eq (caar la-elt) wisent-lookahead)

[-- Attachment #2.1.4: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

[-- Attachment #3: Type: message/rfc822, Size: 1914 bytes --]

From: Kevin Ryde <user42@zip.com.au>
To: 4740-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4740: 23.1; two error re-signals
Date: Mon, 19 Oct 2009 10:14:30 +1100
Message-ID: <878wf8mh0p.fsf@blah.blah>

I checked in the ibuffer and will send some mails for the cedet/wisent
one.