From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.emacs.bugs Subject: bug#4740: 23.1; two error re-signals Date: Sat, 17 Oct 2009 10:18:19 +1100 Message-ID: <87r5t3rkqs.fsf@blah.blah> Reply-To: Kevin Ryde , 4740@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1255735668 25119 80.91.229.12 (16 Oct 2009 23:27:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Oct 2009 23:27:48 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 17 01:27:38 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MywCu-0007pM-BA for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Oct 2009 01:27:36 +0200 Original-Received: from localhost ([127.0.0.1]:40301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MywCt-000346-HG for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Oct 2009 19:27:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MywCe-0002vw-4l for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:27:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MywCZ-0002uG-El for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:27:19 -0400 Original-Received: from [199.232.76.173] (port=59517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MywCZ-0002uA-6g for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:27:15 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34473) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MywCY-0007lg-G2 for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:27:15 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9GNRB5C030036; Fri, 16 Oct 2009 16:27:11 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9GNP6uP029578; Fri, 16 Oct 2009 16:25:06 -0700 Resent-Date: Fri, 16 Oct 2009 16:25:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Kevin Ryde Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 16 Oct 2009 23:25:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4740 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125573516128782 (code B ref -1); Fri, 16 Oct 2009 23:25:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 16 Oct 2009 23:19:21 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9GNJI88028779 for ; Fri, 16 Oct 2009 16:19:20 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myw4s-00085l-GE for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myw4o-00082v-J9 for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:18 -0400 Original-Received: from [199.232.76.173] (port=53408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myw4o-00082p-Ef for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:14 -0400 Original-Received: from mailout1-1.pacific.net.au ([61.8.2.208]:59194 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myw4n-0006hH-NW for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:14 -0400 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id 019A95080DA for ; Sat, 17 Oct 2009 10:19:09 +1100 (EST) Original-Received: from blah.blah (ppp2874.dyn.pacific.net.au [61.8.40.116]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 2354E8C0D for ; Sat, 17 Oct 2009 10:19:02 +1100 (EST) Original-Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1Myw3v-0002av-NE for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2009 10:18:19 +1100 User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 16 Oct 2009 19:27:19 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32016 Archived-At: --=-=-= Below is untested. Of course never-executed code isn't worth the bits its written in, but I've got no idea how to reach either spot. I see other similar things doing signal instead of apply -- is that right? 2009-10-16 Kevin Ryde * ibuffer.el (ibuffer-confirm-operation-on), cedet/semantic/wisent.el (wisent-parse-stream): Fix error re-signal, err is a pair not a list so can't use `apply'. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ibuffer.el.signal-error.diff --- ibuffer.el.~1.117.~ 2009-10-02 10:23:54.000000000 +1000 +++ ibuffer.el 2009-10-17 10:10:46.000000000 +1100 @@ -1191,7 +1191,7 @@ ;; This definitely falls in the ;; ghetto hack category... (not (string-match "too small" (cadr err))))) - (apply #'signal err) + (signal (car err) (cdr err)) (enlarge-window 3)))))) (select-window (next-window)) (switch-to-buffer buf) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=wisent.el.signal-error.diff --- wisent.el.~1.5.~ 2009-10-08 11:00:26.000000000 +1100 +++ wisent.el 2009-10-16 11:27:58.000000000 +1100 @@ -232,7 +232,7 @@ (error-message-string error-to-filter)) (message "wisent-parse-max-stack-size \ might need to be increased")) - (apply 'signal error-to-filter)))))) + (signal (car error-to-filter) (cdr error-to-filter))))))) ;; Manage returned lookahead token (if wisent-lookahead (if (eq (caar la-elt) wisent-lookahead) --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' --=-=-=--