From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4740: marked as done (23.1; two error re-signals) Date: Sun, 18 Oct 2009 23:20:05 +0000 Message-ID: References: <878wf8mh0p.fsf@blah.blah> <87r5t3rkqs.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1255908005-11855-0" X-Trace: ger.gmane.org 1255908458 24150 80.91.229.12 (18 Oct 2009 23:27:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2009 23:27:38 +0000 (UTC) To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 19 01:27:27 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mzf9r-0004OA-DI for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Oct 2009 01:27:27 +0200 Original-Received: from localhost ([127.0.0.1]:47882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mzf9q-0008HY-Ht for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Oct 2009 19:27:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mzf9j-0008Gf-3n for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2009 19:27:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mzf9e-0008Fj-MB for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2009 19:27:18 -0400 Original-Received: from [199.232.76.173] (port=53082 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mzf9e-0008Ff-JR for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2009 19:27:14 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43832) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mzf9d-0007aT-VJ for bug-gnu-emacs@gnu.org; Sun, 18 Oct 2009 19:27:14 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9INRCWU013102; Sun, 18 Oct 2009 16:27:12 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9INK5b8011913; Sun, 18 Oct 2009 16:20:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4740 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32078 Archived-At: This is a multi-part message in MIME format... ------------=_1255908005-11855-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 19 Oct 2009 10:14:30 +1100 with message-id <878wf8mh0p.fsf@blah.blah> and subject line Re: bug#4740: 23.1; two error re-signals has caused the Emacs bug report #4740, regarding 23.1; two error re-signals to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4740: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4740 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1255908005-11855-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 16 Oct 2009 23:19:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.9 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9GNJI88028779 for ; Fri, 16 Oct 2009 16:19:20 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myw4s-00085l-GE for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myw4o-00082v-J9 for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:18 -0400 Received: from [199.232.76.173] (port=53408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myw4o-00082p-Ef for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:14 -0400 Received: from mailout1-1.pacific.net.au ([61.8.2.208]:59194 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myw4n-0006hH-NW for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 19:19:14 -0400 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id 019A95080DA for ; Sat, 17 Oct 2009 10:19:09 +1100 (EST) Received: from blah.blah (ppp2874.dyn.pacific.net.au [61.8.40.116]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 2354E8C0D for ; Sat, 17 Oct 2009 10:19:02 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1Myw3v-0002av-NE for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2009 10:18:19 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; two error re-signals Date: Sat, 17 Oct 2009 10:18:19 +1100 Message-ID: <87r5t3rkqs.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= Below is untested. Of course never-executed code isn't worth the bits its written in, but I've got no idea how to reach either spot. I see other similar things doing signal instead of apply -- is that right? 2009-10-16 Kevin Ryde * ibuffer.el (ibuffer-confirm-operation-on), cedet/semantic/wisent.el (wisent-parse-stream): Fix error re-signal, err is a pair not a list so can't use `apply'. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ibuffer.el.signal-error.diff --- ibuffer.el.~1.117.~ 2009-10-02 10:23:54.000000000 +1000 +++ ibuffer.el 2009-10-17 10:10:46.000000000 +1100 @@ -1191,7 +1191,7 @@ ;; This definitely falls in the ;; ghetto hack category... (not (string-match "too small" (cadr err))))) - (apply #'signal err) + (signal (car err) (cdr err)) (enlarge-window 3)))))) (select-window (next-window)) (switch-to-buffer buf) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=wisent.el.signal-error.diff --- wisent.el.~1.5.~ 2009-10-08 11:00:26.000000000 +1100 +++ wisent.el 2009-10-16 11:27:58.000000000 +1100 @@ -232,7 +232,7 @@ (error-message-string error-to-filter)) (message "wisent-parse-max-stack-size \ might need to be increased")) - (apply 'signal error-to-filter)))))) + (signal (car error-to-filter) (cdr error-to-filter))))))) ;; Manage returned lookahead token (if wisent-lookahead (if (eq (caar la-elt) wisent-lookahead) --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' --=-=-=-- ------------=_1255908005-11855-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4740-done) by emacsbugs.donarmstrong.com; 18 Oct 2009 23:15:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailout1.pacific.net.au (mailout1-1.pacific.net.au [61.8.2.208]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9INFAFJ011396 for <4740-done@emacsbugs.donarmstrong.com>; Sun, 18 Oct 2009 16:15:11 -0700 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id B6313508327 for <4740-done@emacsbugs.donarmstrong.com>; Mon, 19 Oct 2009 10:15:07 +1100 (EST) Received: from blah.blah (ppp2B60.dyn.pacific.net.au [61.8.43.96]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 0641E2740F for <4740-done@emacsbugs.donarmstrong.com>; Mon, 19 Oct 2009 10:15:02 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1MzexK-0001T6-UV for 4740-done@emacsbugs.donarmstrong.com; Mon, 19 Oct 2009 10:14:31 +1100 From: Kevin Ryde To: 4740-done@emacsbugs.donarmstrong.com Subject: Re: bug#4740: 23.1; two error re-signals References: <87r5t3rkqs.fsf@blah.blah> Date: Mon, 19 Oct 2009 10:14:30 +1100 In-Reply-To: (Stefan Monnier's message of "Fri, 16 Oct 2009 22:18:19 -0400") Message-ID: <878wf8mh0p.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I checked in the ibuffer and will send some mails for the cedet/wisent one. ------------=_1255908005-11855-0--