From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: uyennhi.qm@gmail.com, 38796@debbugs.gnu.org
Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit
Date: Sun, 28 Jun 2020 14:00:33 -0400 [thread overview]
Message-ID: <jwvh7uvysye.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2006281850520.10052@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sun, 28 Jun 2020 18:55:09 +0200 (CEST)")
>> My personal view is that we should allow only growing the size and
>> resetting it to the original size of 300. Disabling the key record
>> should be a separate feature, most probably implemented by means other
>> than shrinking the recent_keys vector.
>
> I totally agree: they are clearly 2 separated features.
>
> Thanks for the comments, I will work on them and get back once
> completed and tested.
I agree that disabling should not necessarily be implemented by
"abusing" the max-lossage setting.
But I don't see any reason to impose a 300 minimum either. I think it's
fine to impose a minimum, but it should be dictated by the limits of the
code. I'm not saying we should work to push this lower limit down, but
just that it should reflect what the code can do safely rather than
being an arbitrary number like 300 (I'm pretty sure 100 would be safe as
well, since that's what we've used for many years).
Stefan
next prev parent reply other threads:[~2020-06-28 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 17:04 bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Drew Adams
2019-12-29 17:30 ` Eli Zaretskii
2019-12-29 17:34 ` Drew Adams
2020-06-26 21:58 ` Tino Calancha
2020-06-27 8:32 ` Eli Zaretskii
2020-06-28 16:55 ` Tino Calancha
2020-06-28 18:00 ` Stefan Monnier [this message]
2020-06-28 20:01 ` Drew Adams
2020-06-28 21:52 ` Tino Calancha
2020-06-29 0:05 ` Drew Adams
2020-08-22 21:24 ` Lars Ingebrigtsen
2020-08-22 22:54 ` Drew Adams
2020-08-27 21:28 ` Tino Calancha
2020-08-28 6:04 ` Eli Zaretskii
2020-09-04 9:31 ` Tino Calancha
2020-09-04 12:07 ` Eli Zaretskii
2020-09-12 12:29 ` Tino Calancha
2020-09-17 14:35 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh7uvysye.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=38796@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).