From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Date: Sun, 28 Jun 2020 14:00:33 -0400 Message-ID: References: <43aac56d-ecf1-44ed-9be1-ffb8e5f8a7ce@default> <83zhfbm448.fsf@gnu.org> <87zh8pij6e.fsf@calancha-pc.dy.bbexcite.jp> <83v9jc3o3q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: uyennhi.qm@gmail.com, 38796@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 28 20:01:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jpbc8-0007YY-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jun 2020 20:01:12 +0200 Original-Received: from localhost ([::1]:42442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpbc7-0006J5-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jun 2020 14:01:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpbby-0006Ik-JN for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2020 14:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpbby-0002k6-9N for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2020 14:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpbby-0001LT-4x for bug-gnu-emacs@gnu.org; Sun, 28 Jun 2020 14:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2020 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38796 X-GNU-PR-Package: emacs Original-Received: via spool by 38796-submit@debbugs.gnu.org id=B38796.15933672605157 (code B ref 38796); Sun, 28 Jun 2020 18:01:02 +0000 Original-Received: (at 38796) by debbugs.gnu.org; 28 Jun 2020 18:01:00 +0000 Original-Received: from localhost ([127.0.0.1]:46886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpbbw-0001L7-IZ for submit@debbugs.gnu.org; Sun, 28 Jun 2020 14:01:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpbbu-0001Ku-Bp for 38796@debbugs.gnu.org; Sun, 28 Jun 2020 14:00:59 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0156544093A; Sun, 28 Jun 2020 14:00:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8D7694402C1; Sun, 28 Jun 2020 14:00:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1593367247; bh=xnDWYoqNtyG8vmAUE+WRfH7I1pVYpYZ379qog+YRXX0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SilFY2zV1OMk8wQlU5TcABOZh+WmzIidDUe71hMMBSTB8coNNZVGILpQHFrYzac00 4AAP/MY5ymFNU83e8EUsQ25l07CgewS1RgJR47rfGQMcH4FFmwfub1D3XOVJMFLk6k TDdznVAsAOpg03vmWYVifA9HdSd4IGMZjSVnkLz2QNcUIPfCQ6F3Afc9xcx2OnvFs5 o0pjRTj3E50UrCMAeOybCT4d7+jsoyfNiSeqKjLM1WAQ0sGaX16x/w0ZoxJIDDwVP7 tVoAUEn9p2Uc1mQMQI+q5/A+cQVRYOFzAaR+4ICzwpEUMpS8yXSiH6OFdIKWVJN8a9 cNOPKvD1eoRBw== Original-Received: from ceviche (xplr-96-63-48-187.xplornet.com [96.63.48.187]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A0E471209C3; Sun, 28 Jun 2020 14:00:40 -0400 (EDT) In-Reply-To: (Tino Calancha's message of "Sun, 28 Jun 2020 18:55:09 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182477 Archived-At: >> My personal view is that we should allow only growing the size and >> resetting it to the original size of 300. Disabling the key record >> should be a separate feature, most probably implemented by means other >> than shrinking the recent_keys vector. > > I totally agree: they are clearly 2 separated features. > > Thanks for the comments, I will work on them and get back once > completed and tested. I agree that disabling should not necessarily be implemented by "abusing" the max-lossage setting. But I don't see any reason to impose a 300 minimum either. I think it's fine to impose a minimum, but it should be dictated by the limits of the code. I'm not saying we should work to push this lower limit down, but just that it should reflect what the code can do safely rather than being an arbitrary number like 300 (I'm pretty sure 100 would be safe as well, since that's what we've used for many years). Stefan