From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
38796@debbugs.gnu.org, uyennhi.qm@gmail.com
Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit
Date: Sat, 22 Aug 2020 23:24:02 +0200 [thread overview]
Message-ID: <87eenygyrx.fsf@gnus.org> (raw)
In-Reply-To: <87wo3qj1s6.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sun, 28 Jun 2020 23:52:57 +0200")
Tino Calancha <tino.calancha@gmail.com> writes:
>> I agree that disabling should not necessarily be implemented by
>> "abusing" the max-lossage setting.
> Yeah, it was appealing to me at first look: the code was offering
> another feature for free!
> After your comments I rethink about it and become less excited: it
> always posible that we might be hit back in other parts of the code
> if they assume a 'sensible large enough' value.
I thought it sounded quite natural to use the same mechanism to switch
lossage logging off. `(update-lossage-size 0)' seems like a natural
thing to do to have no lossage.
> Users can still safely modify the lossage limit with the
> command `update-lossage-size'. For convenience, add
> a function `lossage-size' to return the current limit.
Hm... other functions use the convention of having a zero-parameter
function return the data, and having a parameter to set it. So
(lossage-size 500) could set it and (lossage-size) could return the
current size?
Anyway, it doesn't look like you've merged the branch? I think
everybody was in favour of adding this feature.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-22 21:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 17:04 bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Drew Adams
2019-12-29 17:30 ` Eli Zaretskii
2019-12-29 17:34 ` Drew Adams
2020-06-26 21:58 ` Tino Calancha
2020-06-27 8:32 ` Eli Zaretskii
2020-06-28 16:55 ` Tino Calancha
2020-06-28 18:00 ` Stefan Monnier
2020-06-28 20:01 ` Drew Adams
2020-06-28 21:52 ` Tino Calancha
2020-06-29 0:05 ` Drew Adams
2020-08-22 21:24 ` Lars Ingebrigtsen [this message]
2020-08-22 22:54 ` Drew Adams
2020-08-27 21:28 ` Tino Calancha
2020-08-28 6:04 ` Eli Zaretskii
2020-09-04 9:31 ` Tino Calancha
2020-09-04 12:07 ` Eli Zaretskii
2020-09-12 12:29 ` Tino Calancha
2020-09-17 14:35 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eenygyrx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=38796@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tino.calancha@gmail.com \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).