unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: uyennhi.qm@gmail.com, stefankangas@gmail.com,
	38796@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit
Date: Thu, 27 Aug 2020 23:28:03 +0200	[thread overview]
Message-ID: <87d03beq3g.fsf@gmail.com> (raw)
In-Reply-To: <87eenygyrx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 22 Aug 2020 23:24:02 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Tino Calancha <tino.calancha@gmail.com> writes:
>
>>> I agree that disabling should not necessarily be implemented by
>>> "abusing" the max-lossage setting.
>> Yeah, it was appealing to me at first look: the code was offering
>> another feature for free!
>> After your comments I rethink about it and become less excited: it
>> always posible that we might be hit back in other parts of the code
>> if they assume a 'sensible large enough' value.
>
> I thought it sounded quite natural to use the same mechanism to switch
> lossage logging off.  `(update-lossage-size 0)' seems like a natural
> thing to do to have no lossage.
> Anyway, it doesn't look like you've merged the branch?  I think
> everybody was in favour of adding this feature.
People agree with that.  The friction arises because I kept the current
implementation, which can be seen as abusing on it, and/or risky.
[ I have neither plan nor time to redo the current implementation. ]
>>     Users can still safely modify the lossage limit with the
>>     command `update-lossage-size'.  For convenience, add
>>     a function `lossage-size' to return the current limit.
>
> Hm...  other functions use the convention of having a zero-parameter
> function return the data, and having a parameter to set it.  So
> (lossage-size 500) could set it and (lossage-size) could return the
> current size?
I have amended the patch to do this.  Thank you.

FWIW I have been running Emacs almost 3 months using this branch
with no issues.
If Eli is OK with it, I can merge it to master next week.





  parent reply	other threads:[~2020-08-27 21:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 17:04 bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Drew Adams
2019-12-29 17:30 ` Eli Zaretskii
2019-12-29 17:34   ` Drew Adams
2020-06-26 21:58   ` Tino Calancha
2020-06-27  8:32     ` Eli Zaretskii
2020-06-28 16:55       ` Tino Calancha
2020-06-28 18:00         ` Stefan Monnier
2020-06-28 20:01           ` Drew Adams
2020-06-28 21:52           ` Tino Calancha
2020-06-29  0:05             ` Drew Adams
2020-08-22 21:24             ` Lars Ingebrigtsen
2020-08-22 22:54               ` Drew Adams
2020-08-27 21:28               ` Tino Calancha [this message]
2020-08-28  6:04                 ` Eli Zaretskii
2020-09-04  9:31                   ` Tino Calancha
2020-09-04 12:07                     ` Eli Zaretskii
2020-09-12 12:29                       ` Tino Calancha
2020-09-17 14:35                         ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d03beq3g.fsf@gmail.com \
    --to=tino.calancha@gmail.com \
    --cc=38796@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    --cc=uyennhi.qm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).