From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 47150@debbugs.gnu.org, Sheng Yang <styang@fastmail.com>
Subject: bug#47150: 28.0.50; Incorrect major-mode in minibuffer
Date: Mon, 22 Mar 2021 14:08:46 -0400 [thread overview]
Message-ID: <jwvczvrrs66.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <YE/SAcvWKTxdVZVb@ACM> (Alan Mackenzie's message of "Mon, 15 Mar 2021 21:30:41 +0000")
[ Hi, perpetrator of `minibuffer-inactive-mode` speaking. ]
> minibuffer-inactive-mode: the critical thing here is "inactive", which
> means "doing nothing", or "not in use", or even "sleeping". The
> opposite word is "active". From its name, this major mode was never
> intended for use in active minibuffers,
That's right.
> but somehow nobody noticed that the buffer never got shifted out of
> minibuffer-inactive-mode when it came to be used again.
I did notice, but it didn't seem to cause any harm and I didn't want to
get into the discussion in which we are now, so I left things as
they stood.
> I've been fixing things in minibuf.c recently, and when I discovered
> this anomaly, I fixed it, so that an active minibuffer now runs in
> fundamental-mode, as originally intended. I did wonder why there was no
> "minibuffer-mode". But it was clear from the code that whoever wrote it
> intended minibuffers to use fundamental-mode whilst active.
I'm in favor of introducing a `minibuffer-mode`.
Part of the question is also when and how that mode is activated (since
activating such a mode has the effect of deleting the local variables).
I think we should call `minibuffer-mode` every time we (re)activate
a minibuffer.
>> For my case, I want automatic paren pairing and editing in
>> eval-expression.
> That does indeed suggest we really want a minibuffer-mode, rather than
> just fundamental-mode. But surely, the parenthesis pairing will be
> dependant on the sort of text you're typing into the minibuffer, so it
> can't really be connected with, say, minibuffer-mode.
The way I see it, `eval-expression` would want to use a new major mode
that derives from `minibuffer-mode`. And more generally
`read-from-minibuffer` should accept an argument that says which major
mode to use (I think it'd make sense to re-use the `keymap` argument
for that: if that argument is `functionp`, then treat it as a major
mode, if it's `keymapp` then use it as the keymap).
It would also provide a cleaner way to do what we currently do via the
`minibuffer-with-setup-hook` hack.
>> Plus we also need a keymap for it, which is
>> minibuffer-inactive-mode-map.
> No. That keymap is very low functionality, and almost useless, as it's
> intended to be.
Indeed, the purpose of that keymap is that you can press `f` (for
example) into a minibuffer-only frame to open a file, but only when
there's no active minibuffer in that minibuffer-only frame.
>> It seems to me the minibuffer is always inactive? I tried M-x,
>> M-!, M-:, all reports minibuffer-inactive-mode in Emacs 27.1. Is this
>> a mistake and the offending commit was trying to fix this
>> inconsistency?
> Very much so!
BTW: thank you for that.
> So, a quick summary: (i) the change in the minibuffer's major mode to
> fundamental-mode was intended; (ii) there may be some problems in some
> packages because of this;
The minibuffer used to be "always" in fundamental mode in Emacs<24
(since there was no `minibuffer-inactive-mode` back then), so I'm not
too worried.
Stefan
next prev parent reply other threads:[~2021-03-22 18:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 0:57 bug#47150: 28.0.50; Incorrect major-mode in minibuffer styang
2021-03-15 1:02 ` bug#47150: Emacs bug#47150 " Sheng Yang
2021-03-15 7:59 ` bug#47150: " Alan Mackenzie
2021-03-15 18:15 ` Sheng Yang
2021-03-15 21:30 ` Alan Mackenzie
2021-03-15 21:58 ` Sheng Yang
2021-03-22 15:12 ` Alan Mackenzie
2021-03-22 15:52 ` bug#47150: [External] : " Drew Adams
2021-03-22 16:27 ` Alan Mackenzie
2021-03-22 17:09 ` Drew Adams
[not found] ` <878s6ft5ze.fsf_-_@miha-pc>
2021-03-22 18:38 ` bug#47150: [External] : " Drew Adams
2021-03-22 21:57 ` bug#47150: [External] : " Alan Mackenzie
2021-03-22 23:06 ` Drew Adams
2021-03-23 13:05 ` Alan Mackenzie
2021-03-23 15:44 ` Drew Adams
2021-03-22 18:12 ` Stefan Monnier
2021-03-22 18:08 ` Stefan Monnier [this message]
2021-03-22 18:40 ` bug#47150: [External] : " Drew Adams
2021-03-22 19:30 ` Stefan Monnier
2021-03-22 19:42 ` Drew Adams
2021-03-22 20:11 ` Stefan Monnier
2021-03-22 21:36 ` Drew Adams
2021-04-09 8:57 ` Sheng Yang
2021-04-12 10:18 ` Alan Mackenzie
2021-04-12 12:02 ` Sheng Yang
2021-04-12 14:01 ` Stefan Monnier
2021-04-12 16:15 ` Alan Mackenzie
2021-04-12 17:10 ` Stefan Monnier
2021-04-12 18:34 ` Alan Mackenzie
2021-04-12 20:46 ` Stefan Monnier
2021-04-18 11:14 ` Alan Mackenzie
2021-04-18 15:22 ` Stefan Monnier
2021-04-19 9:33 ` Alan Mackenzie
2021-04-19 17:30 ` Alan Mackenzie
2021-04-19 18:22 ` Stefan Monnier
2021-04-19 19:18 ` Sheng Yang
2021-04-19 19:35 ` Stefan Monnier
2021-04-19 19:47 ` Sheng Yang
2021-04-19 20:36 ` Stefan Monnier
2021-04-19 20:42 ` Sheng Yang
2021-04-20 10:25 ` Alan Mackenzie
2021-03-22 19:42 ` Alan Mackenzie
2021-03-22 20:03 ` Stefan Monnier
2021-03-22 18:24 ` bug#47150: [External] : " jakanakaevangeli
2021-03-23 7:18 ` bug#47150: [External] : " jakanakaevangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvczvrrs66.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=47150@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=styang@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).