From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 49963@debbugs.gnu.org, larsi@gnus.org, laslydone@protonmail.com,
juri@linkov.net
Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace
Date: Tue, 10 Aug 2021 16:37:22 -0400 [thread overview]
Message-ID: <jwvbl6559es.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83bl65fdzq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Aug 2021 19:42:17 +0300")
Eli Zaretskii [2021-08-10 19:42:17] wrote:
>> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> Cc: Eli Zaretskii <eliz@gnu.org>, 49963@debbugs.gnu.org, juri@linkov.net,
>> laslydone@protonmail.com
>> Date: Tue, 10 Aug 2021 11:56:58 -0400
>>
>> Lars Ingebrigtsen [2021-08-10 17:44:50] wrote:
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >> I meant can we please not use add-function and friends. Please?
>> > There isn't much difference between using add-function and add-hook most
>> > of the time (although here we trip over a `let' binding not doing what
>> > the author thought it did).
>>
>> FWIW, `add-hook` has the exact same problem with `let` (and we already
>> tripped against this exact same situation with `add-hook` and `let`).
>
> This is a misunderstanding of what bothers me. The problem is
> discoverability: add-function is not easily discoverable, if it is
> used on an internal function.
I'm sorry, I don't understand. AFAIK it's used on variables (in the
present case it's used on the variable `isearch-filter-predicate`)
holding functions, not on internal functions.
> IOW, the documentation of C-s doesn't tell you that its operation
> could be affected by that "hook".
You mean the doc of `C-s` should state that it's affected by
`isearch-filter-predicate`?
Fine by me, but I don't know what this has to do with `add-function`
(`isearch-filter-predicate` existed before `add-function` was invented).
> By contrast, if we use some other mechanism, like call a function via
> a variable or call a hook,
Hmm... again I don't understand: we do "call a function via a variable",
the variable being `isearch-filter-predicate`.
Stefan
next prev parent reply other threads:[~2021-08-10 20:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 16:30 bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace laslydone via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 7:03 ` Juri Linkov
2021-08-10 13:38 ` Eli Zaretskii
2021-08-10 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 15:32 ` Eli Zaretskii
2021-08-10 15:44 ` Lars Ingebrigtsen
2021-08-10 15:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 16:42 ` Eli Zaretskii
2021-08-10 20:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-08-11 12:39 ` Eli Zaretskii
2021-08-11 2:58 ` Richard Stallman
2021-08-11 5:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 7:04 ` Juri Linkov
2021-08-10 16:37 ` Eli Zaretskii
2021-08-10 14:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 7:08 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbl6559es.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=49963@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=laslydone@protonmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).