From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace Date: Tue, 10 Aug 2021 16:37:22 -0400 Message-ID: References: <87k0kudsb8.fsf@mail.linkov.net> <83r1f1fmi2.fsf@gnu.org> <83lf59fh7q.fsf@gnu.org> <87h7fxxq19.fsf@gnus.org> <83bl65fdzq.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26244"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49963@debbugs.gnu.org, larsi@gnus.org, laslydone@protonmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 22:38:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDYVm-0006dS-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 22:38:11 +0200 Original-Received: from localhost ([::1]:35712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDYVl-0002Gv-0P for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 16:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDYVe-0002Dd-AD for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 16:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDYVe-0002ab-31 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 16:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDYVd-0007u7-NT for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 16:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 20:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49963 X-GNU-PR-Package: emacs Original-Received: via spool by 49963-submit@debbugs.gnu.org id=B49963.162862786430360 (code B ref 49963); Tue, 10 Aug 2021 20:38:01 +0000 Original-Received: (at 49963) by debbugs.gnu.org; 10 Aug 2021 20:37:44 +0000 Original-Received: from localhost ([127.0.0.1]:60922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDYVL-0007tc-IP for submit@debbugs.gnu.org; Tue, 10 Aug 2021 16:37:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDYVI-0007tN-Ml for 49963@debbugs.gnu.org; Tue, 10 Aug 2021 16:37:42 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AD87E8090F; Tue, 10 Aug 2021 16:37:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D404F807A2; Tue, 10 Aug 2021 16:37:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1628627848; bh=s6McoF0TI6t39JnkJ7frEsN9Pig4iSFaqK+KT0kmnfc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iBQu78mmMS/U3JG8sjCW8i/8fYU1Z3FKq69vsf/XERyqMXr2lnbbhY9KNpZfdHqdD Uev9RzOxGSjiRoW9soPocPpzhlKbvzcI21RfAxLaIbQFJnJEWveOwIZr0CqXQrQGaG LH3iW26zdo9m5Zaba2TUGhm1A7PcK7gXZ1T4Opq2NgSDmvhNSb8dQVZ+Czb1IH1NYT MEaCz8QxKYjNaFfBKmF7PwxV5HdrH4OElP0BgEIaOc5hUckT19BpIjZzobPe7jY70h fthstb0yMweSyEoWa/kYNtezWpxXpeb3meBBXKUVAUtyJw/7+OX72rFfIewY+au75x Xtqc256ylnLDw== Original-Received: from alfajor (104-222-120-40.cpe.teksavvy.com [104.222.120.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9035612031C; Tue, 10 Aug 2021 16:37:28 -0400 (EDT) In-Reply-To: <83bl65fdzq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Aug 2021 19:42:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211539 Archived-At: Eli Zaretskii [2021-08-10 19:42:17] wrote: >> From: Stefan Monnier >> Cc: Eli Zaretskii , 49963@debbugs.gnu.org, juri@linkov.net, >> laslydone@protonmail.com >> Date: Tue, 10 Aug 2021 11:56:58 -0400 >> >> Lars Ingebrigtsen [2021-08-10 17:44:50] wrote: >> > Eli Zaretskii writes: >> >> I meant can we please not use add-function and friends. Please? >> > There isn't much difference between using add-function and add-hook most >> > of the time (although here we trip over a `let' binding not doing what >> > the author thought it did). >> >> FWIW, `add-hook` has the exact same problem with `let` (and we already >> tripped against this exact same situation with `add-hook` and `let`). > > This is a misunderstanding of what bothers me. The problem is > discoverability: add-function is not easily discoverable, if it is > used on an internal function. I'm sorry, I don't understand. AFAIK it's used on variables (in the present case it's used on the variable `isearch-filter-predicate`) holding functions, not on internal functions. > IOW, the documentation of C-s doesn't tell you that its operation > could be affected by that "hook". You mean the doc of `C-s` should state that it's affected by `isearch-filter-predicate`? Fine by me, but I don't know what this has to do with `add-function` (`isearch-filter-predicate` existed before `add-function` was invented). > By contrast, if we use some other mechanism, like call a function via > a variable or call a hook, Hmm... again I don't understand: we do "call a function via a variable", the variable being `isearch-filter-predicate`. Stefan