unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Richard Stallman <rms@gnu.org>
Cc: 49963@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
	laslydone@protonmail.com, larsi@gnus.org, juri@linkov.net
Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace
Date: Wed, 11 Aug 2021 01:32:54 -0400	[thread overview]
Message-ID: <jwv8s184kem.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1mDeS7-0006zz-Su@fencepost.gnu.org> (Richard Stallman's message of "Tue, 10 Aug 2021 22:58:47 -0400")

>   > This is a misunderstanding of what bothers me.  The problem is
>   > discoverability: add-function is not easily discoverable, if it is
>   > used on an internal function.  IOW, the documentation of C-s doesn't
>   > tell you that its operation could be affected by that "hook".  By
>   > contrast, if we use some other mechanism, like call a function via a
>   > variable or call a hook, and if we document these in the doc string of
>   > C-s, that problem will have disappeared, and finding causes of
>   > problems such as this one would be easier.
>
> For this reason, we had the rule that packages or libraries should not
> define any advice.

Again, this bug report is not about the use of an advice.
There is no advice used in this code.


        Stefan






  reply	other threads:[~2021-08-11  5:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 16:30 bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace laslydone via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10  7:03 ` Juri Linkov
2021-08-10 13:38   ` Eli Zaretskii
2021-08-10 14:28     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 15:32       ` Eli Zaretskii
2021-08-10 15:44         ` Lars Ingebrigtsen
2021-08-10 15:56           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 16:42             ` Eli Zaretskii
2021-08-10 20:37               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 12:39                 ` Eli Zaretskii
2021-08-11  2:58               ` Richard Stallman
2021-08-11  5:32                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-08-11  7:04                 ` Juri Linkov
2021-08-10 16:37           ` Eli Zaretskii
2021-08-10 14:30   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11  7:08     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8s184kem.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=49963@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=laslydone@protonmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).