From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 49963@debbugs.gnu.org, monnier@iro.umontreal.ca,
laslydone@protonmail.com
Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace
Date: Tue, 10 Aug 2021 16:38:29 +0300 [thread overview]
Message-ID: <83r1f1fmi2.fsf@gnu.org> (raw)
In-Reply-To: <87k0kudsb8.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 10 Aug 2021 10:03:39 +0300)
> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 10 Aug 2021 10:03:39 +0300
> Cc: 49963@debbugs.gnu.org, laslydone <laslydone@protonmail.com>
>
> Stefan, please help. Wdired adds advice on a buffer-local isearch-filter-predicate,
> and perform-replace adds advice on a let-bound isearch-filter-predicate
> that changes the global value. This is the minimal test case:
>
> (add-function :after-while (local 'isearch-filter-predicate)
> (lambda (&rest _) 'filter-local))
>
> (let ((isearch-filter-predicate isearch-filter-predicate))
> (add-function :after-while isearch-filter-predicate
> (lambda (&rest _) 'filter-letbound)))
Regardless of how we solve this issue, could we please NOT use advices
in such cases? is there really no other reasonable solution for this,
like perhaps using some existing Isearch hook or (gasp!) introducing a
new one?
TIA
next prev parent reply other threads:[~2021-08-10 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 16:30 bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace laslydone via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 7:03 ` Juri Linkov
2021-08-10 13:38 ` Eli Zaretskii [this message]
2021-08-10 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 15:32 ` Eli Zaretskii
2021-08-10 15:44 ` Lars Ingebrigtsen
2021-08-10 15:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 16:42 ` Eli Zaretskii
2021-08-10 20:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 12:39 ` Eli Zaretskii
2021-08-11 2:58 ` Richard Stallman
2021-08-11 5:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 7:04 ` Juri Linkov
2021-08-10 16:37 ` Eli Zaretskii
2021-08-10 14:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-11 7:08 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r1f1fmi2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49963@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=laslydone@protonmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).