From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Matt Armstrong <matt@rfc20.org>, 47552-done@debbugs.gnu.org
Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code
Date: Fri, 23 Jun 2023 11:37:53 -0400 [thread overview]
Message-ID: <jwva5wqz175.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv5y7kzko2.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 18 Jun 2023 15:03:25 -0400")
> (defmacro slet* (bindings &rest body)
> (named-let expand ((bindings bindings))
> (pcase-exhaustive bindings
> ('() (macroexp-progn body))
> (`((,var ,exp) . ,bindings)
> (let ((rest (expand bindings)))
> (if (macroexp--dynamic-variable-p var)
> `(funcall (identity (lambda (,var) ,rest)) ,exp)
> (macroexp-let* `((,var ,exp)) rest)))))))
Not sure we want to expose that to the language, so I turned it into
a function in `cl-macs.el` for use by `cl-defun/defmacro/defsubst/...`
and pushed it to `master`.
I believe this fixes the bug.
Stefan
next prev parent reply other threads:[~2023-06-23 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:38 bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Matt Armstrong
2021-04-04 20:17 ` Lars Ingebrigtsen
2021-04-04 22:59 ` Stefan Monnier
2021-04-11 16:31 ` Lars Ingebrigtsen
2023-06-16 3:48 ` Michael Heerdegen
2023-06-18 19:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 15:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-24 0:19 ` Michael Heerdegen
2023-06-24 15:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 3:43 ` Michael Heerdegen
2023-06-25 4:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 4:45 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva5wqz175.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=47552-done@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=matt@rfc20.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).