From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: matt@rfc20.org, 47552@debbugs.gnu.org
Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code
Date: Sun, 25 Jun 2023 00:03:52 -0400 [thread overview]
Message-ID: <jwvy1k8nqcr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y1k8jjg4.fsf@web.de> (Michael Heerdegen's message of "Sun, 25 Jun 2023 05:43:07 +0200")
> One (very small) downside of the code generated now is that it may
> trigger "Lexical argument shadows the dynamic variable" warnings.
Yup. The current code doesn't offer a way to silence them with
`with-suppressed-warnings`, AFAICT :-(
> 'date' for example is bad as a slot name when "diary" is loaded.
AFAIK, `date` is not globally defined as dynbound by diary, so it should
not be a problem. More specifically, the `date` variable is treated as
dynbound only inside calendar's own files, but not in code found in
other files.
If you found it to be otherwise, please report it as a bug.
Stefan
next prev parent reply other threads:[~2023-06-25 4:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:38 bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Matt Armstrong
2021-04-04 20:17 ` Lars Ingebrigtsen
2021-04-04 22:59 ` Stefan Monnier
2021-04-11 16:31 ` Lars Ingebrigtsen
2023-06-16 3:48 ` Michael Heerdegen
2023-06-18 19:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 15:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-24 0:19 ` Michael Heerdegen
2023-06-24 15:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 3:43 ` Michael Heerdegen
2023-06-25 4:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-25 4:45 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy1k8nqcr.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=47552@debbugs.gnu.org \
--cc=matt@rfc20.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).