unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Matt Armstrong <matt@rfc20.org>, 47552@debbugs.gnu.org
Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code
Date: Sun, 11 Apr 2021 18:31:20 +0200	[thread overview]
Message-ID: <87pmz0236v.fsf@gnus.org> (raw)
In-Reply-To: <jwvim51r7dl.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 04 Apr 2021 18:59:36 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I'm pretty sure that's the right solution, *but* I don't think it's
> obvious how to get there: `cl-defstruct` defines the constructor
> using `cl-defsubst` and its `&key` arguments, so the `:gcs-gone` keyword
> argument inevitably maps to a `gcs-done` variable by definition of how
> `&key` is supposed to work.

I'm having a hard time following the code in cl-defstruct -- even where
things are actually defined.

But...  Indeed doing this "doesn't work":

(cl-defsubst foo4 (&key gcs-done)
  gcs-done)

(foo4 :foo 1)
-> Debugger entered--Lisp error: (wrong-type-argument numberp nil)

But:

(foo4 :gcs-done 1)
=> 1

Hm...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-04-11 16:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 18:38 bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Matt Armstrong
2021-04-04 20:17 ` Lars Ingebrigtsen
2021-04-04 22:59   ` Stefan Monnier
2021-04-11 16:31     ` Lars Ingebrigtsen [this message]
2023-06-16  3:48       ` Michael Heerdegen
2023-06-18 19:03       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 15:37         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-24  0:19           ` Michael Heerdegen
2023-06-24 15:45             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25  3:43               ` Michael Heerdegen
2023-06-25  4:03                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25  4:45                   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmz0236v.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=47552@debbugs.gnu.org \
    --cc=matt@rfc20.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).