From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Date: Fri, 23 Jun 2023 11:37:53 -0400 Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37962"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Matt Armstrong , 47552-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 23 17:39:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCisc-0009jq-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jun 2023 17:39:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCisK-00019U-9q; Fri, 23 Jun 2023 11:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCisI-00018h-9x for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 11:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCisI-0007aP-1M for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 11:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCisH-00021x-Sl for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 11:39:01 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47552 X-GNU-PR-Package: emacs Mail-Followup-To: 47552@debbugs.gnu.org, monnier@iro.umontreal.ca, matt@rfc20.org Original-Received: via spool by 47552-done@debbugs.gnu.org id=D47552.16875346967745 (code D ref 47552); Fri, 23 Jun 2023 15:39:01 +0000 Original-Received: (at 47552-done) by debbugs.gnu.org; 23 Jun 2023 15:38:16 +0000 Original-Received: from localhost ([127.0.0.1]:39398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCirY-00020r-Cf for submit@debbugs.gnu.org; Fri, 23 Jun 2023 11:38:16 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCirT-00020b-ON for 47552-done@debbugs.gnu.org; Fri, 23 Jun 2023 11:38:15 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 082E6443383; Fri, 23 Jun 2023 11:38:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 65A0B443380; Fri, 23 Jun 2023 11:38:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687534680; bh=IcWF2k9oXKW/IgsQKuszw+hFbKJZptWokekZPsiBmO8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fWFRtvIKT0XXBuuVgNjdFNcliiJJdjOUfKRmRKvi46TVkCgtFVe83fBHyEW1Iv0Q0 dOwNfozuZnjNDJt04cPyB0eglTjn3ZS7jJ1LpHMDVe5CWdhlkgPoYWywDYq2JtS01i A7V4Yvrrycc+YWWAQZVHYhMt23OcymGqvgswApV/mMPLLSviH4Z8DrnIgYoNW53Msi HAMz8IVHf8SfvO6boiHcKbKtGOuFs0HfdDWYQgpHeZm5y+ZFjyd8BGeN1P84JN8p1B THn/qNeW0W0O+tUD7IYJByVm1A4iQFNZriNEW9IYZ1r2nWmwNsWPe4S/AQ81jqzeoX bX5CYcEXVa1xQ== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 46163120193; Fri, 23 Jun 2023 11:38:00 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 18 Jun 2023 15:03:25 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263963 Archived-At: > (defmacro slet* (bindings &rest body) > (named-let expand ((bindings bindings)) > (pcase-exhaustive bindings > ('() (macroexp-progn body)) > (`((,var ,exp) . ,bindings) > (let ((rest (expand bindings))) > (if (macroexp--dynamic-variable-p var) > `(funcall (identity (lambda (,var) ,rest)) ,exp) > (macroexp-let* `((,var ,exp)) rest))))))) Not sure we want to expose that to the language, so I turned it into a function in `cl-macs.el` for use by `cl-defun/defmacro/defsubst/...` and pushed it to `master`. I believe this fixes the bug. Stefan