From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 47832@debbugs.gnu.org
Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon
Date: Tue, 25 May 2021 13:24:14 +0000 [thread overview]
Message-ID: <e19e2fa860b4e72448d3@heytings.org> (raw)
In-Reply-To: <83zgwjar91.fsf@gnu.org>
>> There are three kind of bitmaps:
>>
>> 1. standard bitmaps not overridden by user-defined bitmaps
>> 2. standard bitmaps overridden by user-defined bitmaps
>> 3. user-defined bitmaps
>>
>> The first loop processes the bitmaps of the first kind, the second loop
>> the bitmaps of the second and third kind.
>
> I'm asking why do we need to process the second kind here. That kind
> was already set up when user initializations defined replacements for
> those standard bitmaps. Right? So why do we need to set them up again?
>
What you write is correct when you call "emacs", not when you call "emacs
--daemon". In the latter case the user-defined bitmaps have not yet been
set up. It's explained in the comment:
/* Set up user-defined fringe bitmaps that might have been defined
before the frame of this kind was initialized. This can happen
if Emacs is started as a daemon and the init files define fringe
bitmaps. */
The code was written under the erroneous assumption that there are only
two kind of bitmaps: standard bitmaps and user-defined bitmaps. Hence the
bug that this patch fixes.
next prev parent reply other threads:[~2021-05-25 13:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 22:22 bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Gregory Heytings
2021-04-17 6:49 ` Eli Zaretskii
2021-04-17 9:49 ` Gregory Heytings
2021-04-17 10:57 ` Eli Zaretskii
2021-04-17 11:21 ` Eli Zaretskii
2021-04-17 11:32 ` Gregory Heytings
2021-04-17 12:27 ` Eli Zaretskii
2021-04-17 12:52 ` Gregory Heytings
2021-05-25 4:21 ` Lars Ingebrigtsen
2021-05-25 11:55 ` Eli Zaretskii
2021-05-25 12:44 ` Gregory Heytings
2021-05-25 12:56 ` Eli Zaretskii
2021-05-25 13:03 ` Gregory Heytings
2021-05-25 13:15 ` Eli Zaretskii
2021-05-25 13:24 ` Gregory Heytings [this message]
2021-05-25 13:45 ` Eli Zaretskii
2021-05-26 13:27 ` Eli Zaretskii
2021-05-27 7:32 ` Gregory Heytings
2021-05-27 9:35 ` Eli Zaretskii
2021-04-17 11:34 ` Gregory Heytings
2021-04-17 12:28 ` Eli Zaretskii
2021-04-17 11:27 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e19e2fa860b4e72448d3@heytings.org \
--to=gregory@heytings.org \
--cc=47832@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).