From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Tue, 25 May 2021 13:24:14 +0000 Message-ID: References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> <83fszpw40t.fsf@gnu.org> <1869622e16c60dc2ce0d@heytings.org> <83eef9w0xd.fsf@gnu.org> <1869622e16270efbc7e8@heytings.org> <87im3778ao.fsf@gnus.org> <83eedvc9jm.fsf@gnu.org> <835yz7c6p0.fsf@gnu.org> <83zgwjar91.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 47832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 15:25:44 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llX41-000AEO-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 15:25:41 +0200 Original-Received: from localhost ([::1]:59782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llX41-0000zb-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 09:25:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llX3O-0000yM-M3 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llX3N-0001PJ-R1 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llX3N-0006OU-Nl for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 13:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.162194905724515 (code B ref 47832); Tue, 25 May 2021 13:25:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 25 May 2021 13:24:17 +0000 Original-Received: from localhost ([127.0.0.1]:45016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llX2e-0006NK-UX for submit@debbugs.gnu.org; Tue, 25 May 2021 09:24:17 -0400 Original-Received: from heytings.org ([95.142.160.155]:36550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llX2d-0006NC-9L for 47832@debbugs.gnu.org; Tue, 25 May 2021 09:24:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1621949054; bh=4dii+JXh09BeXSTpAlXnTcFEpBAD2fEe/q+Vyf1sKYc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Fp0FpdD6XqykvMqah/xPEDKj1w7IqrSmYHx7Q3oDW37Gb5fKU2Qnd7c3cdQCHWNIY ow3L7IreO59mFnGcorjWUL14LSZC/GxIvgjwHWvHgBkSF/tr5cgk/cWDYJIfwDpLuD f8jtcBI7dj37x2RiBGcwWFnnUbwYikdeCxHti63Y78VhXGjY4D3q0kIOnk7uacWdZM l8727d7sefEl7znPAZI3lf4ghCQQzv9yS69fUhj8vEQwTa90/yHrqGh98eTqAzvZJl LBfUoumTrziT5xXqe+/casBy05ugSoz08OItzDFd4EQW/ZKroWu7xiLiY9OQPZ08NR f1FUAICm/GtaA== In-Reply-To: <83zgwjar91.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207213 Archived-At: >> There are three kind of bitmaps: >> >> 1. standard bitmaps not overridden by user-defined bitmaps >> 2. standard bitmaps overridden by user-defined bitmaps >> 3. user-defined bitmaps >> >> The first loop processes the bitmaps of the first kind, the second loop >> the bitmaps of the second and third kind. > > I'm asking why do we need to process the second kind here. That kind > was already set up when user initializations defined replacements for > those standard bitmaps. Right? So why do we need to set them up again? > What you write is correct when you call "emacs", not when you call "emacs --daemon". In the latter case the user-defined bitmaps have not yet been set up. It's explained in the comment: /* Set up user-defined fringe bitmaps that might have been defined before the frame of this kind was initialized. This can happen if Emacs is started as a daemon and the init files define fringe bitmaps. */ The code was written under the erroneous assumption that there are only two kind of bitmaps: standard bitmaps and user-defined bitmaps. Hence the bug that this patch fixes.