From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47832@debbugs.gnu.org
Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon
Date: Sat, 17 Apr 2021 09:49:46 +0000 [thread overview]
Message-ID: <1869622e16688e6aedec@heytings.org> (raw)
In-Reply-To: <83mttxwgm8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
>
> However, if this used to work,
>
This used to work indeed; it worked on GNU/Linux with default (non-Cairo)
builds for Emacs 24 to 27.
>
> it would be good to understand which change broke it.
>
Got it! :-) The commit I identified is indeed the culprit. With
USE_CAIRO, gui_init_fringe() is called in x_initialize(); without
USE_CAIRO it isn't. And gui_init_fringe() had a bug, which should now be
fixed on Windows, too. Patch attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch, Size: 988 bytes --]
From 4d5a18bbb18496eb02e949b993cc3f9bca7c4d91 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Sat, 17 Apr 2021 09:37:21 +0000
Subject: [PATCH] Consider all user-defined bitmaps in gui_init_fringe()
* src/fringe.c (gui_init_fringe): Also consider user-defined bitmaps that
override default ones (Bug#47832).
---
src/fringe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fringe.c b/src/fringe.c
index 65c9a84ac9..f2b60b5c8e 100644
--- a/src/fringe.c
+++ b/src/fringe.c
@@ -1783,7 +1783,7 @@ gui_init_fringe (struct redisplay_interface *rif)
before the frame of this kind was initialized. This can happen
if Emacs is started as a daemon and the init files define fringe
bitmaps. */
- for ( ; bt < max_used_fringe_bitmap; bt++)
+ for (bt = NO_FRINGE_BITMAP + 1; bt < max_used_fringe_bitmap; bt++)
{
struct fringe_bitmap *fb = fringe_bitmaps[bt];
if (fb)
--
2.30.2
next prev parent reply other threads:[~2021-04-17 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 22:22 bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Gregory Heytings
2021-04-17 6:49 ` Eli Zaretskii
2021-04-17 9:49 ` Gregory Heytings [this message]
2021-04-17 10:57 ` Eli Zaretskii
2021-04-17 11:21 ` Eli Zaretskii
2021-04-17 11:32 ` Gregory Heytings
2021-04-17 12:27 ` Eli Zaretskii
2021-04-17 12:52 ` Gregory Heytings
2021-05-25 4:21 ` Lars Ingebrigtsen
2021-05-25 11:55 ` Eli Zaretskii
2021-05-25 12:44 ` Gregory Heytings
2021-05-25 12:56 ` Eli Zaretskii
2021-05-25 13:03 ` Gregory Heytings
2021-05-25 13:15 ` Eli Zaretskii
2021-05-25 13:24 ` Gregory Heytings
2021-05-25 13:45 ` Eli Zaretskii
2021-05-26 13:27 ` Eli Zaretskii
2021-05-27 7:32 ` Gregory Heytings
2021-05-27 9:35 ` Eli Zaretskii
2021-04-17 11:34 ` Gregory Heytings
2021-04-17 12:28 ` Eli Zaretskii
2021-04-17 11:27 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1869622e16688e6aedec@heytings.org \
--to=gregory@heytings.org \
--cc=47832@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).