unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: 47832@debbugs.gnu.org
Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon
Date: Sat, 17 Apr 2021 15:27:58 +0300	[thread overview]
Message-ID: <83eef9w0xd.fsf@gnu.org> (raw)
In-Reply-To: <1869622e16c60dc2ce0d@heytings.org> (message from Gregory Heytings on Sat, 17 Apr 2021 11:32:25 +0000)

> Date: Sat, 17 Apr 2021 11:32:25 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 47832@debbugs.gnu.org
> 
> > Since gui_init_fringe returns immediately if the frame interface doesn't 
> > provide a method for fringe initialization, I think we should call 
> > gui_init_fringe unconditionally on X.

Here I meant to call gui_init_fringe unconditionally.  It will make
the code less confusing.

> > And in any case, the patch for gui_init_fringe is sub-optimal: it 
> > unnecessarily loops over the standard bitmaps that were superseded. It 
> > is better to leave the first loop go over the standard bitmaps, whether 
> > superseded or not, and the second loop go over non-standard bitmaps 
> > only.
> 
> It is not sub-optimal, rif->define_fringe_bitmap will only be called for 
> those standard bitmaps that were superseded.  For the non-superseded ones, 
> fringe_bitmaps[bt] is NULL.

I meant the first loop, not the second one.





  reply	other threads:[~2021-04-17 12:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 22:22 bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Gregory Heytings
2021-04-17  6:49 ` Eli Zaretskii
2021-04-17  9:49   ` Gregory Heytings
2021-04-17 10:57     ` Eli Zaretskii
2021-04-17 11:21       ` Eli Zaretskii
2021-04-17 11:32         ` Gregory Heytings
2021-04-17 12:27           ` Eli Zaretskii [this message]
2021-04-17 12:52             ` Gregory Heytings
2021-05-25  4:21               ` Lars Ingebrigtsen
2021-05-25 11:55                 ` Eli Zaretskii
2021-05-25 12:44                   ` Gregory Heytings
2021-05-25 12:56                     ` Eli Zaretskii
2021-05-25 13:03                       ` Gregory Heytings
2021-05-25 13:15                         ` Eli Zaretskii
2021-05-25 13:24                           ` Gregory Heytings
2021-05-25 13:45                             ` Eli Zaretskii
2021-05-26 13:27                               ` Eli Zaretskii
2021-05-27  7:32                                 ` Gregory Heytings
2021-05-27  9:35                                   ` Eli Zaretskii
2021-04-17 11:34         ` Gregory Heytings
2021-04-17 12:28           ` Eli Zaretskii
2021-04-17 11:27       ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eef9w0xd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47832@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).