From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: brandon.irizarry@gmail.com, Eli Zaretskii <eliz@gnu.org>,
65344@debbugs.gnu.org
Subject: bug#65344: 28.2; Unable to Edebug cl-flet form which uses argument destructuring
Date: Sun, 20 Aug 2023 07:32:50 +0200 [thread overview]
Message-ID: <cf02efc5-c140-3f3e-5d71-b0a2d7f7b95c@gmail.com> (raw)
In-Reply-To: <877cpqs6vi.fsf@web.de>
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
On 20.08.23 05:57, Michael Heerdegen wrote:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> (debug ((&rest [&or (&define [&name symbolp "@cl-flet@"]
>> [&name [] gensym] ;Make it unique!
>> cl-lambda-list
>> cl-declarations-or-string
>> [&optional ("interactive" interactive)]
>> def-body)
>> (&define [&name symbolp "@cl-flet@"]
>> [&name [] gensym] ;Make it unique!
>> def-body)])
>
>> The second &define is for the (FN EXPR) bindings. It comes after the
>> &define for "normal" function bindings because because, for some
>> reason, apparently the second &define also matches the other case.
>
> That's because you use 'def-body' which matches any number of body
> expressions. I think this is not correct: we are expecting a single
> form.
Ah, I see. Thanks.
>
> Apart from that: yes, something like this... I did not yet understand
> the &name magic.
>
> And i wonder whether we should apply the distributive law and factor out
> the first few identical specs inside the &or.
I'd rather keep the two separate, I must admit. Basically, bacause the
first case it the important one, and the second I find obscure.
I also checked now what's up with functions whose name is (setf ...),
which is valid CL. That's not supported in ELisp, it seems, so I
changed the debug spec of cl-defun accordingly in the attached patch.
If this looks good, I'd bring that to master, unless Eli wants it in 29.
[-- Attachment #2: flet.patch --]
[-- Type: text/plain, Size: 1450 bytes --]
modified lisp/emacs-lisp/cl-macs.el
@@ -389,7 +389,7 @@ cl-defun
\(fn NAME ARGLIST [DOCSTRING] BODY...)"
(declare (debug
;; Same as defun but use cl-lambda-list.
- (&define [&name sexp] ;Allow (setf ...) additionally to symbols.
+ (&define [&name symbolp]
cl-lambda-list
cl-declarations-or-string
[&optional ("interactive" interactive)]
@@ -2064,13 +2064,15 @@ cl-flet
\(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
(declare (indent 1)
- (debug ((&rest [&or (symbolp form)
- (&define [&name symbolp "@cl-flet@"]
+ (debug ((&rest [&or (&define [&name symbolp "@cl-flet@"]
[&name [] gensym] ;Make it unique!
cl-lambda-list
cl-declarations-or-string
[&optional ("interactive" interactive)]
- def-body)])
+ def-body)
+ (&define [&name symbolp "@cl-flet@"]
+ [&name [] gensym] ;Make it unique!
+ def-form)])
cl-declarations body)))
(let ((binds ()) (newenv macroexpand-all-environment))
(dolist (binding bindings)
next prev parent reply other threads:[~2023-08-20 5:32 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 18:21 bug#65344: 28.2; Unable to Edebug cl-flet form which uses argument destructuring Brandon Irizarry
2023-08-17 0:55 ` Michael Heerdegen
2023-08-17 5:29 ` Gerd Möllmann
2023-08-17 15:42 ` Brandon Irizarry
2023-08-17 15:56 ` Eli Zaretskii
2023-08-17 18:23 ` Gerd Möllmann
2023-08-17 23:07 ` Michael Heerdegen
2023-08-18 5:19 ` Gerd Möllmann
2023-08-18 5:58 ` Michael Heerdegen
2023-08-18 6:43 ` Gerd Möllmann
2023-08-19 8:08 ` Gerd Möllmann
2023-08-20 3:57 ` Michael Heerdegen
2023-08-20 5:32 ` Gerd Möllmann [this message]
2023-08-20 6:08 ` Michael Heerdegen
2023-08-20 6:48 ` Gerd Möllmann
2023-08-21 1:19 ` Michael Heerdegen
2023-08-21 7:01 ` Gerd Möllmann
2023-08-21 7:10 ` Gerd Möllmann
2023-08-21 7:30 ` Gerd Möllmann
2023-08-22 0:54 ` Michael Heerdegen
2023-08-22 5:48 ` Gerd Möllmann
2023-08-22 6:10 ` Michael Heerdegen
2023-08-22 8:05 ` Gerd Möllmann
2023-08-22 21:06 ` Brandon Irizarry
2023-08-23 0:35 ` Michael Heerdegen
2023-08-23 0:32 ` Michael Heerdegen
2023-08-23 1:25 ` Drew Adams
2023-08-23 6:06 ` Gerd Möllmann
2023-08-23 14:23 ` Drew Adams
2023-08-24 3:16 ` Michael Heerdegen
2023-08-24 9:10 ` Gerd Möllmann
2023-08-24 23:04 ` Michael Heerdegen
2023-08-25 1:53 ` Drew Adams
2023-08-25 4:07 ` Michael Heerdegen
2023-08-25 14:50 ` Drew Adams
2023-08-26 0:16 ` Michael Heerdegen
2023-08-26 2:02 ` Drew Adams
2023-08-20 4:39 ` Michael Heerdegen
2023-08-20 5:15 ` Gerd Möllmann
2023-08-23 9:25 ` Mattias Engdegård
2023-08-23 9:31 ` Mattias Engdegård
2023-08-23 11:10 ` Gerd Möllmann
2023-08-23 14:08 ` Gerd Möllmann
2023-08-24 1:14 ` Michael Heerdegen
2023-08-24 6:17 ` Gerd Möllmann
2023-08-25 4:10 ` Michael Heerdegen
2023-08-25 6:19 ` Gerd Möllmann
2023-08-25 4:22 ` Michael Heerdegen
2023-08-25 6:33 ` Gerd Möllmann
2023-08-25 17:53 ` Michael Heerdegen
2023-08-26 5:39 ` Gerd Möllmann
2023-08-27 4:02 ` Michael Heerdegen
2023-08-27 6:34 ` Gerd Möllmann
2023-09-01 23:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 5:10 ` Gerd Möllmann
2023-09-02 17:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 19:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 5:51 ` Gerd Möllmann
2023-09-03 16:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-03 16:47 ` Gerd Möllmann
2023-09-04 21:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 9:33 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf02efc5-c140-3f3e-5d71-b0a2d7f7b95c@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=65344@debbugs.gnu.org \
--cc=brandon.irizarry@gmail.com \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).