From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#65344: 28.2; Unable to Edebug cl-flet form which uses argument destructuring Date: Sun, 20 Aug 2023 07:32:50 +0200 Message-ID: References: <040fe8aa-7a15-762c-e710-eb85f997d329@gmail.com> <871qg1tghr.fsf@web.de> <012813c5-cfc3-7ba9-5e84-70d79c172e77@gmail.com> <87zg2oyjre.fsf@web.de> <8b7fc1c2-ae6c-b825-c772-38b18ddb67d6@gmail.com> <877cpqs6vi.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------suOS7Nl2vk8V2oChVXydHSNM" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30634"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: brandon.irizarry@gmail.com, Eli Zaretskii , 65344@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 07:34:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXb4s-0007oE-6o for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 07:34:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXb4c-0001P3-Ty; Sun, 20 Aug 2023 01:34:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXb4b-0001Oj-4R for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 01:34:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXb4a-0003Nw-Pv for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 01:34:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXb4c-0007QK-3g for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 01:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 05:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65344 X-GNU-PR-Package: emacs Original-Received: via spool by 65344-submit@debbugs.gnu.org id=B65344.169250958828470 (code B ref 65344); Sun, 20 Aug 2023 05:34:02 +0000 Original-Received: (at 65344) by debbugs.gnu.org; 20 Aug 2023 05:33:08 +0000 Original-Received: from localhost ([127.0.0.1]:52690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXb3h-0007P5-Ht for submit@debbugs.gnu.org; Sun, 20 Aug 2023 01:33:08 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:46341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXb3b-0007OV-1L for 65344@debbugs.gnu.org; Sun, 20 Aug 2023 01:33:03 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so2818651a12.1 for <65344@debbugs.gnu.org>; Sat, 19 Aug 2023 22:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692509572; x=1693114372; h=in-reply-to:subject:from:references:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=tJgqsA6WdttRsDljEGM0cP4hTf67gPJLfxh3r1Cn8eo=; b=fcs/Pr4RvH/VnTdVO/gesBbNXvFg3xCLtUBnvhS9LZ8J4bcCvmWv/9zOIbmXmdG+Ky wMM3HQ5CnxT06tEPs5wknxUGB6Nh4t14OO9eC5Loa4t9cNFrVPICXEzN0J2Nw/t4Jg+1 3ZWFpwLeJiRIBfv9aDWBNPgUfUTyOrW1d0Diu/iF4sDf9oGOysppDBie79xAaVnqiYrw ncp1x4+bJoujfHQsOGub0jcWLb1l9ABlDf2LlnrthKa99iKKqKej0Ivj54ATy3+4ehba /OL+5m0LOlpMmmodpZvP+M+c3s+xfg2uEYEnOc++eQzzdiwUKVvE9EN1UJCzVGEwFHQa HaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692509572; x=1693114372; h=in-reply-to:subject:from:references:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tJgqsA6WdttRsDljEGM0cP4hTf67gPJLfxh3r1Cn8eo=; b=kkOBWB2G0VV49KO5q9b1noeoQQE4/XyaZbumFV/7hYE1etNJxwVwbHNTW353OXIAaj X+7gACoQkTVvKHc8csy7W9JEfsWCHb33sJKtsnHIjYHn1N5B4ESC4oS0PistgtWBA5Pt oPWpXkT1+5zB3pBAdwtvuG/oByW534uRgfw6dvnznkVNQVZRircPcKA02HzQQ1i+0tsT 2/YeR5RYSTO0Ibbqxlsyu1tKRjJ4mCMBdBTivA79lVMc+yIvEkbTwAUoy9mELBnoTE8L J3O7VIXMpKs3vM7pFOeyLlsoBKlOCt7lfwR/mk6FquBHj1db8lmHldQ0J6JdXwfx1eiX 97tw== X-Gm-Message-State: AOJu0YxPE0q0DxTBYSbDkyCa69Q/qoM9rLg+LNAkJjxa6FvK3ZKd3aEd xDu0RkEOdewtkZsyK4e1ut8= X-Google-Smtp-Source: AGHT+IHIn/3jgaUu5ARdrwv6z7dagrnD7nJl5KIRcSHCEdyPnDtLcPXj87meHMs/rjL30tbORVbi0A== X-Received: by 2002:a50:fa93:0:b0:523:102f:3cdd with SMTP id w19-20020a50fa93000000b00523102f3cddmr2765489edr.19.1692509571639; Sat, 19 Aug 2023 22:32:51 -0700 (PDT) Original-Received: from [192.168.178.21] (p54b0cabb.dip0.t-ipconnect.de. [84.176.202.187]) by smtp.gmail.com with ESMTPSA id e11-20020a056402104b00b0051e22660835sm3697839edu.46.2023.08.19.22.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 22:32:51 -0700 (PDT) Content-Language: en-US In-Reply-To: <877cpqs6vi.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267938 Archived-At: This is a multi-part message in MIME format. --------------suOS7Nl2vk8V2oChVXydHSNM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20.08.23 05:57, Michael Heerdegen wrote: > Gerd Möllmann writes: > >> (debug ((&rest [&or (&define [&name symbolp "@cl-flet@"] >> [&name [] gensym] ;Make it unique! >> cl-lambda-list >> cl-declarations-or-string >> [&optional ("interactive" interactive)] >> def-body) >> (&define [&name symbolp "@cl-flet@"] >> [&name [] gensym] ;Make it unique! >> def-body)]) > >> The second &define is for the (FN EXPR) bindings. It comes after the >> &define for "normal" function bindings because because, for some >> reason, apparently the second &define also matches the other case. > > That's because you use 'def-body' which matches any number of body > expressions. I think this is not correct: we are expecting a single > form. Ah, I see. Thanks. > > Apart from that: yes, something like this... I did not yet understand > the &name magic. > > And i wonder whether we should apply the distributive law and factor out > the first few identical specs inside the &or. I'd rather keep the two separate, I must admit. Basically, bacause the first case it the important one, and the second I find obscure. I also checked now what's up with functions whose name is (setf ...), which is valid CL. That's not supported in ELisp, it seems, so I changed the debug spec of cl-defun accordingly in the attached patch. If this looks good, I'd bring that to master, unless Eli wants it in 29. --------------suOS7Nl2vk8V2oChVXydHSNM Content-Type: text/plain; charset=UTF-8; name="flet.patch" Content-Disposition: attachment; filename="flet.patch" Content-Transfer-Encoding: base64 bW9kaWZpZWQgICBsaXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbApAQCAtMzg5LDcgKzM4OSw3 IEBAIGNsLWRlZnVuCiBcKGZuIE5BTUUgQVJHTElTVCBbRE9DU1RSSU5HXSBCT0RZLi4uKSIK ICAgKGRlY2xhcmUgKGRlYnVnCiAgICAgICAgICAgICA7OyBTYW1lIGFzIGRlZnVuIGJ1dCB1 c2UgY2wtbGFtYmRhLWxpc3QuCi0gICAgICAgICAgICAoJmRlZmluZSBbJm5hbWUgc2V4cF0g ICA7QWxsb3cgKHNldGYgLi4uKSBhZGRpdGlvbmFsbHkgdG8gc3ltYm9scy4KKyAgICAgICAg ICAgICgmZGVmaW5lIFsmbmFtZSBzeW1ib2xwXQogICAgICAgICAgICAgICAgICAgICAgY2wt bGFtYmRhLWxpc3QKICAgICAgICAgICAgICAgICAgICAgIGNsLWRlY2xhcmF0aW9ucy1vci1z dHJpbmcKICAgICAgICAgICAgICAgICAgICAgIFsmb3B0aW9uYWwgKCJpbnRlcmFjdGl2ZSIg aW50ZXJhY3RpdmUpXQpAQCAtMjA2NCwxMyArMjA2NCwxNSBAQCBjbC1mbGV0CiAKIFwoZm4g KChGVU5DIEFSR0xJU1QgQk9EWS4uLikgLi4uKSBGT1JNLi4uKSIKICAgKGRlY2xhcmUgKGlu ZGVudCAxKQotICAgICAgICAgICAoZGVidWcgKCgmcmVzdCBbJm9yIChzeW1ib2xwIGZvcm0p Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCZkZWZpbmUgWyZuYW1lIHN5bWJv bHAgIkBjbC1mbGV0QCJdCisgICAgICAgICAgIChkZWJ1ZyAoKCZyZXN0IFsmb3IgKCZkZWZp bmUgWyZuYW1lIHN5bWJvbHAgIkBjbC1mbGV0QCJdCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgWyZuYW1lIFtdIGdlbnN5bV0gO01ha2UgaXQgdW5pcXVlIQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsLWxhbWJkYS1saXN0 CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2wtZGVjbGFyYXRp b25zLW9yLXN0cmluZwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFsmb3B0aW9uYWwgKCJpbnRlcmFjdGl2ZSIgaW50ZXJhY3RpdmUpXQotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlZi1ib2R5KV0pCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmLWJvZHkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKCZkZWZpbmUgWyZuYW1lIHN5bWJvbHAgIkBjbC1mbGV0QCJdCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWyZuYW1lIFtdIGdlbnN5 bV0gO01ha2UgaXQgdW5pcXVlIQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGRlZi1mb3JtKV0pCiAgICAgICAgICAgICAgICAgICAgY2wtZGVjbGFyYXRpb25z IGJvZHkpKSkKICAgKGxldCAoKGJpbmRzICgpKSAobmV3ZW52IG1hY3JvZXhwYW5kLWFsbC1l bnZpcm9ubWVudCkpCiAgICAgKGRvbGlzdCAoYmluZGluZyBiaW5kaW5ncykKCg== --------------suOS7Nl2vk8V2oChVXydHSNM--