* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' @ 2022-06-14 21:36 Drew Adams 2022-06-15 9:03 ` Robert Pluim 0 siblings, 1 reply; 6+ messages in thread From: Drew Adams @ 2022-06-14 21:36 UTC (permalink / raw) To: 55984 Please consider mentioning in the doc string that the command prompts for the file name and (then for) the modes. The doc currently says how the modes are read, but it doesn't say that the command reads the file name. In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.19044 Configured using: `configure --without-dbus --host=x86_64-w64-mingw32 --without-compress-install 'CFLAGS=-O2 -static -g3'' ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' 2022-06-14 21:36 bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' Drew Adams @ 2022-06-15 9:03 ` Robert Pluim 2022-06-15 12:19 ` Lars Ingebrigtsen 2022-06-15 13:08 ` Eli Zaretskii 0 siblings, 2 replies; 6+ messages in thread From: Robert Pluim @ 2022-06-15 9:03 UTC (permalink / raw) To: Drew Adams; +Cc: 55984 >>>>> On Tue, 14 Jun 2022 21:36:37 +0000, Drew Adams <drew.adams@oracle.com> said: Drew> Please consider mentioning in the doc string that the command prompts Drew> for the file name and (then for) the modes. The doc currently says how Drew> the modes are read, but it doesn't say that the command reads the file Drew> name. Passive voice as well. How about the following for emacs-28 diff --git a/src/fileio.c b/src/fileio.c index 7d392e0de7..a240216dea 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3, Only the 12 low bits of MODE are used. If optional FLAG is `nofollow', do not follow FILENAME if it is a symbolic link. -Interactively, mode bits are read by `read-file-modes', which accepts -symbolic notation, like the `chmod' command from GNU Coreutils. */) +Interactively, prompts for FILENAME, and reads MODE with +`read-file-modes', which accepts symbolic notation, like the `chmod' +command from GNU Coreutils. */) (Lisp_Object filename, Lisp_Object mode, Lisp_Object flag) { CHECK_FIXNUM (mode); Robert -- ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' 2022-06-15 9:03 ` Robert Pluim @ 2022-06-15 12:19 ` Lars Ingebrigtsen 2022-06-15 12:32 ` Robert Pluim 2022-06-15 13:08 ` Eli Zaretskii 1 sibling, 1 reply; 6+ messages in thread From: Lars Ingebrigtsen @ 2022-06-15 12:19 UTC (permalink / raw) To: Robert Pluim; +Cc: 55984, Drew Adams Robert Pluim <rpluim@gmail.com> writes: > Passive voice as well. How about the following for emacs-28 Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' 2022-06-15 12:19 ` Lars Ingebrigtsen @ 2022-06-15 12:32 ` Robert Pluim 0 siblings, 0 replies; 6+ messages in thread From: Robert Pluim @ 2022-06-15 12:32 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: 55984, Drew Adams tags 55984 fixed close 55984 28.2 quit >>>>> On Wed, 15 Jun 2022 14:19:59 +0200, Lars Ingebrigtsen <larsi@gnus.org> said: Lars> Robert Pluim <rpluim@gmail.com> writes: >> Passive voice as well. How about the following for emacs-28 Lars> Looks good to me. Closing. Committed as 32cff740e2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' 2022-06-15 9:03 ` Robert Pluim 2022-06-15 12:19 ` Lars Ingebrigtsen @ 2022-06-15 13:08 ` Eli Zaretskii 2022-06-15 13:19 ` Robert Pluim 1 sibling, 1 reply; 6+ messages in thread From: Eli Zaretskii @ 2022-06-15 13:08 UTC (permalink / raw) To: Robert Pluim; +Cc: 55984, drew.adams > Cc: 55984@debbugs.gnu.org > From: Robert Pluim <rpluim@gmail.com> > Date: Wed, 15 Jun 2022 11:03:32 +0200 > > Passive voice as well. How about the following for emacs-28 > > > diff --git a/src/fileio.c b/src/fileio.c > index 7d392e0de7..a240216dea 100644 > --- a/src/fileio.c > +++ b/src/fileio.c > @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3, > Only the 12 low bits of MODE are used. If optional FLAG is `nofollow', > do not follow FILENAME if it is a symbolic link. > > -Interactively, mode bits are read by `read-file-modes', which accepts > -symbolic notation, like the `chmod' command from GNU Coreutils. */) > +Interactively, prompts for FILENAME, and reads MODE with > +`read-file-modes', which accepts symbolic notation, like the `chmod' > +command from GNU Coreutils. */) "prompt" and "read", please, to be consistent with our preferred style. Otherwise OK, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' 2022-06-15 13:08 ` Eli Zaretskii @ 2022-06-15 13:19 ` Robert Pluim 0 siblings, 0 replies; 6+ messages in thread From: Robert Pluim @ 2022-06-15 13:19 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 55984, drew.adams >>>>> On Wed, 15 Jun 2022 16:08:38 +0300, Eli Zaretskii <eliz@gnu.org> said: >> Cc: 55984@debbugs.gnu.org >> From: Robert Pluim <rpluim@gmail.com> >> Date: Wed, 15 Jun 2022 11:03:32 +0200 >> >> Passive voice as well. How about the following for emacs-28 >> >> >> diff --git a/src/fileio.c b/src/fileio.c >> index 7d392e0de7..a240216dea 100644 >> --- a/src/fileio.c >> +++ b/src/fileio.c >> @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3, >> Only the 12 low bits of MODE are used. If optional FLAG is `nofollow', >> do not follow FILENAME if it is a symbolic link. >> >> -Interactively, mode bits are read by `read-file-modes', which accepts >> -symbolic notation, like the `chmod' command from GNU Coreutils. */) >> +Interactively, prompts for FILENAME, and reads MODE with >> +`read-file-modes', which accepts symbolic notation, like the `chmod' >> +command from GNU Coreutils. */) Eli> "prompt" and "read", please, to be consistent with our preferred Eli> style. I said "prompts" because itʼs describing what it does, but OK, fixed. Robert -- ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-15 13:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-14 21:36 bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' Drew Adams 2022-06-15 9:03 ` Robert Pluim 2022-06-15 12:19 ` Lars Ingebrigtsen 2022-06-15 12:32 ` Robert Pluim 2022-06-15 13:08 ` Eli Zaretskii 2022-06-15 13:19 ` Robert Pluim
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).