From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' Date: Wed, 15 Jun 2022 16:08:38 +0300 Message-ID: <837d5irs4p.fsf@gnu.org> References: <87r13qz4bf.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55984@debbugs.gnu.org, drew.adams@oracle.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 15:09:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Sls-0006bg-HP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 15:09:20 +0200 Original-Received: from localhost ([::1]:35748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Slr-0007Nv-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 09:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1Sla-0007NV-4g for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 09:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1SlZ-0007RV-SC for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 09:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1SlZ-0004xS-LY for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 09:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 13:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 55984-submit@debbugs.gnu.org id=B55984.165529853719049 (code B ref 55984); Wed, 15 Jun 2022 13:09:01 +0000 Original-Received: (at 55984) by debbugs.gnu.org; 15 Jun 2022 13:08:57 +0000 Original-Received: from localhost ([127.0.0.1]:36912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1SlV-0004xB-K3 for submit@debbugs.gnu.org; Wed, 15 Jun 2022 09:08:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1SlT-0004wu-1b for 55984@debbugs.gnu.org; Wed, 15 Jun 2022 09:08:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1SlM-0007QI-S1; Wed, 15 Jun 2022 09:08:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h7/5dw317qxqHa3YZds8XaTSaBF0ICeHSr1Cj4FIBt0=; b=hW9NJR4tbO20 zqQPe1a9iznCKjeDpMktqiq5j7yLJmC8wF3mkayIiWS/+nZ425qhhLR2cZQaGA0j7KMEJaTPFr8r4 +gtXzlPxCkGX882qqhd+c9THETi3yp16VW3LhvQGjPo3+aG2hfZMP68QPaZl8IaGd643//6VGduKx vhjbKoHXgTVjd/JV0vWKw4BNGkagftKtwHxTxNAoHOe8o7sVTbg77M+QwL4rYsAjpioW1mt+ikWKi uI2/76awjFhbK9N5s4767qOlQ1fw5WMyvE+XexUEncPig4NJO7eL1u6TDxXRCsbyK7M3gsO6XFW+7 ERifGfo8tUvMdGXAkxOQtQ==; Original-Received: from [87.69.77.57] (port=2161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1SlL-000516-MF; Wed, 15 Jun 2022 09:08:48 -0400 In-Reply-To: <87r13qz4bf.fsf@gmail.com> (message from Robert Pluim on Wed, 15 Jun 2022 11:03:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234579 Archived-At: > Cc: 55984@debbugs.gnu.org > From: Robert Pluim > Date: Wed, 15 Jun 2022 11:03:32 +0200 > > Passive voice as well. How about the following for emacs-28 > > > diff --git a/src/fileio.c b/src/fileio.c > index 7d392e0de7..a240216dea 100644 > --- a/src/fileio.c > +++ b/src/fileio.c > @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3, > Only the 12 low bits of MODE are used. If optional FLAG is `nofollow', > do not follow FILENAME if it is a symbolic link. > > -Interactively, mode bits are read by `read-file-modes', which accepts > -symbolic notation, like the `chmod' command from GNU Coreutils. */) > +Interactively, prompts for FILENAME, and reads MODE with > +`read-file-modes', which accepts symbolic notation, like the `chmod' > +command from GNU Coreutils. */) "prompt" and "read", please, to be consistent with our preferred style. Otherwise OK, thanks.