From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' Date: Wed, 15 Jun 2022 11:03:32 +0200 Message-ID: <87r13qz4bf.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55984@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 11:17:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1P98-0003AA-J1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 11:17:06 +0200 Original-Received: from localhost ([::1]:53798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1P97-0007CG-Md for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 05:17:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1OwU-0002Gt-ME for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 05:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1OwU-00041z-DS for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 05:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1OwU-0006TS-3y for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 05:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 09:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55984 X-GNU-PR-Package: emacs Original-Received: via spool by 55984-submit@debbugs.gnu.org id=B55984.165528382524863 (code B ref 55984); Wed, 15 Jun 2022 09:04:02 +0000 Original-Received: (at 55984) by debbugs.gnu.org; 15 Jun 2022 09:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:36481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1OwD-0006Sx-8d for submit@debbugs.gnu.org; Wed, 15 Jun 2022 05:03:45 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:41899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Ow8-0006Sf-Lt for 55984@debbugs.gnu.org; Wed, 15 Jun 2022 05:03:44 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id k19so14413514wrd.8 for <55984@debbugs.gnu.org>; Wed, 15 Jun 2022 02:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=o0Gx3nDkKgnctC/PuCIGaFhvrpeqQYWUIPdHMhzUCnI=; b=etWEqJGExrMPi2X5PKC20bWr3vr9rWF31db6YzXnzFTOZsa1ZYNz6BIuCL3dDWCep7 L01tdSoSEM8DGnGtkfRSCZkZ+Cs0XxRKSAITIiry4k2HQmtbN8W/36oSE8SShwJ7VFnB AuqT3u+puWumedojbbluT2CJjIVqSQZGaecwwuEpL+eG3mVSmGHp2HE2HsthSwizmEa0 3CbcVKSvdEEOmaLb3/4PYjLtYorHGoVyU667xjNhnWrqdrhFPVAjGp0kbOBcArGuXV7Y +4y6aCS+mcCWwKsPlwJ+LDjGyajo9ik32PHIgQUA4kf3fPiADz+i/Ly9w0DdPqDEaNfN 9kbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=o0Gx3nDkKgnctC/PuCIGaFhvrpeqQYWUIPdHMhzUCnI=; b=kmQzMeUEkC8oOtBVGchPtlLsojE5gmKmLko5HeDujTWIgiB3GWb1sXSfaVSivMhsLF WDbJNOyq5fBbM1kaDx9GbL+5/b7z4jxuAOG5pKOkV3+Pt30DBRmqdQ24/qgPW68hIuTB DxGtPSKIsseIyTr5QLUimCLDJxVrVu4/P8WjfFREFq1ImDKu21ric1G/XfMum/7bvAdx SclYh0xNs/Pj0lV92dH9tYyU/DBa0/069WXDBp0AsnTDxwfmYNOpEECWSLnrFjUBhkGo qerPULUyBwm/y/pO1LoD6sojsZnc3UBAApVlS1YtucAjhNMCtQLfRxjKCQ07qloir5CP I1WA== X-Gm-Message-State: AJIora/cX5qR4Be7guhGX5i9n3bCOpuGlgFpZosR1lRwwz35vsAnItOE Y9owMhMCm3NuLW4qfOMZO/BbY3Ke/es= X-Google-Smtp-Source: AGRyM1uSr9+GikCgcx/y8D2vynjIGnlUysuacA1+Ntw5GLTsU8clz3F+vW+PW+3OetH2+7pLw2fj7w== X-Received: by 2002:a5d:638b:0:b0:218:54a2:71cf with SMTP id p11-20020a5d638b000000b0021854a271cfmr8791209wru.491.1655283814289; Wed, 15 Jun 2022 02:03:34 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:d98:f501:96ca:7200]) by smtp.gmail.com with ESMTPSA id g13-20020adffc8d000000b002102f2fac37sm16276297wrr.51.2022.06.15.02.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 02:03:33 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Tue, 14 Jun 2022 21:36:37 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234562 Archived-At: >>>>> On Tue, 14 Jun 2022 21:36:37 +0000, Drew Adams said: Drew> Please consider mentioning in the doc string that the command prompts Drew> for the file name and (then for) the modes. The doc currently says how Drew> the modes are read, but it doesn't say that the command reads the file Drew> name. Passive voice as well. How about the following for emacs-28 diff --git a/src/fileio.c b/src/fileio.c index 7d392e0de7..a240216dea 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3, Only the 12 low bits of MODE are used. If optional FLAG is `nofollow', do not follow FILENAME if it is a symbolic link. -Interactively, mode bits are read by `read-file-modes', which accepts -symbolic notation, like the `chmod' command from GNU Coreutils. */) +Interactively, prompts for FILENAME, and reads MODE with +`read-file-modes', which accepts symbolic notation, like the `chmod' +command from GNU Coreutils. */) (Lisp_Object filename, Lisp_Object mode, Lisp_Object flag) { CHECK_FIXNUM (mode); Robert --