* bug#51605: Fwd: [PATCH] Update themes to support mode-line [not found] <CAO48Bk-egwN7eEoCyhcB491VzQ8QGx_oLRubZgC-0ULgDfqpAQ@mail.gmail.com> @ 2021-11-05 7:27 ` Stefan Kangas 2021-11-05 23:24 ` Lars Ingebrigtsen ` (2 more replies) 0 siblings, 3 replies; 24+ messages in thread From: Stefan Kangas @ 2021-11-05 7:27 UTC (permalink / raw) To: 51605; +Cc: Pedro Andres Aranda Gutierrez [-- Attachment #1: Type: text/plain, Size: 488 bytes --] I'm forwarding this patch to the bug tracker, that AFAICT was never installed or followed up on. The first patch saw some discussion here: https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00993.html -------------------- Start of forwarded message -------------------- From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> Date: Fri, 18 Dec 2020 08:58:34 +0100 Subject: PATCH: update themes to support mode-line (no bold in line-number-current-line) To: emacs-devel@gnu.org [-- Attachment #2: Type: text/plain, Size: 67 bytes --] -------------------- End of forwarded message -------------------- [-- Attachment #3: Type: text/html, Size: 837 bytes --] [-- Attachment #4: line-number.diff --] [-- Type: text/x-patch, Size: 10919 bytes --] diff --git a/etc/themes/adwaita-theme.el b/etc/themes/adwaita-theme.el index 67a3b11763..6147700e3c 100644 --- a/etc/themes/adwaita-theme.el +++ b/etc/themes/adwaita-theme.el @@ -97,6 +97,13 @@ adwaita `(gnus-cite-2 ((,class (:foreground "#0084C8")))) `(diff-added ((,class (:bold t :foreground "#4E9A06")))) - `(diff-removed ((,class (:bold t :foreground "#F5666D")))))) + `(diff-removed ((,class (:bold t :foreground "#F5666D"))))) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'adwaita + `(line-number ((,class (:inherit fringe :foreground "dark gray")))) + `(line-number-current-line ((,class (:inherit line-number :foreground "black")))))) + ) ;;; adwaita-theme.el ends here diff --git a/etc/themes/deeper-blue-theme.el b/etc/themes/deeper-blue-theme.el index 2557918ed7..df87867290 100644 --- a/etc/themes/deeper-blue-theme.el +++ b/etc/themes/deeper-blue-theme.el @@ -105,7 +105,14 @@ deeper-blue `(show-paren-match-face ((,class (:background "dodgerblue1" :foreground "white")))) `(show-paren-mismatch-face ((,class (:background "red1" :foreground "white")))) `(success ((,class (:foreground "SeaGreen2")))) - `(warning ((,class (:foreground "Yellow")))))) + `(warning ((,class (:foreground "Yellow"))))) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'deeper-blue + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "DeepSkyBlue1")))))) + ) (provide-theme 'deeper-blue) diff --git a/etc/themes/dichromacy-theme.el b/etc/themes/dichromacy-theme.el index 89b5a4e452..b57c3efdd9 100644 --- a/etc/themes/dichromacy-theme.el +++ b/etc/themes/dichromacy-theme.el @@ -109,11 +109,17 @@ dichromacy `(message-header-to ((,class (:weight bold :foreground ,blue)))) `(message-cited-text ((,class (:slant italic :foreground ,bluegreen)))) `(message-separator ((,class (:weight bold :foreground ,redpurple)))) - ;; Flyspell - `(flyspell-duplicate ((,class (:weight unspecified :foreground unspecified + ;; Flyspell + `(flyspell-duplicate ((,class (:weight unspecified :foreground unspecified :slant unspecified :underline ,orange)))) `(flyspell-incorrect ((,class (:weight unspecified :foreground unspecified - :slant unspecified :underline ,redpurple))))) + :slant unspecified :underline ,redpurple))))) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'dichromacy + `(line-number ((,class (:inherit fringe :foreground ,bluegreen)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "black")))))) (custom-theme-set-variables 'dichromacy diff --git a/etc/themes/leuven-theme.el b/etc/themes/leuven-theme.el index f104c845ff..bebddba82f 100644 --- a/etc/themes/leuven-theme.el +++ b/etc/themes/leuven-theme.el @@ -1027,8 +1027,14 @@ leuven ;; `(ztreep-header-face ((,class ()))) ;; `(ztreep-leaf-face ((,class ()))) ;; `(ztreep-node-face ((,class ()))) - - )) + ) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'leuven + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "black")))))) + ) (custom-theme-set-variables 'leuven diff --git a/etc/themes/light-blue-theme.el b/etc/themes/light-blue-theme.el index c6d3c92bce..017555d57f 100644 --- a/etc/themes/light-blue-theme.el +++ b/etc/themes/light-blue-theme.el @@ -57,7 +57,14 @@ light-blue `(font-lock-string-face ((,class (:foreground "Magenta4")))) `(font-lock-warning-face ((,class (:foreground "orange red" :weight bold)))) ;; Compilation faces - `(next-error ((,class (:inherit region :background "SkyBlue")))))) + `(next-error ((,class (:inherit region :background "SkyBlue"))))) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'light-blue + `(line-number ((,class (:inherit fringe :foreground "dim gray")))) + `(line-number-current-line ((,class (:inherit line-number :foreground "black")))))) + ) (provide-theme 'light-blue) diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el index 195d40d7af..ea96061152 100644 --- a/etc/themes/manoj-dark-theme.el +++ b/etc/themes/manoj-dark-theme.el @@ -698,6 +698,12 @@ manoj-dark '(woman-bold-face ((t (:bold t)))) '(woman-italic-face ((t (:foreground "beige")))) '(woman-unknown-face ((t (:foreground "LightSalmon"))))) +;; emacs >= 26.1 +(when (>= emacs-major-version 26) + (custom-theme-set-faces + 'manoj-dark + '(line-number ((t (:inherit fringe :foreground "dark gray")))) + '(line-number-current-line ((t (:inherit line-number :foreground "white")))))) (provide-theme 'manoj-dark) diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el index ff9af0c744..18a2f4ddc1 100644 --- a/etc/themes/misterioso-theme.el +++ b/etc/themes/misterioso-theme.el @@ -101,7 +101,15 @@ misterioso `(message-header-subject ((,class (:foreground "#dbdb95")))) `(message-header-to ((,class (:foreground "#00ede1")))) `(message-cited-text ((,class (:foreground "#74af68")))) - `(message-separator ((,class (:foreground "#23d7d7")))))) + `(message-separator ((,class (:foreground "#23d7d7"))))) + ;; emacs >= 26.1 + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'misterioso + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "white")))) + )) + ) (custom-theme-set-variables 'misterioso diff --git a/etc/themes/tango-dark-theme.el b/etc/themes/tango-dark-theme.el index cf1a98bfee..da27108966 100644 --- a/etc/themes/tango-dark-theme.el +++ b/etc/themes/tango-dark-theme.el @@ -164,6 +164,13 @@ tango-dark `(semantic-tag-boundary-face ((,class (:overline ,blue-1)))) `(semantic-unmatched-syntax-face ((,class (:underline ,red-1))))) + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'tango-dark + `(line-number ((,class (:inherit fringe :foreground ,cham-2)))) + `(line-number-current-line ((,class (:inherit line-number :foreground ,alum-1)))) + )) + (custom-theme-set-variables 'tango-dark `(ansi-color-names-vector [,alum-7 ,red-0 ,cham-0 ,butter-1 diff --git a/etc/themes/tango-theme.el b/etc/themes/tango-theme.el index 6166657c14..5adedd499e 100644 --- a/etc/themes/tango-theme.el +++ b/etc/themes/tango-theme.el @@ -146,6 +146,12 @@ tango ((,class (:underline ,orange-3)))) `(semantic-tag-boundary-face ((,class (:overline ,blue-1)))) `(semantic-unmatched-syntax-face ((,class (:underline ,red-1))))) + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'tango + `(line-number ((,class (:inherit fringe :foreground ,alum-5)))) + `(line-number-current-line ((,class (:inherit line-number :foreground ,alum-6)))) + )) (custom-theme-set-variables 'tango diff --git a/etc/themes/tsdh-dark-theme.el b/etc/themes/tsdh-dark-theme.el index f3c9ced5b0..12fbf862e6 100644 --- a/etc/themes/tsdh-dark-theme.el +++ b/etc/themes/tsdh-dark-theme.el @@ -142,6 +142,13 @@ tsdh-dark '(widget-field ((t (:box (:line-width 2 :color "grey75" :style pressed-button))))) '(window-number-face ((t (:foreground "red" :weight bold))))) +(when (>= emacs-major-version 26) + (custom-theme-set-faces + 'tsdh-dark + '(line-number ((t (:inherit fringe :foreground "grey75")))) + '(line-number-current-line ((t (:inherit line-number :foreground "white")))) + ) + ) (provide-theme 'tsdh-dark) ;;; tsdh-dark-theme.el ends here diff --git a/etc/themes/tsdh-light-theme.el b/etc/themes/tsdh-light-theme.el index 46443edfd4..3f725457b0 100644 --- a/etc/themes/tsdh-light-theme.el +++ b/etc/themes/tsdh-light-theme.el @@ -104,6 +104,14 @@ tsdh-light '(show-paren-mismatch ((t (:background "deep pink" :weight bold)))) '(window-number-face ((t (:foreground "red" :weight bold))))) +(when (>= emacs-major-version 26) + (custom-theme-set-faces + 'tsdh-light + '(line-number ((t (:inherit fringe :foreground "dark grey")))) + '(line-number-current-line ((t (:inherit line-number :foreground "black")))) + ) + ) + (provide-theme 'tsdh-light) ;;; tsdh-light-theme.el ends here diff --git a/etc/themes/wheatgrass-theme.el b/etc/themes/wheatgrass-theme.el index f1abdb3895..e7b14b8f5f 100644 --- a/etc/themes/wheatgrass-theme.el +++ b/etc/themes/wheatgrass-theme.el @@ -80,7 +80,14 @@ wheatgrass `(realgud-bp-line-disabled-face ((,class (:underline "salmon")))) `(realgud-file-name ((,class (:foreground "dark khaki")))) `(realgud-line-number ((,class (:foreground "dark cyan")))) - `(realgud-backtrace-number ((,class (:foreground "dark cyan" :weight bold)))))) + `(realgud-backtrace-number ((,class (:foreground "dark cyan" :weight bold))))) + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'wheatgrass + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "white")))) + )) + ) (provide-theme 'wheatgrass) diff --git a/etc/themes/whiteboard-theme.el b/etc/themes/whiteboard-theme.el index ee42e4f215..debabb9099 100644 --- a/etc/themes/whiteboard-theme.el +++ b/etc/themes/whiteboard-theme.el @@ -95,7 +95,15 @@ whiteboard `(region ((,class (:background "SkyBlue1")))) `(show-paren-match-face ((,class (:background "dodgerblue1" :foreground "white")))) `(show-paren-mismatch-face ((,class (:background "red1" :foreground "white")))) - `(warning ((,class (:foreground "Yellow4")))))) + `(warning ((,class (:foreground "Yellow4"))))) + + (when (>= emacs-major-version 26) + (custom-theme-set-faces + 'whiteboard + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "DodgerBlue2")))) + )) + ) (provide-theme 'whiteboard) diff --git a/etc/themes/wombat-theme.el b/etc/themes/wombat-theme.el index 4df5f5a3f1..6f0f82101f 100644 --- a/etc/themes/wombat-theme.el +++ b/etc/themes/wombat-theme.el @@ -93,7 +93,13 @@ wombat `(message-header-subject ((,class (:foreground "#cae682")))) `(message-header-to ((,class (:foreground "#cae682")))) `(message-cited-text ((,class (:foreground "#99968b")))) - `(message-separator ((,class (:foreground "#e5786d" :weight bold)))))) + `(message-separator ((,class (:foreground "#e5786d" :weight bold))))) + (when (> emacs-major-version 26) + (custom-theme-set-faces + 'wombat + `(line-number ((,class (:inherit fringe)))) + `(line-number-current-line ((,class (:inherit line-number :foreground "#8ac6f2")))))) + ) (custom-theme-set-variables 'wombat ^ permalink raw reply related [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-05 7:27 ` bug#51605: Fwd: [PATCH] Update themes to support mode-line Stefan Kangas @ 2021-11-05 23:24 ` Lars Ingebrigtsen 2021-11-05 23:54 ` Stefan Kangas 2021-12-05 18:05 ` Stefan Kangas 2022-09-10 4:49 ` Lars Ingebrigtsen 2 siblings, 1 reply; 24+ messages in thread From: Lars Ingebrigtsen @ 2021-11-05 23:24 UTC (permalink / raw) To: Stefan Kangas; +Cc: Pedro Andres Aranda Gutierrez, 51605 Stefan Kangas <stefan@marxist.se> writes: > I'm forwarding this patch to the bug tracker, that AFAICT was never > installed or followed up on. The first patch saw some discussion here: > > https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00993.html Is this the final version of the patch? line-number-current-line doesn't seem to have `bold' here... > + ;; emacs >= 26.1 > + (when (>= emacs-major-version 26) > + (custom-theme-set-faces > + 'adwaita > + `(line-number ((,class (:inherit fringe :foreground "dark gray")))) > + `(line-number-current-line ((,class (:inherit line-number :foreground "black")))))) Are these version checks necessary? If we're installing a theme in Emacs 29, then it's, like, in Emacs 29. 😀 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-05 23:24 ` Lars Ingebrigtsen @ 2021-11-05 23:54 ` Stefan Kangas 2021-11-06 0:17 ` Lars Ingebrigtsen 0 siblings, 1 reply; 24+ messages in thread From: Stefan Kangas @ 2021-11-05 23:54 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: Pedro Andres Aranda Gutierrez, 51605 Lars Ingebrigtsen <larsi@gnus.org> writes: >> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00993.html > > Is this the final version of the patch? line-number-current-line > doesn't seem to have `bold' here... AFAICT, Pedro was asked to remove the bold in the above discussion, and this is the updated patch that does that. > Are these version checks necessary? If we're installing a theme in > Emacs 29, then it's, like, in Emacs 29. 😀 I don't think they are necessary except for in the leueven and modus themes (as they are distributed externally). ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-05 23:54 ` Stefan Kangas @ 2021-11-06 0:17 ` Lars Ingebrigtsen 2021-11-06 0:43 ` Stefan Kangas 0 siblings, 1 reply; 24+ messages in thread From: Lars Ingebrigtsen @ 2021-11-06 0:17 UTC (permalink / raw) To: Stefan Kangas; +Cc: Pedro Andres Aranda Gutierrez, 51605 Stefan Kangas <stefan@marxist.se> writes: > AFAICT, Pedro was asked to remove the bold in the above discussion, and > this is the updated patch that does that. Right. >> Are these version checks necessary? If we're installing a theme in >> Emacs 29, then it's, like, in Emacs 29. 😀 > > I don't think they are necessary except for in the leueven and modus > themes (as they are distributed externally). Perhaps those bits of the patch should go to the maintainers of those themes? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-06 0:17 ` Lars Ingebrigtsen @ 2021-11-06 0:43 ` Stefan Kangas 0 siblings, 0 replies; 24+ messages in thread From: Stefan Kangas @ 2021-11-06 0:43 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: Pedro Andres Aranda Gutierrez, 51605 Lars Ingebrigtsen <larsi@gnus.org> writes: > Perhaps those bits of the patch should go to the maintainers of those > themes? Yes, that makes sense. I see now that this only affects leuven, as the modus themes were not changed in the patch. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-05 7:27 ` bug#51605: Fwd: [PATCH] Update themes to support mode-line Stefan Kangas 2021-11-05 23:24 ` Lars Ingebrigtsen @ 2021-12-05 18:05 ` Stefan Kangas 2021-12-05 18:38 ` Eli Zaretskii 2022-09-10 4:49 ` Lars Ingebrigtsen 2 siblings, 1 reply; 24+ messages in thread From: Stefan Kangas @ 2021-12-05 18:05 UTC (permalink / raw) To: 51605; +Cc: Pedro Andres Aranda Gutierrez Stefan Kangas <stefan@marxist.se> writes: > I'm forwarding this patch to the bug tracker, that AFAICT was never > installed or followed up on. The first patch saw some discussion here: > > https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00993.html > > -------------------- Start of forwarded message -------------------- [snip] > a second attempt at including minimal line-number support in the > default Emacs themes. > > This has made me think that maybe the best place to make the > line-number-face inherit from fringe would be in the line-number > code... This might mean that we need an agreement that the fringe and > the line-number are things that are semantically similar or, at least, > different enough from the buffer. AFAICT, the point of this patch is essentially changing the line-number face to inherit the fringe face and line-number-current to have the default foreground (to make the current line more visible). I think this makes sense and looks good. I checked, and this seems to be what VSCode is doing too, so I don't think it's a controversial design choice. So I'd suggest installing the below diff, and then an adapted version of the proposed patch from Pedro Andres Aranda Gutierrez. Comments? diff --git a/lisp/faces.el b/lisp/faces.el index 9caba3a11b..16125950d1 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -2494,7 +2494,7 @@ trailing-whitespace ;; Definition stolen from linum.el. (defface line-number - '((t :inherit (shadow default))) + '((t :inherit (fringe shadow default))) "Face for displaying line numbers. This face is used when `display-line-numbers' is non-nil. @@ -2507,7 +2507,7 @@ line-number :group 'display-line-numbers) (defface line-number-current-line - '((t :inherit line-number)) + '((t :foreground "black" :inherit line-number)) "Face for displaying the current line number. This face is used when `display-line-numbers' is non-nil. ^ permalink raw reply related [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-05 18:05 ` Stefan Kangas @ 2021-12-05 18:38 ` Eli Zaretskii 2021-12-05 21:49 ` Stefan Kangas 0 siblings, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2021-12-05 18:38 UTC (permalink / raw) To: Stefan Kangas; +Cc: paaguti, 51605 > From: Stefan Kangas <stefan@marxist.se> > Date: Sun, 5 Dec 2021 19:05:36 +0100 > Cc: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > > AFAICT, the point of this patch is essentially changing the line-number > face to inherit the fringe face and line-number-current to have the > default foreground (to make the current line more visible). > > I think this makes sense and looks good. I checked, and this seems to > be what VSCode is doing too, so I don't think it's a controversial > design choice. > > So I'd suggest installing the below diff, and then an adapted version of > the proposed patch from Pedro Andres Aranda Gutierrez. Comments? I don't think we should change defaults of the faces because someone prefers to have them look differently. Faces can be easily customized, so people who don't like the defaults can have the faces they like very easily. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-05 18:38 ` Eli Zaretskii @ 2021-12-05 21:49 ` Stefan Kangas 2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez 2021-12-06 12:37 ` Eli Zaretskii 0 siblings, 2 replies; 24+ messages in thread From: Stefan Kangas @ 2021-12-05 21:49 UTC (permalink / raw) To: Eli Zaretskii; +Cc: paaguti, 51605 Eli Zaretskii <eliz@gnu.org> writes: > I don't think we should change defaults of the faces because someone > prefers to have them look differently. Faces can be easily > customized, so people who don't like the defaults can have the faces > they like very easily. Me neither. I think they should change if the new proposal is better. I'm personally not married to it as I only use display-line-numbers-mode occasionally (and can indeed customize it locally), but I think it's a good idea. In particular, I like the functional aspect of it: you are less likely to mix up the buffer text with the line number indication when scanning quickly, and it is easier to see which line you are on with a subtle color difference on the line number. Perhaps it could make sense to ask people on emacs-devel or maybe even do one of our never criticized 30 days experiment on master to give people a feel for the change before deciding anything. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-05 21:49 ` Stefan Kangas @ 2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez 2021-12-06 13:04 ` Eli Zaretskii 2021-12-06 12:37 ` Eli Zaretskii 1 sibling, 1 reply; 24+ messages in thread From: Pedro Andres Aranda Gutierrez @ 2021-12-06 6:21 UTC (permalink / raw) To: Stefan Kangas; +Cc: 51605 [-- Attachment #1: Type: text/plain, Size: 1486 bytes --] HI, > you are > less likely to mix up the buffer text with the line number indication > when scanning quickly, and it is easier to see which line you are on > with a subtle color difference on the line number. That's the intent. I need to review YAML and Python often and knowing exactly where the buffer starts is crucial. Best, /PA On Sun, 5 Dec 2021 at 22:49, Stefan Kangas <stefan@marxist.se> wrote: > Eli Zaretskii <eliz@gnu.org> writes: > > > I don't think we should change defaults of the faces because someone > > prefers to have them look differently. Faces can be easily > > customized, so people who don't like the defaults can have the faces > > they like very easily. > > Me neither. I think they should change if the new proposal is better. > I'm personally not married to it as I only use display-line-numbers-mode > occasionally (and can indeed customize it locally), but I think it's a > good idea. In particular, I like the functional aspect of it: you are > less likely to mix up the buffer text with the line number indication > when scanning quickly, and it is easier to see which line you are on > with a subtle color difference on the line number. > > Perhaps it could make sense to ask people on emacs-devel or maybe even > do one of our never criticized 30 days experiment on master to give > people a feel for the change before deciding anything. > -- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler [-- Attachment #2: Type: text/html, Size: 2154 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez @ 2021-12-06 13:04 ` Eli Zaretskii 0 siblings, 0 replies; 24+ messages in thread From: Eli Zaretskii @ 2021-12-06 13:04 UTC (permalink / raw) To: Pedro Andres Aranda Gutierrez; +Cc: stefan, 51605 > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > Date: Mon, 6 Dec 2021 07:21:13 +0100 > Cc: Eli Zaretskii <eliz@gnu.org>, 51605@debbugs.gnu.org > > > you are > > less likely to mix up the buffer text with the line number indication > > when scanning quickly, and it is easier to see which line you are on > > with a subtle color difference on the line number. > That's the intent. I need to review YAML and Python often and knowing exactly where the buffer starts is > crucial. But since this is about themes, why not make some theme(s) do that for you? Why do you want to impose this on everyone by default? ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-05 21:49 ` Stefan Kangas 2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez @ 2021-12-06 12:37 ` Eli Zaretskii 2021-12-06 13:25 ` Stefan Kangas 1 sibling, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2021-12-06 12:37 UTC (permalink / raw) To: Stefan Kangas; +Cc: paaguti, 51605 > From: Stefan Kangas <stefan@marxist.se> > Date: Sun, 5 Dec 2021 22:49:44 +0100 > Cc: 51605@debbugs.gnu.org, paaguti@gmail.com > > Eli Zaretskii <eliz@gnu.org> writes: > > > I don't think we should change defaults of the faces because someone > > prefers to have them look differently. Faces can be easily > > customized, so people who don't like the defaults can have the faces > > they like very easily. > > Me neither. I think they should change if the new proposal is better. I don't see why they would be better. They are just different. the current defaults are borrowed from linum.el, where they were used for ages by many people. It is okay for themes to modify that face: that's what themes are for, after all. But I see no reason to change the defaults. > Perhaps it could make sense to ask people on emacs-devel or maybe even > do one of our never criticized 30 days experiment on master to give > people a feel for the change before deciding anything. Doesn't seem worth the trouble. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 12:37 ` Eli Zaretskii @ 2021-12-06 13:25 ` Stefan Kangas 2021-12-06 13:54 ` Eli Zaretskii 0 siblings, 1 reply; 24+ messages in thread From: Stefan Kangas @ 2021-12-06 13:25 UTC (permalink / raw) To: Eli Zaretskii; +Cc: paaguti, 51605 Eli Zaretskii <eliz@gnu.org> writes: > I don't see why they would be better. They are just different. the > current defaults are borrowed from linum.el, where they were used for > ages by many people. I tried to explain why I think that in my previous email. In short: The proposal adds functionality that is not there OOTB, but that would be useful to provide OOTB. > It is okay for themes to modify that face: that's what themes are for, > after all. But I see no reason to change the defaults. The point is to set a precedent about the way we suggest Emacs should behave. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 13:25 ` Stefan Kangas @ 2021-12-06 13:54 ` Eli Zaretskii 2021-12-06 15:08 ` Stefan Kangas 0 siblings, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2021-12-06 13:54 UTC (permalink / raw) To: Stefan Kangas; +Cc: paaguti, 51605 > From: Stefan Kangas <stefan@marxist.se> > Date: Mon, 6 Dec 2021 14:25:39 +0100 > Cc: 51605@debbugs.gnu.org, paaguti@gmail.com > > Eli Zaretskii <eliz@gnu.org> writes: > > > I don't see why they would be better. They are just different. the > > current defaults are borrowed from linum.el, where they were used for > > ages by many people. > > I tried to explain why I think that in my previous email. In short: > The proposal adds functionality that is not there OOTB, but that would > be useful to provide OOTB. The line number is already separated from the buffer text, albeit not by its typeface. So I still think your proposal is merely different, not necessarily better. There are good reasons to have the line numbers in the same font as the default face. > The point is to set a precedent about the way we suggest Emacs should > behave. We _have_ set the precedent: this feature is available in its current form since Emacs 26. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 13:54 ` Eli Zaretskii @ 2021-12-06 15:08 ` Stefan Kangas 2021-12-06 16:38 ` Eli Zaretskii 2021-12-06 17:00 ` Juri Linkov 0 siblings, 2 replies; 24+ messages in thread From: Stefan Kangas @ 2021-12-06 15:08 UTC (permalink / raw) To: Eli Zaretskii; +Cc: paaguti, 51605 Eli Zaretskii <eliz@gnu.org> writes: > The line number is already separated from the buffer text, albeit not > by its typeface. So I still think your proposal is merely different, > not necessarily better. OK, that's fair enough. It is always going to be hard to agree fully on such details. > We _have_ set the precedent: this feature is available in its current > form since Emacs 26. Yes, of course. The idea is that we should provide a new one. I assume you wouldn't object if someone would raise the idea on emacs-devel to see what people there think? ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 15:08 ` Stefan Kangas @ 2021-12-06 16:38 ` Eli Zaretskii 2021-12-06 17:00 ` Juri Linkov 1 sibling, 0 replies; 24+ messages in thread From: Eli Zaretskii @ 2021-12-06 16:38 UTC (permalink / raw) To: Stefan Kangas; +Cc: paaguti, 51605 > From: Stefan Kangas <stefan@marxist.se> > Date: Mon, 6 Dec 2021 16:08:28 +0100 > Cc: 51605@debbugs.gnu.org, paaguti@gmail.com > > > We _have_ set the precedent: this feature is available in its current > > form since Emacs 26. > > Yes, of course. The idea is that we should provide a new one. I assume > you wouldn't object if someone would raise the idea on emacs-devel to > see what people there think? People don't need my permission to discuss stuff on the list, and it would be silly for me to object to any relevant discussion there. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 15:08 ` Stefan Kangas 2021-12-06 16:38 ` Eli Zaretskii @ 2021-12-06 17:00 ` Juri Linkov 2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez 1 sibling, 1 reply; 24+ messages in thread From: Juri Linkov @ 2021-12-06 17:00 UTC (permalink / raw) To: Stefan Kangas; +Cc: paaguti, 51605 >> The line number is already separated from the buffer text, albeit not >> by its typeface. So I still think your proposal is merely different, >> not necessarily better. > > OK, that's fair enough. It is always going to be hard to agree fully on > such details. Maybe if you posted a screenshot demonstrating the before/after improvement, it would be easier to agree if the positive effect is clearly visible. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-06 17:00 ` Juri Linkov @ 2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez 2021-12-07 8:18 ` Juri Linkov 2021-12-07 14:08 ` Eli Zaretskii 0 siblings, 2 replies; 24+ messages in thread From: Pedro Andres Aranda Gutierrez @ 2021-12-07 6:23 UTC (permalink / raw) To: Juri Linkov; +Cc: Stefan Kangas, 51605 [-- Attachment #1.1: Type: text/plain, Size: 493 bytes --] Hi Juri, you are right. An image is worth more than 1000 words ;-) Here you are. +/- the same are in the same file, with a theme I created with ThemeCreator (https://mswift42.github.io/themecreator/) My main point for having line-number as fringe is the space between the line number and the buffer. It's not just the practical side of it (i.e. identifying a space too much or missing), it's also something more philosophical: i.e. the the difference between buffer and the rest. Best, /PA [-- Attachment #1.2: Type: text/html, Size: 680 bytes --] [-- Attachment #2: emacs-linenum-as-default.png --] [-- Type: image/png, Size: 71819 bytes --] [-- Attachment #3: emacs-linenum-as-fringe.png --] [-- Type: image/png, Size: 77519 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez @ 2021-12-07 8:18 ` Juri Linkov 2021-12-07 14:08 ` Eli Zaretskii 1 sibling, 0 replies; 24+ messages in thread From: Juri Linkov @ 2021-12-07 8:18 UTC (permalink / raw) To: Pedro Andres Aranda Gutierrez; +Cc: Stefan Kangas, 51605 > Here you are. +/- the same are in the same file, with a theme I created > with ThemeCreator (https://mswift42.github.io/themecreator/) > My main point for having line-number as fringe is the space between the > line number and the buffer. It's not just the practical side of it (i.e. > identifying a space too much or missing), it's also something more > philosophical: i.e. the the difference between buffer and the rest. Thanks for the images, now it's clearly seen that the problem is that currently line numbers are displayed as part of the buffer text that is confusing - you can't edit these numbers. Whereas like fringes are displayed with a darker background, it makes sense to display line numbers with the same darker background to indicate these numbers are not part of the buffer text. So you patch fixes the real problem. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez 2021-12-07 8:18 ` Juri Linkov @ 2021-12-07 14:08 ` Eli Zaretskii 2021-12-08 6:45 ` Pedro Andres Aranda Gutierrez 1 sibling, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2021-12-07 14:08 UTC (permalink / raw) To: Pedro Andres Aranda Gutierrez; +Cc: stefan, 51605, juri > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > Date: Tue, 7 Dec 2021 07:23:11 +0100 > Cc: Stefan Kangas <stefan@marxist.se>, Eli Zaretskii <eliz@gnu.org>, 51605@debbugs.gnu.org > > you are right. An image is worth more than 1000 words ;-) > > Here you are. +/- the same are in the same file, with a theme I created with ThemeCreator > (https://mswift42.github.io/themecreator/) > My main point for having line-number as fringe is the space between the line number and the buffer. It's not > just the practical side of it (i.e. identifying a space too much or missing), it's also something more > philosophical: i.e. the the difference between buffer and the rest. What happens if there's display margin between the fringe and the line numbers? In any case, I don't understand why you insist on using the fringe as the basic face here. The line numbers have nothing to do with the fringe, and if you assume that the fringe's background will always be a pale, shadowy color, that assumption can easily be false. E.g., in my sessions the fringe has a very vivid color. It's a problematic dependency. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-07 14:08 ` Eli Zaretskii @ 2021-12-08 6:45 ` Pedro Andres Aranda Gutierrez 2021-12-08 13:19 ` Eli Zaretskii 0 siblings, 1 reply; 24+ messages in thread From: Pedro Andres Aranda Gutierrez @ 2021-12-08 6:45 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Stefan Kangas, 51605, Juri Linkov [-- Attachment #1: Type: text/plain, Size: 2234 bytes --] Hi Eli, point taken... if it isn't the fringe, then something else. I find it more problematic to have the same face for the buffer and line numbers. And it's from the conceptual point of view that line numbers aren't buffer and therefore should have a different face by default. OK, I use a couple of themes that happen to have a shadowy background for the fringe, but I could live with anything that makes this _conceptual_ difference visible. (Just my .2c worth of experience; when I edit/correct Python exercises from my students, this visual difference helps me detecting indentation errors much quicker; my student's experience: different line number and buffer faces help them editing and therefore adopting Emacs as their editor of choice for Python and from there they explore org-mode for their short papers and presentations and they become regular users in no time ;-) ) Best, /PA On Tue, 7 Dec 2021 at 15:08, Eli Zaretskii <eliz@gnu.org> wrote: > > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > > Date: Tue, 7 Dec 2021 07:23:11 +0100 > > Cc: Stefan Kangas <stefan@marxist.se>, Eli Zaretskii <eliz@gnu.org>, > 51605@debbugs.gnu.org > > > > you are right. An image is worth more than 1000 words ;-) > > > > Here you are. +/- the same are in the same file, with a theme I created > with ThemeCreator > > (https://mswift42.github.io/themecreator/) > > My main point for having line-number as fringe is the space between the > line number and the buffer. It's not > > just the practical side of it (i.e. identifying a space too much or > missing), it's also something more > > philosophical: i.e. the the difference between buffer and the rest. > > What happens if there's display margin between the fringe and the line > numbers? > > In any case, I don't understand why you insist on using the fringe as > the basic face here. The line numbers have nothing to do with the > fringe, and if you assume that the fringe's background will always be > a pale, shadowy color, that assumption can easily be false. E.g., in > my sessions the fringe has a very vivid color. It's a problematic > dependency. > -- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler [-- Attachment #2: Type: text/html, Size: 3250 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-08 6:45 ` Pedro Andres Aranda Gutierrez @ 2021-12-08 13:19 ` Eli Zaretskii 2021-12-09 7:39 ` Pedro Andres Aranda Gutierrez 0 siblings, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2021-12-08 13:19 UTC (permalink / raw) To: Pedro Andres Aranda Gutierrez; +Cc: stefan, 51605, juri > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > Date: Wed, 8 Dec 2021 07:45:57 +0100 > Cc: Juri Linkov <juri@linkov.net>, Stefan Kangas <stefan@marxist.se>, 51605@debbugs.gnu.org > > point taken... if it isn't the fringe, then something else. I find it more problematic to have the same face for the > buffer and line numbers. > And it's from the conceptual point of view that line numbers aren't buffer and therefore should have a different > face by default. > > OK, I use a couple of themes that happen to have a shadowy background for the fringe, but I could live with > anything that makes this _conceptual_ difference visible. I don't think I agree with this concept. For example, the stuff usually written into the display margins is also separate from the buffer text, but we still use the same 'default' face there. > (Just my .2c worth of experience; when I edit/correct Python exercises from my students, this visual > difference helps me detecting indentation errors much quicker; my student's experience: different line number > and buffer faces help them editing and therefore adopting Emacs as their editor of choice for Python and from > there they explore org-mode for their short papers and presentations and they become regular users in no > time ;-) ) No one argues that some situations and some personal preferences call for a distinct face for the line numbers. That's why we use a special face there, not the default face. That's not what the argument is about. It is about changing the defaults, and that must have reasons much more serious than just anecdotal evidence about this or that use case. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-08 13:19 ` Eli Zaretskii @ 2021-12-09 7:39 ` Pedro Andres Aranda Gutierrez 2021-12-09 14:03 ` Stefan Kangas 0 siblings, 1 reply; 24+ messages in thread From: Pedro Andres Aranda Gutierrez @ 2021-12-09 7:39 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Stefan Kangas, 51605, Juri Linkov [-- Attachment #1: Type: text/plain, Size: 2989 bytes --] Hi, >> OK, I use a couple of themes that happen to have a shadowy background for the fringe, but I could live with >> anything that makes this _conceptual_ difference visible. > I don't think I agree with this concept. For example, the stuff > usually written into the display margins is also separate from the > buffer text, but we still use the same 'default' face there. Wouldn't it be nice if Emacs made this conceptual difference clear by default. We can start with the line numbers and then continue with other stuff. I have started this because I got a couple PRs accepted by some theme editors who valued the concept, not just the visuals of it. BTW, no bad feelings here, but what is the real reason behind changing the modeline face to variable pitch? I have tested master recently and the feeling was really strange. (at least) I would like a conceptually sound Emacs and highlighting buffer vs. 'the rest' looks like a basic principle to me. But again, why not giving it a try as we have with the (IMvvHO weird) font for the modeline and bow to reactions of the community? Best, /PA On Wed, 8 Dec 2021 at 14:19, Eli Zaretskii <eliz@gnu.org> wrote: > > From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com> > > Date: Wed, 8 Dec 2021 07:45:57 +0100 > > Cc: Juri Linkov <juri@linkov.net>, Stefan Kangas <stefan@marxist.se>, > 51605@debbugs.gnu.org > > > > point taken... if it isn't the fringe, then something else. I find it > more problematic to have the same face for the > > buffer and line numbers. > > And it's from the conceptual point of view that line numbers aren't > buffer and therefore should have a different > > face by default. > > > > OK, I use a couple of themes that happen to have a shadowy background > for the fringe, but I could live with > > anything that makes this _conceptual_ difference visible. > > I don't think I agree with this concept. For example, the stuff > usually written into the display margins is also separate from the > buffer text, but we still use the same 'default' face there. > > > (Just my .2c worth of experience; when I edit/correct Python exercises > from my students, this visual > > difference helps me detecting indentation errors much quicker; my > student's experience: different line number > > and buffer faces help them editing and therefore adopting Emacs as their > editor of choice for Python and from > > there they explore org-mode for their short papers and presentations and > they become regular users in no > > time ;-) ) > > No one argues that some situations and some personal preferences call > for a distinct face for the line numbers. That's why we use a special > face there, not the default face. That's not what the argument is > about. It is about changing the defaults, and that must have reasons > much more serious than just anecdotal evidence about this or that use > case. > -- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler [-- Attachment #2: Type: text/html, Size: 4198 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-12-09 7:39 ` Pedro Andres Aranda Gutierrez @ 2021-12-09 14:03 ` Stefan Kangas 0 siblings, 0 replies; 24+ messages in thread From: Stefan Kangas @ 2021-12-09 14:03 UTC (permalink / raw) To: Pedro Andres Aranda Gutierrez; +Cc: 51605, Juri Linkov Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes: > BTW, no bad feelings here, but what is the real reason behind changing the modeline face to variable pitch? I have tested master recently and the feeling was really strange. I'd recommend reviewing the recent discussion on emacs-devel and providing your feedback there. ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#51605: Fwd: [PATCH] Update themes to support mode-line 2021-11-05 7:27 ` bug#51605: Fwd: [PATCH] Update themes to support mode-line Stefan Kangas 2021-11-05 23:24 ` Lars Ingebrigtsen 2021-12-05 18:05 ` Stefan Kangas @ 2022-09-10 4:49 ` Lars Ingebrigtsen 2 siblings, 0 replies; 24+ messages in thread From: Lars Ingebrigtsen @ 2022-09-10 4:49 UTC (permalink / raw) To: Stefan Kangas; +Cc: Pedro Andres Aranda Gutierrez, 51605 Stefan Kangas <stefan@marxist.se> writes: > I'm forwarding this patch to the bug tracker, that AFAICT was never > installed or followed up on. The first patch saw some discussion here: [...] > + `(line-number ((,class (:inherit fringe :foreground "dark gray")))) (I'm going through old bug reports that unfortunately weren't resolved at the time.) So the suggestion is to make the `display-line-numbers-mode' line numbers have the same background colour as the fringe instead of the buffer. I agree with Eli here -- I don't think this is clearly better than what we already have. So I don't think we should be doing this, and I'm therefore closing this bug report. ^ permalink raw reply [flat|nested] 24+ messages in thread
![[-- Attachment #2: emacs-linenum-as-default.png --] [-- Type: image/png, Size: 71819 bytes --]](../../CAO48Bk_v9fVmMmZkm05DiBjt+XvchQWNRifHOntOkODjhW-o5A@mail.gmail.com/2-emacs-linenum-as-default.png){kind=link}
![[-- Attachment #3: emacs-linenum-as-fringe.png --] [-- Type: image/png, Size: 77519 bytes --]](../../CAO48Bk_v9fVmMmZkm05DiBjt+XvchQWNRifHOntOkODjhW-o5A@mail.gmail.com/3-emacs-linenum-as-fringe.png){kind=link}
end of thread, other threads:[~2022-09-10 4:49 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAO48Bk-egwN7eEoCyhcB491VzQ8QGx_oLRubZgC-0ULgDfqpAQ@mail.gmail.com>
2021-11-05 7:27 ` bug#51605: Fwd: [PATCH] Update themes to support mode-line Stefan Kangas
2021-11-05 23:24 ` Lars Ingebrigtsen
2021-11-05 23:54 ` Stefan Kangas
2021-11-06 0:17 ` Lars Ingebrigtsen
2021-11-06 0:43 ` Stefan Kangas
2021-12-05 18:05 ` Stefan Kangas
2021-12-05 18:38 ` Eli Zaretskii
2021-12-05 21:49 ` Stefan Kangas
2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez
2021-12-06 13:04 ` Eli Zaretskii
2021-12-06 12:37 ` Eli Zaretskii
2021-12-06 13:25 ` Stefan Kangas
2021-12-06 13:54 ` Eli Zaretskii
2021-12-06 15:08 ` Stefan Kangas
2021-12-06 16:38 ` Eli Zaretskii
2021-12-06 17:00 ` Juri Linkov
2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez
2021-12-07 8:18 ` Juri Linkov
2021-12-07 14:08 ` Eli Zaretskii
2021-12-08 6:45 ` Pedro Andres Aranda Gutierrez
2021-12-08 13:19 ` Eli Zaretskii
2021-12-09 7:39 ` Pedro Andres Aranda Gutierrez
2021-12-09 14:03 ` Stefan Kangas
2022-09-10 4:49 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).