From: Stefan Kangas <stefan@marxist.se>
To: 51605@debbugs.gnu.org
Cc: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Subject: bug#51605: Fwd: [PATCH] Update themes to support mode-line
Date: Sun, 5 Dec 2021 19:05:36 +0100 [thread overview]
Message-ID: <CADwFkm=AXeyV7YDcca_-4ki+vmVOx++V-hEP2=EK3oKMh91ywQ@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmwhYU-Om-FWKMdPL4rqAYQhcTveYo8ukco+Ode3vPs5g@mail.gmail.com> (Stefan Kangas's message of "Fri, 5 Nov 2021 00:27:01 -0700")
Stefan Kangas <stefan@marxist.se> writes:
> I'm forwarding this patch to the bug tracker, that AFAICT was never
> installed or followed up on. The first patch saw some discussion here:
>
> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00993.html
>
> -------------------- Start of forwarded message --------------------
[snip]
> a second attempt at including minimal line-number support in the
> default Emacs themes.
>
> This has made me think that maybe the best place to make the
> line-number-face inherit from fringe would be in the line-number
> code... This might mean that we need an agreement that the fringe and
> the line-number are things that are semantically similar or, at least,
> different enough from the buffer.
AFAICT, the point of this patch is essentially changing the line-number
face to inherit the fringe face and line-number-current to have the
default foreground (to make the current line more visible).
I think this makes sense and looks good. I checked, and this seems to
be what VSCode is doing too, so I don't think it's a controversial
design choice.
So I'd suggest installing the below diff, and then an adapted version of
the proposed patch from Pedro Andres Aranda Gutierrez. Comments?
diff --git a/lisp/faces.el b/lisp/faces.el
index 9caba3a11b..16125950d1 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2494,7 +2494,7 @@ trailing-whitespace
;; Definition stolen from linum.el.
(defface line-number
- '((t :inherit (shadow default)))
+ '((t :inherit (fringe shadow default)))
"Face for displaying line numbers.
This face is used when `display-line-numbers' is non-nil.
@@ -2507,7 +2507,7 @@ line-number
:group 'display-line-numbers)
(defface line-number-current-line
- '((t :inherit line-number))
+ '((t :foreground "black" :inherit line-number))
"Face for displaying the current line number.
This face is used when `display-line-numbers' is non-nil.
next prev parent reply other threads:[~2021-12-05 18:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAO48Bk-egwN7eEoCyhcB491VzQ8QGx_oLRubZgC-0ULgDfqpAQ@mail.gmail.com>
2021-11-05 7:27 ` bug#51605: Fwd: [PATCH] Update themes to support mode-line Stefan Kangas
2021-11-05 23:24 ` Lars Ingebrigtsen
2021-11-05 23:54 ` Stefan Kangas
2021-11-06 0:17 ` Lars Ingebrigtsen
2021-11-06 0:43 ` Stefan Kangas
2021-12-05 18:05 ` Stefan Kangas [this message]
2021-12-05 18:38 ` Eli Zaretskii
2021-12-05 21:49 ` Stefan Kangas
2021-12-06 6:21 ` Pedro Andres Aranda Gutierrez
2021-12-06 13:04 ` Eli Zaretskii
2021-12-06 12:37 ` Eli Zaretskii
2021-12-06 13:25 ` Stefan Kangas
2021-12-06 13:54 ` Eli Zaretskii
2021-12-06 15:08 ` Stefan Kangas
2021-12-06 16:38 ` Eli Zaretskii
2021-12-06 17:00 ` Juri Linkov
2021-12-07 6:23 ` Pedro Andres Aranda Gutierrez
2021-12-07 8:18 ` Juri Linkov
2021-12-07 14:08 ` Eli Zaretskii
2021-12-08 6:45 ` Pedro Andres Aranda Gutierrez
2021-12-08 13:19 ` Eli Zaretskii
2021-12-09 7:39 ` Pedro Andres Aranda Gutierrez
2021-12-09 14:03 ` Stefan Kangas
2022-09-10 4:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=AXeyV7YDcca_-4ki+vmVOx++V-hEP2=EK3oKMh91ywQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=51605@debbugs.gnu.org \
--cc=paaguti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).