From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Date: Thu, 23 Feb 2023 11:59:29 +0000 Message-ID: References: <87pmffd8ya.fsf@gmail.com> <874jrjf276.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8269"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58141@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 12:58:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVAEw-00022w-2n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 12:58:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVAEd-0005LF-JQ; Thu, 23 Feb 2023 06:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVAEc-0005L6-0A for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 06:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVAEb-0004Bu-PG for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 06:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVAEb-0000El-KW for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 06:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58141 X-GNU-PR-Package: emacs Original-Received: via spool by 58141-submit@debbugs.gnu.org id=B58141.1677153474896 (code B ref 58141); Thu, 23 Feb 2023 11:58:01 +0000 Original-Received: (at 58141) by debbugs.gnu.org; 23 Feb 2023 11:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:33223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVAEU-0000EO-Ak for submit@debbugs.gnu.org; Thu, 23 Feb 2023 06:57:54 -0500 Original-Received: from mail-oa1-f45.google.com ([209.85.160.45]:40680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVAES-0000EA-Pj for 58141@debbugs.gnu.org; Thu, 23 Feb 2023 06:57:53 -0500 Original-Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-17235c8dab9so11152144fac.7 for <58141@debbugs.gnu.org>; Thu, 23 Feb 2023 03:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1o6XHGZ4Nvhl6yC77eAaydUISMh5uhaq6f/OtHHJelA=; b=np3i0R+vSy5eo/F2E0fDZMhSw5P3RDKuM9VINF+X+CjnDbAawvLqT395VADRDDIZh7 pLt/nAVrI49AW+MG55BLCc33jvEi4Zbm/JlMSAqH5TWElIWMVjqa0UzEmtkAL8qrMJfw K2lFDh9qY69r0gcPo8loovYtaIoRI9oCUM4y5uztMEqjLl1EppUfMvtUZi/qHI5IMPsU oZjh6PYERnnBy2YynSNg4tkys1ecg0kba70xqws60ym+pOwULgVijWH9VT0pESS1QVOq SVbeYPWweXC85OpXFeH3p9gXbxBWq8lgL7RF3ihMGWbmFugXDO6z+RD8KAhPWpy71YJf 38hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1o6XHGZ4Nvhl6yC77eAaydUISMh5uhaq6f/OtHHJelA=; b=gcLRGrDS8oGk5oscqsQF7caIkBuptS0SzWiJ89G/kXaroiYApkQE0EH9cR0eqT95jd jZTJFOGJfB61HR72NOZN3ic0mtcw90aiC3r8w2ACErTH1BxM5uZGrRxPlJ/CHUmRGUrK uUchveAaUZkbmqFYJQEDhiouvRzL2s7Mtcdb78PQnawQl0wR1ZM7/11an8is5D8BoumG 635Jb0mAQ5k1HmUJrBAObu/tPy3CLvwnpwh4XBoWXpbG293lb6J5OEvXnGTAzNTazfyN AcynOxV2Hi5VtdWSWCT6iQKkNm6GgsUevw3z+Feeq0aiEHIjQjCpVjZrKJYOLG6TNGNG gdbA== X-Gm-Message-State: AO0yUKURowq6VkdxqSYDvS3/NzaP4rzWUZDVPKOQUjI3EQ3po5YYNkyO fB0AmHPlisHVW7bbbhPouIDk/+WRmbhgeplgbNc= X-Google-Smtp-Source: AK7set9zrgN9L3Nw5KkXZFVSiEPbqosOaRd+PE0eW4d6r8p2M51TXz6SjzaKDNzqAFQjx9IgVAPix6zx54YEr3wo95c= X-Received: by 2002:a05:6870:41d0:b0:172:8adb:8e44 with SMTP id z16-20020a05687041d000b001728adb8e44mr179088oac.215.1677153467050; Thu, 23 Feb 2023 03:57:47 -0800 (PST) In-Reply-To: <874jrjf276.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256446 Archived-At: On Sat, Feb 18, 2023 at 3:00 PM Augusto Stoffel wrote= : > > This was a while back, but in any case this is my suggestion for this > face. I haven't seen eglot-diagnostic-tag-deprecated-face appear in > nature so I'm not sure how well it works. I'm not a fan of hardcoding colors in Eglot, since that needs themes to update for the new face. Supporting the optional underline is probably fine, though. Jo=C3=A3o