From: Carlos Pita <carlosjosepita@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 33959@debbugs.gnu.org
Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled
Date: Wed, 16 Oct 2019 17:35:42 -0300 [thread overview]
Message-ID: <CAELgYhfFTr70Mj_CYmFSDFDZKDOiM1a6g+1toQUxFU4jRsOFCw@mail.gmail.com> (raw)
In-Reply-To: <CAELgYhfYeMnnmse8rwAEtr3t1UqnOdDrhwHk4KJGJp7+ny3Tqg@mail.gmail.com>
Hi Noam, I don't want to be insistent (and I'm probably being) but it
won't take much time for someone to complaint about [1] because it
removed the `(not (string= "" output))` guard from the original code.
As it is now, it's certainly buggy. I know it would be desirable to
provide an unit test for [1] but this new commit I'm providing can't
harm (remember it's just an "around advice": `(unless (string= output
"") ... )`) and I believe my argument against the way the empty output
condition was checked before is sound and simple enough. Thanks and
sorry for the insistence.
---
[1] 7acc621e3 (Fix python-shell font-lock cleanup for unclosed quotes
(Bug#32390))
next prev parent reply other threads:[~2019-10-16 20:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 2:08 bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled Carlos Pita
2019-01-03 2:34 ` bug#33959: Carlos Pita
2019-01-03 4:40 ` bug#33959: Carlos Pita
2019-01-03 5:38 ` bug#33959: Carlos Pita
2019-04-05 2:36 ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-04-16 21:47 ` Carlos Pita
2019-04-16 22:04 ` Noam Postavsky
2019-04-16 22:08 ` Carlos Pita
2019-04-16 22:14 ` Carlos Pita
2019-04-16 23:01 ` Noam Postavsky
2019-04-16 23:51 ` Noam Postavsky
2019-05-11 3:51 ` Noam Postavsky
2019-04-05 2:55 ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc " Noam Postavsky
2019-04-16 20:42 ` Carlos Pita
2019-10-13 19:39 ` bug#33959: Carlos Pita
2019-10-13 19:44 ` bug#33959: Lars Ingebrigtsen
2019-10-13 19:51 ` bug#33959: Carlos Pita
2019-10-15 0:34 ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-10-15 0:52 ` Carlos Pita
2019-10-15 0:58 ` Carlos Pita
2019-10-16 20:35 ` Carlos Pita [this message]
2019-10-21 20:56 ` Carlos Pita
2019-10-23 0:18 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAELgYhfFTr70Mj_CYmFSDFDZKDOiM1a6g+1toQUxFU4jRsOFCw@mail.gmail.com \
--to=carlosjosepita@gmail.com \
--cc=33959@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).