unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Carlos Pita <carlosjosepita@gmail.com>
To: 33959@debbugs.gnu.org
Subject: bug#33959:
Date: Thu, 3 Jan 2019 01:40:00 -0300	[thread overview]
Message-ID: <CAELgYheP044D__P6BOBix17Zn40OHtjecV7Eg9FcNtynDPbfyQ@mail.gmail.com> (raw)
In-Reply-To: <CAELgYhctqzGA7ug9XupK=R6JkjEMuUzhh+ujdfRWgQYg0WR53w@mail.gmail.com>

Well, I think I was right both times but because the problem is more
complex than I thought at first.

When I was editing the font lock buffer itself, it was eldoc that was
adding an extra line.

But when I was editing the shell buffer line, it was company that was
adding those lines to the font lock buffer (probably because of a
weird effect of an empty menu or something invisibly opening and
adding content to the shell buffer). Btw, company is disabled in the
font lock buffer since the globalized mode is off for buffers whose
name starts with a whitespace:

(defun company-mode-on ()
  (when (and (not (or noninteractive (eq (aref (buffer-name) 0) ?\s)))
  ....

The first effect (eldoc) is simple to fix by just disabling eldoc in
the font lock buffer, but this is not even necessary since it requires
the user to directly edit the font lock buffer in order to trigger it,
and this is not a relevant use case.

For the second effect (company) I propose to delete from the beginning
of buffer each time instead of from the beginning of line, since the
font lock buffer won't contain multiline input in any case. Currently
after each change in the current line this is being done:

     (delete-region (line-beginning-position) (point-max))

but I see no reason to not call (erase-buffer) altogether.

Do you?





  reply	other threads:[~2019-01-03  4:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  2:08 bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled Carlos Pita
2019-01-03  2:34 ` bug#33959: Carlos Pita
2019-01-03  4:40   ` Carlos Pita [this message]
2019-01-03  5:38     ` bug#33959: Carlos Pita
2019-04-05  2:36       ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-04-16 21:47         ` Carlos Pita
2019-04-16 22:04           ` Noam Postavsky
2019-04-16 22:08             ` Carlos Pita
2019-04-16 22:14               ` Carlos Pita
2019-04-16 23:01                 ` Noam Postavsky
2019-04-16 23:51                   ` Noam Postavsky
2019-05-11  3:51                     ` Noam Postavsky
2019-04-05  2:55 ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc " Noam Postavsky
2019-04-16 20:42   ` Carlos Pita
2019-10-13 19:39 ` bug#33959: Carlos Pita
2019-10-13 19:44   ` bug#33959: Lars Ingebrigtsen
2019-10-13 19:51     ` bug#33959: Carlos Pita
2019-10-15  0:34   ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-10-15  0:52     ` Carlos Pita
2019-10-15  0:58       ` Carlos Pita
2019-10-16 20:35         ` Carlos Pita
2019-10-21 20:56           ` Carlos Pita
2019-10-23  0:18           ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAELgYheP044D__P6BOBix17Zn40OHtjecV7Eg9FcNtynDPbfyQ@mail.gmail.com \
    --to=carlosjosepita@gmail.com \
    --cc=33959@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).