unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Carlos Pita <carlosjosepita@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 33959@debbugs.gnu.org
Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled
Date: Tue, 16 Apr 2019 18:47:19 -0300	[thread overview]
Message-ID: <CAELgYheVNHGrNE2bJycwp8Re2sPnPzKbCOYsqZ8hMiSeVwPwxw@mail.gmail.com> (raw)
In-Reply-To: <87zhp5ch5n.fsf_-_@gmail.com>

Hi Noam,

> And my " *Python-font-lock*" looks like this:
>
>
>     1 + len('123') + 99 + len('aa')
>
>
>
>     1 + len(
>     1 + len('123'
>     1 + len('123') + 99 + len('aa')
>
> The behaviour seems rather inconsistent.  I think to solve this properly
> we need some deterministic tests which reproduce the problem.


The state of your " *Python-font-lock*" buffer is exactly what I mean.
The duplications you see are caused by spurious newlines added when
empty output is passed to the filter. There are two bad things there:
i) empty strings are transformed into new lines and 2) empty strings
are an undesirable side effect of company being triggered in a hidden
buffer (this is analogous to the problem with org mode hidden buffer
and yasnippet that I recently reported). Try disabling company mode in
python font lock buffer; even though, this is not necessary if (i)
above is fixed, which IMO should be done independently of the nasty
company interaction.

Besides, remember that patch 2 is fixing two different issues. This is
somewhat undesirable but there are a lot of overlapping between them.
Nevertheless, I provided patch 1 in case you are unwilling to apply
one of them.

Best regards
--
Carlos





  reply	other threads:[~2019-04-16 21:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  2:08 bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled Carlos Pita
2019-01-03  2:34 ` bug#33959: Carlos Pita
2019-01-03  4:40   ` bug#33959: Carlos Pita
2019-01-03  5:38     ` bug#33959: Carlos Pita
2019-04-05  2:36       ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-04-16 21:47         ` Carlos Pita [this message]
2019-04-16 22:04           ` Noam Postavsky
2019-04-16 22:08             ` Carlos Pita
2019-04-16 22:14               ` Carlos Pita
2019-04-16 23:01                 ` Noam Postavsky
2019-04-16 23:51                   ` Noam Postavsky
2019-05-11  3:51                     ` Noam Postavsky
2019-04-05  2:55 ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc " Noam Postavsky
2019-04-16 20:42   ` Carlos Pita
2019-10-13 19:39 ` bug#33959: Carlos Pita
2019-10-13 19:44   ` bug#33959: Lars Ingebrigtsen
2019-10-13 19:51     ` bug#33959: Carlos Pita
2019-10-15  0:34   ` bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Noam Postavsky
2019-10-15  0:52     ` Carlos Pita
2019-10-15  0:58       ` Carlos Pita
2019-10-16 20:35         ` Carlos Pita
2019-10-21 20:56           ` Carlos Pita
2019-10-23  0:18           ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAELgYheVNHGrNE2bJycwp8Re2sPnPzKbCOYsqZ8hMiSeVwPwxw@mail.gmail.com \
    --to=carlosjosepita@gmail.com \
    --cc=33959@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).